Issue 3402007: run_remote_tests: destroy the with_spaces hack, use the --args instead of -a (which doesn't work)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3402007: run_remote_tests: destroy the with_spaces hack, use the --args instead of -a (which doesn't work) (Closed)

Created:
10 years, 3 months ago by zbehan

Modified:
9 years, 7 months ago

Reviewers:
asharif1, kmixter1, whywhat

CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa

Base URL:
ssh://git@gitrw.chromium.org:9222/crosutils.git

Visibility:
Public.

Description

run_remote_tests: destroy the with_spaces hack, use the --args instead of -a (which doesn't work) Change-Id: I8560a4400463d04b7a2441ce6fa9dc9cec834242 BUG= TEST=run_remote_tests.sh --args='-n 10', and make sure it gets all the way into autotest_run.sh

Patch Set 1 #

Patch Set 2 : Just added another reviewer #

Created: 10 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -7 lines)			Patch
	M	run_remote_tests.sh	View		2 chunks	+4 lines, -7 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

kmixter1

LGTM if avayvod is ok with removing his ',' -> ' ' code. On Wed, ...

10 years, 3 months ago (2010-09-16 00:30:38 UTC) #3

zbehan

Right, I totally forgot to include him. On 2010/09/16 00:30:38, kmixter1 wrote: > LGTM if ...

10 years, 3 months ago (2010-09-16 00:31:56 UTC) #4

zbehan

10 years, 3 months ago (2010-09-16 21:29:20 UTC) #7

On 2010/09/16 07:04:25, whywhat wrote:
> LGTM, glad that better solution is found!

Awesome. The better way is in fact the previous commit, but I wanted you to get
a FYI about changing this, because the old hacky way (using comma) stops working
after this.

Expand Messages | Collapse Messages