Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(561)

Unified Diff: run_remote_tests.sh

Issue 3402007: run_remote_tests: destroy the with_spaces hack, use the --args instead of -a (which doesn't work) (Closed) Base URL: ssh://git@gitrw.chromium.org:9222/crosutils.git
Patch Set: Just added another reviewer Created 10 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: run_remote_tests.sh
diff --git a/run_remote_tests.sh b/run_remote_tests.sh
index dbae24e66616a757047d0ad80156ee52cc103d83..805c80966c4d471125f886c03342b3aa937766f5 100755
--- a/run_remote_tests.sh
+++ b/run_remote_tests.sh
@@ -238,12 +238,6 @@ function main() {
if [[ ${FLAGS_verbose} -eq $FLAGS_TRUE ]]; then
verbose="--verbose"
fi
- local args=()
- if [[ -n "${FLAGS_args}" ]]; then
- local with_spaces=""
- with_spaces=${FLAGS_args//,/ }
- args=("-a" "${with_spaces}")
- fi
RAN_ANY_TESTS=${FLAGS_TRUE}
@@ -263,11 +257,14 @@ function main() {
control_file="${control_file:${#chrome_autotests}+1}"
echo_color "yellow" ">>> Running chrome autotest " ${control_file}
fi
+ if [[ -n "${FLAGS_args}" ]]; then
+ passthrough_args="--args=${FLAGS_args}"
+ fi
${enter_chroot} ${autotest} --board "${FLAGS_board}" -m "${FLAGS_remote}" \
--ssh-port ${FLAGS_ssh_port} \
"${option}" "${control_file}" -r "${results_dir}" ${verbose} \
- "${args[@]}"
+ "${passthrough_args}"
done
echo ""
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698