Issue 340080: Linux Breakpad: Report process uptime in crash reports.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 340080: Linux Breakpad: Report process uptime in crash reports. (Closed)

Created:
11 years, 1 month ago by Lei Zhang

Modified:
9 years, 7 months ago

Reviewers:
agl

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Linux Breakpad: Report process uptime in crash reports. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30889

Patch Set 2 : '' #

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+51 lines, -2 lines)			Patch
	M	chrome/app/breakpad_linux.cc	View	1	6 chunks	+51 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

agl

LGTM http://codereview.chromium.org/340080/diff/1/2 File chrome/app/breakpad_linux.cc (right): http://codereview.chromium.org/340080/diff/1/2#newcode277 Line 277: char time_str[16]; s/16/21/ to keep an old ...

11 years, 1 month ago (2009-11-03 22:44:06 UTC) #2

Lei Zhang

11 years, 1 month ago (2009-11-03 22:56:25 UTC) #3

On 2009/11/03 22:44:06, agl wrote:
> LGTM
> 
> http://codereview.chromium.org/340080/diff/1/2
> File chrome/app/breakpad_linux.cc (right):
> 
> http://codereview.chromium.org/340080/diff/1/2#newcode277
> Line 277: char time_str[16];
> s/16/21/ to keep an old man happy :) (Max possible length of an int64)

Done. I'd be amazed if Chrome can have that long of an uptime.

Expand Messages | Collapse Messages

Issue 340080: Linux Breakpad: Report process uptime in crash reports. (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Messages