Chromium Code Reviews

Issue 340080: Linux Breakpad: Report process uptime in crash reports. (Closed)

Created:
11 years, 1 month ago by Lei Zhang
Modified:
9 years, 7 months ago
Reviewers:
agl
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Linux Breakpad: Report process uptime in crash reports. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30889

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Stats (+51 lines, -2 lines)
M chrome/app/breakpad_linux.cc View 6 chunks +51 lines, -2 lines 0 comments

Messages

Total messages: 3 (0 generated)
Lei Zhang
Windows/Mac reports this.
11 years, 1 month ago (2009-11-03 22:31:47 UTC) #1
agl
LGTM http://codereview.chromium.org/340080/diff/1/2 File chrome/app/breakpad_linux.cc (right): http://codereview.chromium.org/340080/diff/1/2#newcode277 Line 277: char time_str[16]; s/16/21/ to keep an old ...
11 years, 1 month ago (2009-11-03 22:44:06 UTC) #2
Lei Zhang
11 years, 1 month ago (2009-11-03 22:56:25 UTC) #3 
On 2009/11/03 22:44:06, agl wrote:
> LGTM
> 
> http://codereview.chromium.org/340080/diff/1/2
> File chrome/app/breakpad_linux.cc (right):
> 
> http://codereview.chromium.org/340080/diff/1/2#newcode277
> Line 277: char time_str[16];
> s/16/21/ to keep an old man happy :) (Max possible length of an int64)

Done. I'd be amazed if Chrome can have that long of an uptime.

Powered by Google App Engine