Issue 340077: Gets find bar animation/clipping to work on views/gtk.

Issue 340077: Gets find bar animation/clipping to work on views/gtk. (Closed)

Created:
11 years, 1 month ago by sky

Modified:
9 years, 7 months ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews_googlegroups.com, brettw+cc_chromium.org, ben+cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Gets find bar animation/clipping to work on views/gtk. BUG=none TEST=none

Patch Set 1 #

Total comments: 1

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+298 lines, -160 lines)			Patch
M	app/app.gyp	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	app/gfx/native_widget_types.h	View	3 chunks	+3 lines, -0 lines	0 comments	Download
M	app/gfx/path.h	View	1 chunk	+28 lines, -15 lines	0 comments	Download
A	app/gfx/path.cc	View	1 chunk	+18 lines, -0 lines	0 comments	Download
M	app/gfx/path_gtk.cc	View	2 chunks	+22 lines, -1 line	0 comments	Download
M	app/gfx/path_win.cc	View	2 chunks	+22 lines, -1 line	0 comments	Download
M	app/win_util.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	base/base.gyp	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	base/scoped_handle.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
A	base/scoped_handle_gtk.h	View	1 chunk	+50 lines, -0 lines	0 comments	Download
M	base/scoped_handle_win.h	View	2 chunks	+7 lines, -1 line	0 comments	Download
M	chrome/browser/dock_info_win.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/views/autocomplete/autocomplete_popup_contents_view.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/views/blocked_popup_container_view_views.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/views/find_bar_host.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/views/find_bar_host.cc	View	4 chunks	+120 lines, -0 lines	1 comment	Download
M	chrome/browser/views/find_bar_host_gtk.cc	View	2 chunks	+7 lines, -8 lines	0 comments	Download
M	chrome/browser/views/find_bar_host_win.cc	View	1 chunk	+0 lines, -111 lines	0 comments	Download
M	chrome/browser/views/notifications/balloon_view.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	views/view.cc	View	1 chunk	+3 lines, -5 lines	0 comments	Download
M	views/widget/widget.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	views/widget/widget_gtk.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	views/widget/widget_gtk.cc	View	1 chunk	+1 line, -3 lines	0 comments	Download
M	views/widget/widget_win.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	views/widget/widget_win.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	views/window/window_gtk.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	views/window/window_win.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Ben Goodger (Google)

11 years, 1 month ago (2009-11-03 22:58:54 UTC) #2

LGTM

http://codereview.chromium.org/340077/diff/1/23
File chrome/browser/views/find_bar_host.cc (right):

http://codereview.chromium.org/340077/diff/1/23#newcode262
Line 262: // TODO(brettw) this should not be so complicated. The view should
really be in
You can get rid of this comment now.

Expand Messages | Collapse Messages