Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(484)

Issue 340065: Upgrade google-perftools to revision 77... (Closed)

Created:
11 years, 1 month ago by Timur Iskhodzhanov
Modified:
9 years, 6 months ago
CC:
chromium-reviews_googlegroups.com, not_the_right_glider
Visibility:
Public.

Description

Upgrade google-perftools to revision 77 This brings several bugfixes needed for turning on the heap leak checker inside tcmalloc. Unforked malloc_hook.cc for Linux This patch was prepared by Alexander Potapenko (cc'ed) and originally reviewed as http://codereview.chromium.org/339065 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30735

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -514 lines) Patch
M DEPS View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/tcmalloc/config.h View 1 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/tcmalloc/config_linux.h View 1 3 chunks +6 lines, -3 lines 0 comments Download
M third_party/tcmalloc/config_win.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/tcmalloc/malloc_hook.cc View 1 1 chunk +0 lines, -502 lines 0 comments Download
M third_party/tcmalloc/tcmalloc.gyp View 1 5 chunks +4 lines, -8 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Timur Iskhodzhanov
Hi Dan, Will Can you please re-LGTM this patch (copied from http://codereview.chromium.org/339065 since Alexander doesn't ...
11 years, 1 month ago (2009-11-02 19:27:44 UTC) #1
dank
LGTM I can revert it if it breaks, but someone else might be able to ...
11 years, 1 month ago (2009-11-02 19:33:06 UTC) #2
willchan no longer on Chromium
LGTM, please ping the thread when you commit, and I'll keep an eye on the ...
11 years, 1 month ago (2009-11-02 20:06:47 UTC) #3
not_the_right_dank
He committed... On Mon, Nov 2, 2009 at 12:06 PM, <willchan@chromium.org> wrote: > > LGTM, ...
11 years, 1 month ago (2009-11-02 20:18:09 UTC) #4
willchan no longer on Chromium
Ok, I'm watching. On Mon, Nov 2, 2009 at 12:17 PM, Dan Kegel <dank@kegel.com> wrote: ...
11 years, 1 month ago (2009-11-02 20:25:47 UTC) #5
not_the_right_dank
11 years, 1 month ago (2009-11-02 20:40:30 UTC) #6
one failure... waiting to see if next cycle also red...

On Mon, Nov 2, 2009 at 12:25 PM, William Chan (=E9=99=88=E6=99=BA=E6=98=8C)
<willchan@chromium.org> wrote:
>
> Ok, I'm watching.
>
> On Mon, Nov 2, 2009 at 12:17 PM, Dan Kegel <dank@kegel.com> wrote:
>>
>> He committed...
>>
>> On Mon, Nov 2, 2009 at 12:06 PM, =C2=A0<willchan@chromium.org> wrote:
>>>
>>> LGTM, please ping the thread when you commit, and I'll keep an eye on t=
he
>>> buildbots.
>>>
>>> On 2009/11/02 19:33:06, dank wrote:
>>>>
>>>> LGTM
>>>
>>>> I can revert it if it breaks, but someone else might be able to do it
>>>> faster.
>>>
>>>
>>>
>>> http://codereview.chromium.org/340065
>>>
>>
>

Powered by Google App Engine
This is Rietveld 408576698