Issue 340043: Fix build bustage.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 340043: Fix build bustage. (Closed)

Created:
11 years, 1 month ago by darin (slow to review)

Modified:
9 years, 7 months ago

Reviewers:
yaar

CC:
chromium-reviews_googlegroups.com, darin (slow to review)

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Fix build bustage. TBR=yaar Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30559

Patch Set 1 #

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -3 lines)			Patch
	M	webkit/api/src/InspectorClientImpl.cpp	View		1 chunk	+1 line, -0 lines	0 comments	Download
	M	webkit/api/src/WebViewImpl.h	View		2 chunks	+1 line, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

darin (slow to review)

11 years, 1 month ago (2009-10-30 05:09:24 UTC) #3

this fixed the mainline bots.  it is really strange that the try bots passed
previously without alerting me to this problem! :(

On Thu, Oct 29, 2009 at 9:50 PM, <yaar@chromium.org> wrote:

> LGTM, but note that the trybots are still RED.
>
>
>
> http://codereview.chromium.org/340043
>

Expand Messages | Collapse Messages