Issue 340034: Rename the Location type tags to be consistent with our current naming...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 340034: Rename the Location type tags to be consistent with our current naming... (Closed)

Created:
11 years, 1 month ago by Kevin Millikin (Chromium)

Modified:
9 years, 7 months ago

Reviewers:
William Hesse, fschneider

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Rename the Location type tags to be consistent with our current naming scheme for enumerations (eg, EFFECT => kEffect). Remove the ability to move from one Location to another, which should never be necessary. Committed: http://code.google.com/p/v8/source/detail?r=3175

Patch Set 1 #

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+100 lines, -131 lines)			Patch
M	src/arm/fast-codegen-arm.cc	View	9 chunks	+26 lines, -30 lines	0 comments	Download
M	src/fast-codegen.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	src/fast-codegen.cc	View	2 chunks	+6 lines, -27 lines	0 comments	Download
M	src/ia32/fast-codegen-ia32.cc	View	10 chunks	+29 lines, -33 lines	0 comments	Download
M	src/location.h	View	1 chunk	+10 lines, -6 lines	0 comments	Download
M	src/x64/fast-codegen-x64.cc	View	10 chunks	+29 lines, -33 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM.

Expand Messages | Collapse Messages