Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(286)

Unified Diff: src/fast-codegen.cc

Issue 340034: Rename the Location type tags to be consistent with our current naming... (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: Created 11 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/fast-codegen.h ('k') | src/ia32/fast-codegen-ia32.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/fast-codegen.cc
===================================================================
--- src/fast-codegen.cc (revision 3171)
+++ src/fast-codegen.cc (working copy)
@@ -71,36 +71,15 @@
}
-void FastCodeGenerator::Move(Location destination, Location source) {
- switch (destination.type()) {
- case Location::UNINITIALIZED:
- UNREACHABLE();
-
- case Location::EFFECT:
- break;
-
- case Location::VALUE:
- switch (source.type()) {
- case Location::UNINITIALIZED: // Fall through.
- case Location::EFFECT:
- UNREACHABLE();
- case Location::VALUE:
- break;
- }
- break;
- }
-}
-
-
// All platform macro assemblers in {ia32,x64,arm} have a push(Register)
// function.
void FastCodeGenerator::Move(Location destination, Register source) {
switch (destination.type()) {
- case Location::UNINITIALIZED:
+ case Location::kUninitialized:
UNREACHABLE();
- case Location::EFFECT:
+ case Location::kEffect:
break;
- case Location::VALUE:
+ case Location::kValue:
masm_->push(source);
break;
}
@@ -111,10 +90,10 @@
// function.
void FastCodeGenerator::Move(Register destination, Location source) {
switch (source.type()) {
- case Location::UNINITIALIZED: // Fall through.
- case Location::EFFECT:
+ case Location::kUninitialized: // Fall through.
+ case Location::kEffect:
UNREACHABLE();
- case Location::VALUE:
+ case Location::kValue:
masm_->pop(destination);
}
}
« no previous file with comments | « src/fast-codegen.h ('k') | src/ia32/fast-codegen-ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698