Fix window restore behaviour on Mac.

Fix window restore behaviour on Mac.

On the mac, there can be no windows, but the application is sitll open. This
confused "Restore the pages that were open last" so that it would restore
when opening a new window.

BUG=13341
TEST=Open chromium. Set On Startup to "Restore the pages that were open last".
Open a few tabs. Close the window (but not chromium). Click the dock icon.
The tabs shouldn't be restored. But if you quit chrome and start again,
things should reopen.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30463

[Elliot Glaysher, 2009-10-28 21:25:56]

Scott,

I'm pretty sure you can tell me if this is the right approach or not. I've
tested this change on both linux and windows and it doesn't break session
restore.

[sky, 2009-10-28 21:48:27]

This code is hit with app windows or popups. For app windows we want to give the
illusion that an app window is running in a separate process. This means that if
you have a tabbed browser up and an app window, close the tabbed browser, then
create a new tabbed browser we session restore the tabbed browser. Similar
behavior happens with popups.

I'm not sure what the right thing to do on a mac is. That depends upon how app
windows are treated. It's worth a discussion with the ux folks to figure out how
we want session restore to behave on a Mac. We may need to change session
service a bit more to deal with what's decided.

[Elliot Glaysher, 2009-10-28 21:57:08]

Application support has been punted entirely for beta. Can I just
ifdef this out on Mac then?

On Wed, Oct 28, 2009 at 2:48 PM,  <sky@chromium.org> wrote:
> This code is hit with app windows or popups. For app windows we want to give
> the
> illusion that an app window is running in a separate process. This means
> that if
> you have a tabbed browser up and an app window, close the tabbed browser,
> then
> create a new tabbed browser we session restore the tabbed browser. Similar
> behavior happens with popups.
>
> I'm not sure what the right thing to do on a mac is. That depends upon how
> app
> windows are treated. It's worth a discussion with the ux folks to figure out
> how
> we want session restore to behave on a Mac. We may need to change session
> service a bit more to deal with what's decided.
>
> http://codereview.chromium.org/340023
>

[sky, 2009-10-28 22:27:05]

You should ifdef out the whole if starting on line 412. I think you're
going to want to also #ifdef out all the insertions into
pending_window_close_ids_ too.

  -Scott

On Wed, Oct 28, 2009 at 2:56 PM, Elliot Glaysher (Chromium)
<erg@chromium.org> wrote:
> Application support has been punted entirely for beta. Can I just
> ifdef this out on Mac then?
>
> On Wed, Oct 28, 2009 at 2:48 PM, =A0<sky@chromium.org> wrote:
>> This code is hit with app windows or popups. For app windows we want to =
give
>> the
>> illusion that an app window is running in a separate process. This means
>> that if
>> you have a tabbed browser up and an app window, close the tabbed browser=
,
>> then
>> create a new tabbed browser we session restore the tabbed browser. Simil=
ar
>> behavior happens with popups.
>>
>> I'm not sure what the right thing to do on a mac is. That depends upon h=
ow
>> app
>> windows are treated. It's worth a discussion with the ux folks to figure=
 out
>> how
>> we want session restore to behave on a Mac. We may need to change sessio=
n
>> service a bit more to deal with what's decided.
>>
>> http://codereview.chromium.org/340023
>>
>

[Elliot Glaysher, 2009-10-28 23:14:13]

On 2009/10/28 22:27:05, sky wrote:
> You should ifdef out the whole if starting on line 412. I think you're
> going to want to also #ifdef out all the insertions into
> pending_window_close_ids_ too.

Instead of #ifdefing it out, tried to copy what BrowserInit did instead. Take
another look?

[sky, 2009-10-28 23:28:11]

http://codereview.chromium.org/340023/diff/4005/4006
File chrome/browser/app_controller_cppsafe_mac.h (right):

http://codereview.chromium.org/340023/diff/4005/4006#newcode10
Line 10: namespace MacAppController {
Namespaces should be lower case with under scores. I would also name it to match
the file, eg app_controller.

Should this be something like mac_utils?

http://codereview.chromium.org/340023/diff/4005/4006#newcode17
Line 17: }  // namespace AppController
nit: match namespace name.

[Elliot Glaysher, 2009-10-28 23:49:05]

Done.

[sky, 2009-10-28 23:52:11]

LGTM