Issue 340009: Changes bookmark html writer test to lookup string rather than hard...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 340009: Changes bookmark html writer test to lookup string rather than hard... (Closed)

Created:
11 years, 1 month ago by sky

Modified:
9 years, 7 months ago

Reviewers:
jungshik, jungshik at Google

CC:
chromium-reviews_googlegroups.com, ben+cc_chromium.org, Paweł Hajdan Jr.

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Changes bookmark html writer test to lookup string rather than hard coding. I can't think of a good reason why we were hard coding it before. BUG=17592 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30373

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -14 lines)			Patch
	M	chrome/browser/bookmarks/bookmark_html_writer_unittest.cc	View		4 chunks	+9 lines, -14 lines	0 comments	Download

Total messages: 2 (0 generated)

jungshik at Google

11 years, 1 month ago (2009-10-27 22:09:20 UTC) #2

LGTM 

I don't remember why I did that way. Perhaps for no reason.