Changes bookmark html writer test to lookup string rather than hard...

chrome/browser/bookmarks/bookmark_html_writer_unittest.cc

 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "testing/gtest/include/gtest/gtest.h"
 
+#include "app/l10n_util.h"
 #include "base/file_util.h"
 #include "base/path_service.h"
 #include "base/string_util.h"
 #include "base/time.h"
 #include "base/i18n/time_formatting.h"
 #include "chrome/browser/bookmarks/bookmark_html_writer.h"
 #include "chrome/browser/bookmarks/bookmark_model.h"
 #include "chrome/browser/importer/firefox2_importer.h"
+#include "grit/generated_resources.h"
 
 class BookmarkHTMLWriterTest : public testing::Test {
  protected:
   virtual void SetUp() {
     ASSERT_TRUE(PathService::Get(base::DIR_TEMP, &path_));
     path_ = path_.AppendASCII("bookmarks.html");
     file_util::Delete(path_, true);
   }
 
   virtual void TearDown() {
@@ skipping 66 matching lines @@
     EXPECT_EQ(BookmarkValuesToString(on_toolbar, url, title, creation_time,
                                      f1, f2, f3),
               BookmarkEntryToString(entry));
   }
 
   FilePath path_;
 };
 
 // Tests bookmark_html_writer by populating a BookmarkModel, writing it out by
 // way of bookmark_html_writer, then using the importer to read it back in.
-// Flaky, http://crbug.com/17592.
-TEST_F(BookmarkHTMLWriterTest, FLAKY_Test) {
+TEST_F(BookmarkHTMLWriterTest, Test) {
   // Populate the BookmarkModel. This creates the following bookmark structure:
   // Bookmarks bar
   //   F1
   //     url1
   //     F2
   //       url2
   //   url3
   //   url4
   // Other
   //   url1
@@ skipping 38 matching lines @@
   bookmark_html_writer::WriteBookmarks(NULL, &model, path_);
 
   // Read the bookmarks back in.
   std::vector<ProfileWriter::BookmarkEntry> parsed_bookmarks;
   Firefox2Importer::ImportBookmarksFile(path_.ToWStringHack(), std::set<GURL>(),
                                         false, L"x", NULL, &parsed_bookmarks,
                                         NULL, NULL);
 
   // Verify we got back what we wrote.
   ASSERT_EQ(7U, parsed_bookmarks.size());
-  // Hardcode the value of IDS_BOOKMARK_BAR_FOLDER_NAME in en-US locale
-  // because all the unit tests are run in en-US locale.
-#if defined(OS_WIN) || defined(TOOLKIT_VIEWS)
   // Windows and ChromeOS builds use Sentence case.
-  const wchar_t* kBookmarkBarFolderName = L"Bookmarks bar";
-#else
-  // Mac and Linux + GTK uses Title Case.
-  const wchar_t* kBookmarkBarFolderName = L"Bookmarks Bar";
-#endif
+  std::wstring bookmark_folder_name =
+      l10n_util::GetString(IDS_BOOMARK_BAR_FOLDER_NAME);
   AssertBookmarkEntryEquals(parsed_bookmarks[0], false, url1, url1_title, t1,
-                            kBookmarkBarFolderName, f1_title, std::wstring());
+                            bookmark_folder_name, f1_title, std::wstring());
   AssertBookmarkEntryEquals(parsed_bookmarks[1], false, url2, url2_title, t2,
-                            kBookmarkBarFolderName, f1_title, f2_title);
+                            bookmark_folder_name, f1_title, f2_title);
   AssertBookmarkEntryEquals(parsed_bookmarks[2], false, url3, url3_title, t3,
-                            kBookmarkBarFolderName, std::wstring(),
+                            bookmark_folder_name, std::wstring(),
                             std::wstring());
   AssertBookmarkEntryEquals(parsed_bookmarks[3], false, url4, url4_title, t4,
-                            kBookmarkBarFolderName, std::wstring(),
+                            bookmark_folder_name, std::wstring(),
                             std::wstring());
   AssertBookmarkEntryEquals(parsed_bookmarks[4], false, url1, url1_title, t1,
                             std::wstring(), std::wstring(), std::wstring());
   AssertBookmarkEntryEquals(parsed_bookmarks[5], false, url2, url2_title, t2,
                             std::wstring(), std::wstring(), std::wstring());
   AssertBookmarkEntryEquals(parsed_bookmarks[6], false, url1, url1_title, t1,
                             f3_title, f4_title, std::wstring());
 }