Update a couple tests for make functionality (working as intended).

Update a couple tests for make functionality (working as intended).

Committed: http://code.google.com/p/gyp/source/detail?r=727

[Evan Martin, 2009-10-27 19:01:56]

http://codereview.chromium.org/340008/diff/1/2
File test/subdirectory/gyptest-subdir-all.py (right):

http://codereview.chromium.org/340008/diff/1/2#newcode28
Line 28: # equilvalent to the sub-project .sln/SConstruct/etc. files of other
generators?
If so, I'd think they should just cd to the top-level directory and run make
with the appropriate targets or something.  Recursive make is murder for
performance.

http://codereview.chromium.org/340008/diff/1/2#newcode44
Line 44: if e.errno != 2:
Is there some way to get a constant instead of 2?  Maybe it's in os somewhere.

[Michael Moss, 2009-10-27 19:16:26]

> If so, I'd think they should just cd to the top-level directory and run make
> with the appropriate targets or something.  Recursive make is murder for
> performance.

Yeah, I wasn't thinking recursive make, more like a stub Makefile in each
sub-project, to supply missing variables, set the 'all' target properly, etc.
This probably could just call the top-level Makefile, like you suggest, though
we might need to make a few more settings configurable than what we have now
(off the top of my head, I think 'builddir' would have to be set, to get
comparable behaviour to other generators).

> http://codereview.chromium.org/340008/diff/1/2#newcode44
> Line 44: if e.errno != 2:
> Is there some way to get a constant instead of 2?  Maybe it's in os somewhere.

Yup, they're in 'errno'. Done.

[Evan Martin, 2009-10-27 19:25:39]

LGTM

http://codereview.chromium.org/340008/diff/4001/4002
File test/subdirectory/gyptest-subdir-all.py (right):

http://codereview.chromium.org/340008/diff/4001/4002#newcode28
Line 28: # TODO(mmoss) Should make create self-contained, sub-project Makefiles,
s/Should/Should we/
?
Here and in the other file

[Michael Moss, 2009-10-27 19:38:10]

http://codereview.chromium.org/340008/diff/4001/4002
File test/subdirectory/gyptest-subdir-all.py (right):

http://codereview.chromium.org/340008/diff/4001/4002#newcode28
Line 28: # TODO(mmoss) Should make create self-contained, sub-project Makefiles,
Actually, that's meant to read "Should (the) make (generator) create ...". I can
clarify.