AU: Skip all automatic update checks if OOBE is not complete.

AU: Skip all automatic update checks if OOBE is not complete.

Right before an automatic update check is initiated, check if OOBE is
complete. If it is, go ahead with the check. Otherwise, skip the check
and schedule a new one as if it is the first one.

BUG=5377
TEST=unit tests, gmerged on device and tried with/without .oobe_completed.

Change-Id: I713e156a176b58a4dd04a01bca340b88277b0361

Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=2a0e633

[adlr, 2010-09-22 19:10:38]

LGTM

[Dmitry Polukhin, 2010-09-23 10:00:48]

LGTM

[petkov, 2010-09-23 16:46:25]

adlr, dpolukhin, nkostylev: Do we create the /home/chronos/.oobe_completed file
in existing dogfood devices? If not, they will become unupdatable once this CL
is pushed.

Maybe we should check if the file exists OR the board is x86-dogfood? Of course,
this won't cover any non-x86-dogfood devices that are being dogfooded...

Thoughts?

[Dmitry Polukhin, 2010-09-23 16:58:22]

This file should exist for all current users (and will be recreated if it is
deleted somehow). We had such bug but it was fixed. Please let me know if you
observed any issue with this file.

[petkov, 2010-09-23 17:01:33]

On 2010/09/23 16:58:22, Dmitry Polukhin wrote:
> This file should exist for all current users (and will be recreated if it is
> deleted somehow). We had such bug but it was fixed. Please let me know if you
> observed any issue with this file.

I have an x86-dogfood device auto-updated to 0.8.70.5 Chrome OS official build.
Using file:///home/chronos, I don't see the .ooobe_completed file.

[adlr, 2010-09-23 18:13:59]

On Thu, Sep 23, 2010 at 10:01 AM, <petkov@chromium.org> wrote:

> On 2010/09/23 16:58:22, Dmitry Polukhin wrote:
>
>> This file should exist for all current users (and will be recreated if it
>> is
>> deleted somehow). We had such bug but it was fixed. Please let me know if
>> you
>> observed any issue with this file.
>>
>
> I have an x86-dogfood device auto-updated to 0.8.70.5 Chrome OS official
> build.
> Using file:///home/chronos, I don't see the .ooobe_completed file.


Ohh! Of course, do not submit until this is resolved.


>
>
>
> http://codereview.chromium.org/3398018/show
>

[Dmitry Polukhin, 2010-09-23 18:52:14]

It is very strange. Do you have any remembered user on login screen? Do you
use test image or image with extra Chrome flags in sessions_manager_setup
file?

We have special check that creates .oobe_completed file on login if there
are remembered users:
https://cs.corp.google.com/p#chrome/trunk/src/chrome/browser/chromeos/login/w...
should observe progress but this file is missing.

On Thu, Sep 23, 2010 at 10:13 PM, Andrew de los Reyes <adlr@chromium.org>wrote:

>
>
> On Thu, Sep 23, 2010 at 10:01 AM, <petkov@chromium.org> wrote:
>
>> On 2010/09/23 16:58:22, Dmitry Polukhin wrote:
>>
>>> This file should exist for all current users (and will be recreated if it
>>> is
>>> deleted somehow). We had such bug but it was fixed. Please let me know if
>>> you
>>> observed any issue with this file.
>>>
>>
>> I have an x86-dogfood device auto-updated to 0.8.70.5 Chrome OS official
>> build.
>> Using file:///home/chronos, I don't see the .ooobe_completed file.
>
>
> Ohh! Of course, do not submit until this is resolved.
>
>
>>
>>
>>
>> http://codereview.chromium.org/3398018/show
>>
>
>

[Dmitry Polukhin, 2010-09-23 18:53:33]

BTW, it is hidden file so it might be not visible in UI.

On Thu, Sep 23, 2010 at 10:51 PM, Dmitry Polukhin <dpolukhin@chromium.org>wrote:

> It is very strange. Do you have any remembered user on login screen? Do you
> use test image or image with extra Chrome flags in sessions_manager_setup
> file?
>
> We have special check that creates .oobe_completed file on login if there
> are remembered users:
>
https://cs.corp.google.com/p#chrome/trunk/src/chrome/browser/chromeos/login/w...
should observe progress but this file is missing.
>
> On Thu, Sep 23, 2010 at 10:13 PM, Andrew de los Reyes
<adlr@chromium.org>wrote:
>
>>
>>
>> On Thu, Sep 23, 2010 at 10:01 AM, <petkov@chromium.org> wrote:
>>
>>> On 2010/09/23 16:58:22, Dmitry Polukhin wrote:
>>>
>>>> This file should exist for all current users (and will be recreated if
>>>> it is
>>>> deleted somehow). We had such bug but it was fixed. Please let me know
>>>> if you
>>>> observed any issue with this file.
>>>>
>>>
>>> I have an x86-dogfood device auto-updated to 0.8.70.5 Chrome OS official
>>> build.
>>> Using file:///home/chronos, I don't see the .ooobe_completed file.
>>
>>
>> Ohh! Of course, do not submit until this is resolved.
>>
>>
>>>
>>>
>>>
>>> http://codereview.chromium.org/3398018/show
>>>
>>
>>
>

[petkov, 2010-09-23 19:02:42]

On 2010/09/23 18:52:14, Dmitry Polukhin wrote:
> It is very strange. Do you have any remembered user on login screen?

Yes, I do -- several.

> Do you use test image or image with extra Chrome flags in
sessions_manager_setup
> file?

I use an official dog food image subscribed to dev channel. No local
modifications, I think.

> 
> We have special check that creates .oobe_completed file on login if there
> are remembered users:
>
https://cs.corp.google.com/p#chrome/trunk/src/chrome/browser/chromeos/login/w...
> should observe progress but this file is missing.

This code is guarded by oobe_complete which is set by IsOobeCompleted. Maybe
this returns false?

Also, do you know if this code is in Chrome 7.0.511.3 (which is part of Chrome
OS 0.8.70.5)?

> 
> On Thu, Sep 23, 2010 at 10:13 PM, Andrew de los Reyes
<adlr@chromium.org>wrote:
> 
> >
> >
> > On Thu, Sep 23, 2010 at 10:01 AM, <mailto:petkov@chromium.org> wrote:
> >
> >> On 2010/09/23 16:58:22, Dmitry Polukhin wrote:
> >>
> >>> This file should exist for all current users (and will be recreated if it
> >>> is
> >>> deleted somehow). We had such bug but it was fixed. Please let me know if
> >>> you
> >>> observed any issue with this file.
> >>>
> >>
> >> I have an x86-dogfood device auto-updated to 0.8.70.5 Chrome OS official
> >> build.
> >> Using file:///home/chronos, I don't see the .ooobe_completed file.
> >
> >
> > Ohh! Of course, do not submit until this is resolved.
> >
> >
> >>
> >>
> >>
> >> http://codereview.chromium.org/3398018/show
> >>
> >
> >
>

[petkov, 2010-09-23 19:03:15]

On 2010/09/23 18:53:33, Dmitry Polukhin wrote:
> BTW, it is hidden file so it might be not visible in UI.

I see several files starting with . so I assume I'd see the .oobe_completed file
too.

[petkov, 2010-09-23 19:08:50]

> > We have special check that creates .oobe_completed file on login if there
> > are remembered users:
> >
>
https://cs.corp.google.com/p#chrome/trunk/src/chrome/browser/chromeos/login/w...
> > should observe progress but this file is missing.
> 
> This code is guarded by oobe_complete which is set by IsOobeCompleted. Maybe
> this returns false?

Do you know which file I can check and what to look for to see if this flag is
set in Preferences? I checked a couple of Preferences files for OobeComplete but
I didn't find anything.

[petkov, 2010-09-23 19:13:13]

FWIW, I checked another dogfood device auto-updated to the same dev-channel
version and it does contain the .oobe_completed file.

So maybe it's just me then and it's safe to push this CL?

[Nikita (slow), 2010-09-24 14:02:59]

LGTM