Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(748)

Unified Diff: update_check_scheduler.h

Issue 3398018: AU: Skip all automatic update checks if OOBE is not complete. (Closed) Base URL: ssh://git@gitrw.chromium.org:9222/update_engine.git
Patch Set: fix comment Created 10 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | update_check_scheduler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: update_check_scheduler.h
diff --git a/update_check_scheduler.h b/update_check_scheduler.h
index e3158ed5e2395303bc83f6c2a30a9b8cc82b9908..2ba5253c3671c4e4da5d5d0083fd264c4b1e1816 100644
--- a/update_check_scheduler.h
+++ b/update_check_scheduler.h
@@ -60,6 +60,7 @@ class UpdateCheckScheduler {
FRIEND_TEST(UpdateCheckSchedulerTest, ComputeNextIntervalAndFuzzTest);
FRIEND_TEST(UpdateCheckSchedulerTest, GTimeoutAddSecondsTest);
FRIEND_TEST(UpdateCheckSchedulerTest, IsBootDeviceRemovableTest);
+ FRIEND_TEST(UpdateCheckSchedulerTest, IsOOBECompleteTest);
FRIEND_TEST(UpdateCheckSchedulerTest, IsOfficialBuildTest);
FRIEND_TEST(UpdateCheckSchedulerTest, RunBootDeviceRemovableTest);
FRIEND_TEST(UpdateCheckSchedulerTest, RunNonOfficialBuildTest);
@@ -72,13 +73,15 @@ class UpdateCheckScheduler {
FRIEND_TEST(UpdateCheckSchedulerTest, SetUpdateStatusIdleDisabledTest);
FRIEND_TEST(UpdateCheckSchedulerTest, SetUpdateStatusIdleEnabledTest);
FRIEND_TEST(UpdateCheckSchedulerTest, SetUpdateStatusNonIdleTest);
- FRIEND_TEST(UpdateCheckSchedulerTest, StaticCheckTest);
+ FRIEND_TEST(UpdateCheckSchedulerTest, StaticCheckOOBECompleteTest);
+ FRIEND_TEST(UpdateCheckSchedulerTest, StaticCheckOOBENotCompleteTest);
// Wraps GLib's g_timeout_add_seconds so that it can be mocked in tests.
virtual guint GTimeoutAddSeconds(guint interval, GSourceFunc function);
// Wrappers for utils functions so that they can be mocked in tests.
virtual bool IsBootDeviceRemovable();
+ virtual bool IsOOBEComplete();
virtual bool IsOfficialBuild();
// Returns true if an update check can be scheduled. An update check should
« no previous file with comments | « no previous file | update_check_scheduler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698