Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Issue 3394006: Merge 67627 - 2010-09-16 Tony Gentilcore <tonyg@chromium.org>... (Closed)

Created:
10 years, 3 months ago by tonyg
Modified:
9 years, 6 months ago
Reviewers:
tonyg
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/517/
Visibility:
Public.

Description

Merge 67627 - 2010-09-16 Tony Gentilcore <tonyg@chromium.org>; Reviewed by Adam Barth. Crash in WebCore::FrameLoader::shouldInterruptLoadForXFrameOptions https://bugs.webkit.org/show_bug.cgi?id=45833 * fast/parser/x-frame-options-detached-document-crash-expected.txt: Added. * fast/parser/x-frame-options-detached-document-crash.html: Added. Crashes before this patch. 2010-09-16 Tony Gentilcore <tonyg@chromium.org>; Reviewed by Adam Barth. Crash in WebCore::FrameLoader::shouldInterruptLoadForXFrameOptions https://bugs.webkit.org/show_bug.cgi?id=45833 Test: fast/parser/x-frame-options-detached-document-crash.html * dom/Document.cpp: (WebCore::Document::processHttpEquiv): Other branches in this method already test for a null frame. So it seems to make sense to test that here as well. BUG=55598 TBR=tonyg@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=67733

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5050 lines, -4 lines) Patch
M LayoutTests/ChangeLog View 1 chunk +1907 lines, -0 lines 0 comments Download
A + LayoutTests/fast/parser/x-frame-options-detached-document-crash.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/fast/parser/x-frame-options-detached-document-crash-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
M WebCore/ChangeLog View 1 chunk +3137 lines, -0 lines 0 comments Download
M WebCore/dom/Document.cpp View 1 chunk +8 lines, -6 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
tonyg
10 years, 3 months ago (2010-09-17 18:48:50 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698