Index: WebCore/ChangeLog |
=================================================================== |
--- WebCore/ChangeLog (revision 67732) |
+++ WebCore/ChangeLog (working copy) |
@@ -1,3 +1,3140 @@ |
+2010-09-16 Tony Gentilcore <tonyg@chromium.org> |
+ |
+ Reviewed by Adam Barth. |
+ |
+ Crash in WebCore::FrameLoader::shouldInterruptLoadForXFrameOptions |
+ https://bugs.webkit.org/show_bug.cgi?id=45833 |
+ |
+ Test: fast/parser/x-frame-options-detached-document-crash.html |
+ |
+ * dom/Document.cpp: |
+ (WebCore::Document::processHttpEquiv): Other branches in this method already test for a null frame. So it seems to make sense to test that here as well. |
+ |
+2010-09-16 Vangelis Kokkevis <vangelis@chromium.org> |
+ |
+ Reviewed by Darin Fisher. |
+ |
+ [chromium] ImageLayerChromium needs to keep a ref to the Image it uses |
+ so that it never tries to access an already destroyed Image. |
+ https://bugs.webkit.org/show_bug.cgi?id=45869 |
+ |
+ * platform/graphics/chromium/GraphicsLayerChromium.cpp: |
+ (WebCore::GraphicsLayerChromium::setContentsToImage): |
+ * platform/graphics/chromium/ImageLayerChromium.cpp: |
+ (WebCore::ImageLayerChromium::setContents): |
+ (WebCore::ImageLayerChromium::updateContents): |
+ * platform/graphics/chromium/ImageLayerChromium.h: |
+ |
+2010-09-16 Patrick Gansterer <paroga@paroga.com> |
+ |
+ Reviewed by Adam Roben. |
+ |
+ [WINCE] Add platform-specific Image methods |
+ https://bugs.webkit.org/show_bug.cgi?id=28272 |
+ |
+ * platform/graphics/wince/ImageWinCE.cpp: Added. |
+ (WebCore::RGBA32Buffer::asNewNativeImage): |
+ (WebCore::FrameData::clear): |
+ (WebCore::BitmapImage::getHBITMAPOfSize): |
+ (WebCore::BitmapImage::drawFrameMatchingSourceSize): |
+ (WebCore::BitmapImage::draw): |
+ (WebCore::Image::drawPattern): |
+ (WebCore::BitmapImage::drawPattern): |
+ (WebCore::BitmapImage::checkForSolidColor): |
+ |
+2010-09-16 Yury Semikhatsky <yurys@chromium.org> |
+ |
+ Reviewed by Pavel Feldman. |
+ |
+ Web Inspector: [REGRESSION] Scripts disappear from scripts panel after navigation |
+ https://bugs.webkit.org/show_bug.cgi?id=45890 |
+ |
+ * inspector/InspectorController.cpp: |
+ (WebCore::InspectorController::populateScriptObjects): |
+ (WebCore::InspectorController::restoreDebugger): |
+ (WebCore::InspectorController::restoreProfiler): |
+ * inspector/InspectorController.h: |
+ |
+2010-09-16 Satish Sampath <satish@chromium.org> |
+ |
+ Unreviewed, fixing a build break with VS 2008. |
+ |
+ Fix build break, add the namespace in a friend declaration to get MSVC recognize it properly. |
+ https://bugs.webkit.org/show_bug.cgi?id=45893 |
+ |
+ * fileapi/FileWriter.h: |
+ |
+2010-09-15 Philippe Normand <pnormand@igalia.com> |
+ |
+ Reviewed by Martin Robinson. |
+ |
+ [GStreamer] XOverlay API changes break the build |
+ https://bugs.webkit.org/show_bug.cgi?id=45810 |
+ |
+ Cope with the GStreamer XOverlay API change for the upcoming |
+ 0.10.31 version. |
+ No new tests, build fix only. |
+ |
+ * platform/graphics/gstreamer/GStreamerGWorld.cpp: |
+ (WebCore::GStreamerGWorld::setWindowOverlay): |
+ |
+2010-09-16 Andreas Kling <andreas.kling@nokia.com> |
+ |
+ Reviewed by Tor Arne Vestbø. |
+ |
+ [Qt] V8 port: Fix debug build |
+ |
+ Add missing inclusion of <wtf/text/CString.h> where necessary for debug builds. |
+ |
+ * history/PageCache.cpp: |
+ * html/HTMLElement.cpp: |
+ * html/HTMLMediaElement.cpp: |
+ * loader/DocumentLoader.cpp: |
+ * loader/icon/IconDatabase.cpp: |
+ * loader/icon/IconLoader.cpp: |
+ * storage/AbstractDatabase.cpp: |
+ * storage/Database.cpp: |
+ * storage/DatabaseSync.cpp: |
+ * storage/DatabaseTracker.cpp: |
+ |
+2010-09-16 Alexey Proskuryakov <ap@apple.com> |
+ |
+ Reviewed by Adam Barth. |
+ |
+ https://bugs.webkit.org/show_bug.cgi?id=45852 |
+ Range::selectNode and selectNodeContents misbehave when argument is in another document |
+ |
+ Test: fast/dom/Range/select-node-different-document.html |
+ |
+ There is nothing in DOM Traversal spec that says this shouldn't work, and it does work in |
+ Firefox. |
+ |
+ * dom/Range.cpp: |
+ (WebCore::Range::setDocument): |
+ (WebCore::Range::selectNode): |
+ (WebCore::Range::selectNodeContents): |
+ * dom/Range.h: |
+ |
+2010-09-16 Andrey Kosyakov <caseq@chromium.org> |
+ |
+ Reviewed by Pavel Feldman. |
+ |
+ Web Inspector: [Resources panel] [HAR] Need a way to save timing data. |
+ Added support to export HAR to file from Resources panel (conditional on Preferences) |
+ Added support for HARLog (a higher-level aggregate than HAREntry) |
+ https://bugs.webkit.org/show_bug.cgi?id=45663 |
+ |
+ * English.lproj/localizedStrings.js: |
+ * inspector/front-end/HAREntry.js: |
+ (WebInspector.HAREntry.prototype.build): |
+ (WebInspector.HAREntry.prototype._buildTimings): |
+ (WebInspector.HAREntry._toMilliseconds): |
+ (WebInspector.HARLog): |
+ (WebInspector.HARLog.prototype.build): |
+ (WebInspector.HARLog.prototype._buildPages): |
+ (WebInspector.HARLog.prototype._buildMainResourceTimings): |
+ (WebInspector.HARLog.prototype._convertResource): |
+ * inspector/front-end/ResourcesPanel.js: |
+ (WebInspector.ResourcesPanel): |
+ (WebInspector.ResourcesPanel.prototype.hide): |
+ (WebInspector.ResourcesPanel.prototype._contextMenu): |
+ (WebInspector.ResourcesPanel.prototype._exportAll): |
+ (WebInspector.ResourcesPanel.prototype._exportResource): |
+ * inspector/front-end/Settings.js: |
+ * inspector/front-end/utilities.js: |
+ (): |
+ |
+2010-09-16 Eric Uhrhane <ericu@chromium.org> |
+ |
+ Reviewed by Jian Li. |
+ |
+ Unify FILE_SYSTEM and FILE_WRITER enables under the name FILE_SYSTEM. |
+ https://bugs.webkit.org/show_bug.cgi?id=45798 |
+ |
+ * CMakeLists.txt: |
+ * Configurations/FeatureDefines.xcconfig: |
+ * GNUmakefile.am: |
+ * WebCore.pro: |
+ * dom/EventTarget.cpp: |
+ * dom/EventTarget.h: |
+ * dom/ExceptionCode.h: |
+ * dom/ScriptExecutionContext.cpp: |
+ (WebCore::ScriptExecutionContext::~ScriptExecutionContext): |
+ * dom/ScriptExecutionContext.h: |
+ * fileapi/AsyncFileWriter.h: |
+ * fileapi/FileEntry.cpp: |
+ * fileapi/FileEntry.h: |
+ * fileapi/FileEntry.idl: |
+ * fileapi/FileError.h: |
+ * fileapi/FileError.idl: |
+ * fileapi/FileException.h: |
+ * fileapi/FileException.idl: |
+ * fileapi/FileStreamProxy.cpp: |
+ * fileapi/FileStreamProxy.h: |
+ * fileapi/FileThread.cpp: |
+ * fileapi/FileThread.h: |
+ * fileapi/FileWriter.cpp: |
+ * fileapi/FileWriter.h: |
+ * fileapi/FileWriter.idl: |
+ * fileapi/FileWriterCallback.h: |
+ * fileapi/FileWriterCallback.idl: |
+ * fileapi/FileWriterClient.h: |
+ * page/DOMWindow.idl: |
+ * platform/AsyncFileStream.h: |
+ * platform/FileStream.cpp: |
+ * platform/FileStream.h: |
+ * platform/FileStreamClient.h: |
+ |
+2010-09-16 Marc-Antoine Ruel <maruel@chromium.org> |
+ |
+ Reviewed by Dimitri Glazkov. |
+ |
+ Convert WebCore.gyp to use regexp to excludes files instead of listing them in sources!. |
+ |
+ This is necessary because sources! is processed before sources/. This makes |
+ applying broader pattern in sources/ more difficult since it overrides the files |
+ listed in sources!. Having all them in sources/ permits controlling the ordering |
+ of the regexp, thus the final list of included files. |
+ |
+ Fix Harfbuzz and VDMX source files includes in WebCore.gypi and WebCore.gyp |
+ |
+ https://bugs.webkit.org/show_bug.cgi?id=45823 |
+ |
+ * WebCore.gyp/WebCore.gyp: |
+ * WebCore.gypi: |
+ |
+2010-09-16 Nat Duca <nduca@chromium.org> |
+ |
+ Reviewed by Darin Fisher. |
+ |
+ [chromium] Make compositor obey finish flag |
+ https://bugs.webkit.org/show_bug.cgi?id=45552 |
+ |
+ The compositor should obey the finish flag on doComposite. This |
+ flag causes the compositor to finish rendering before returning, |
+ which is needed when resizing the window to avoid flashes of green. |
+ |
+ * platform/graphics/chromium/LayerRendererChromium.cpp: |
+ (WebCore::LayerRendererChromium::finish): |
+ * platform/graphics/chromium/LayerRendererChromium.h: |
+ |
+2010-09-16 Alejandro G. Castro <alex@igalia.com> |
+ |
+ Reviewed by Xan Lopez. |
+ |
+ GTK+ 3.x. updates, gtk_widget_size_request is deprecated and |
+ "activate-slider" style property for scrollbars is gone. |
+ |
+ * platform/gtk/PopupMenuGtk.cpp: |
+ (WebCore::PopupMenuGtk::show): |
+ * platform/gtk/gtk2drawing.c: |
+ (moz_gtk_scrollbar_thumb_paint): |
+ (moz_gtk_combo_box_paint): |
+ |
+2010-09-16 Diego Gonzalez <diegohcg@webkit.org> |
+ |
+ Reviewed by Kenneth Rohde Christiansen. |
+ |
+ [Qt] Remove FrameLoaderClientQt::webFrame() to use NetworkingContext to get the WebFrame to avoid layering violations |
+ https://bugs.webkit.org/show_bug.cgi?id=42293 |
+ |
+ * platform/graphics/qt/MediaPlayerPrivateQt.cpp: |
+ (WebCore::MediaPlayerPrivate::commitLoad): |
+ |
+2010-09-16 Ryuan Choi <ryuan.choi@samsung.com> |
+ |
+ Unreviewed build fix for EFL |
+ |
+ [EFL] REGRESSION(67567) FontCacheCairo was removed |
+ https://bugs.webkit.org/show_bug.cgi?id=45858 |
+ |
+ * CMakeListsEfl.txt: |
+ |
+2010-09-16 Yong Li <yoli@rim.com> |
+ |
+ Reviewed by George Staikos. |
+ |
+ https://bugs.webkit.org/show_bug.cgi?id=37117 |
+ |
+ Add platform-independent JPEG/PNG image encoders that |
+ work with big endian RGBA source data. |
+ |
+ There's no layout test because this patch does't make |
+ any port start using the encoders. |
+ |
+ * platform/image-encoders/JPEGImageEncoder.cpp: Added. |
+ * platform/image-encoders/JPEGImageEncoder.h: Added. |
+ * platform/image-encoders/PNGImageEncoder.cpp: Added. |
+ * platform/image-encoders/PNGImageEncoder.h: Added. |
+ |
+2010-09-15 Jeremy Orlow <jorlow@chromium.org> |
+ |
+ Reviewed by Steve Block. |
+ |
+ Allow the embedder to specify the base path for IndexedDB. |
+ https://bugs.webkit.org/show_bug.cgi?id=45815 |
+ |
+ Existing tests provide coverage. Use the indexedDBPath parameter that's |
+ already on the group settings object. Pass this parameter into the backend |
+ which will use it rather than a hard coded tmp directory location. If |
+ nothing is specified, assume it should be an in-memory temporary database. |
+ (This is useful for bringup and Chromium's incognito mode.) |
+ |
+ * storage/IDBFactory.cpp: |
+ (WebCore::IDBFactory::open): |
+ * storage/IDBFactoryBackendImpl.cpp: |
+ (WebCore::openSQLiteDatabase): |
+ (WebCore::createTables): |
+ (WebCore::IDBFactoryBackendImpl::open): |
+ * storage/IDBFactoryBackendImpl.h: |
+ * storage/IDBFactoryBackendInterface.h: |
+ |
+2010-09-16 Yong Li <yoli@rim.com> |
+ |
+ Reviewed by George Staikos. |
+ |
+ Fix the bug that GIF image down sampling can miss some lines. |
+ https://bugs.webkit.org/show_bug.cgi?id=45322 |
+ |
+ Test: fast/images/gif-large-checkerboard.html |
+ |
+ * platform/image-decoders/gif/GIFImageDecoder.cpp: |
+ (WebCore::GIFImageDecoder::haveDecodedRow): |
+ |
+2010-09-16 Philippe Normand <pnormand@igalia.com> |
+ |
+ Reviewed by Andreas Kling. |
+ |
+ [GStreamer] un-needed header includes in MediaPlayerPrivate |
+ https://bugs.webkit.org/show_bug.cgi?id=45877 |
+ |
+ Include only the headers we need. |
+ No new tests, #includes cleanup only. |
+ |
+ * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: |
+ |
+2010-09-16 Pavel Feldman <pfeldman@chromium.org> |
+ |
+ Reviewed by Yury Semikhatsky. |
+ |
+ Web Inspector: console.group(object) does not allow object to be expanded. |
+ https://bugs.webkit.org/show_bug.cgi?id=45806 |
+ |
+ * inspector/front-end/ConsoleView.js: |
+ (WebInspector.ConsoleGroup.prototype.addMessage): |
+ * inspector/front-end/treeoutline.js: |
+ (TreeElement.treeElementToggled): |
+ |
+2010-09-08 Jeremy Orlow <jorlow@chromium.org> |
+ |
+ Reviewed by Steve Block. |
+ |
+ Complete index support for IndexedDB |
+ https://bugs.webkit.org/show_bug.cgi?id=45386 |
+ |
+ Add the rest of the index related API for IndexedDB. This |
+ includes cursor suport. A bunch of code was also refactored |
+ since it is shared between indexes and objectStores. |
+ |
+ Tests: storage/indexeddb/index-basics.html |
+ storage/indexeddb/index-cursor.html |
+ + additions to others. |
+ |
+ * storage/IDBAny.cpp: |
+ (WebCore::IDBAny::set): |
+ * storage/IDBCursor.cpp: |
+ (WebCore::IDBCursor::value): |
+ * storage/IDBCursorBackendImpl.cpp: |
+ (WebCore::IDBCursorBackendImpl::IDBCursorBackendImpl): |
+ (WebCore::IDBCursorBackendImpl::value): |
+ (WebCore::IDBCursorBackendImpl::update): |
+ (WebCore::IDBCursorBackendImpl::continueFunction): |
+ (WebCore::IDBCursorBackendImpl::remove): |
+ (WebCore::IDBCursorBackendImpl::loadCurrentRow): |
+ (WebCore::IDBCursorBackendImpl::database): |
+ * storage/IDBCursorBackendImpl.h: |
+ (WebCore::IDBCursorBackendImpl::create): |
+ * storage/IDBCursorBackendInterface.h: |
+ * storage/IDBFactoryBackendImpl.cpp: |
+ (WebCore::createTables): |
+ * storage/IDBIndex.cpp: |
+ (WebCore::IDBIndex::openObjectCursor): |
+ (WebCore::IDBIndex::openCursor): |
+ (WebCore::IDBIndex::getObject): |
+ (WebCore::IDBIndex::get): |
+ * storage/IDBIndex.h: |
+ (WebCore::IDBIndex::storeName): |
+ * storage/IDBIndex.idl: |
+ * storage/IDBIndexBackendImpl.cpp: |
+ (WebCore::IDBIndexBackendImpl::storeName): |
+ (WebCore::openCursorInternal): |
+ (WebCore::IDBIndexBackendImpl::openObjectCursor): |
+ (WebCore::IDBIndexBackendImpl::openCursor): |
+ (WebCore::getInternal): |
+ (WebCore::IDBIndexBackendImpl::getObject): |
+ (WebCore::IDBIndexBackendImpl::get): |
+ * storage/IDBIndexBackendImpl.h: |
+ (WebCore::IDBIndexBackendImpl::objectStore): |
+ * storage/IDBIndexBackendInterface.h: |
+ * storage/IDBKey.cpp: |
+ (WebCore::IDBKey::fromQuery): |
+ (WebCore::IDBKey::whereSyntax): |
+ (WebCore::IDBKey::leftCursorWhereFragment): |
+ (WebCore::IDBKey::rightCursorWhereFragment): |
+ * storage/IDBKey.h: |
+ * storage/IDBKeyRange.cpp: |
+ (WebCore::IDBKeyRange::leftWhereClauseComparisonOperator): |
+ (WebCore::IDBKeyRange::rightWhereClauseComparisonOperator): |
+ * storage/IDBKeyRange.h: |
+ * storage/IDBObjectStoreBackendImpl.cpp: |
+ (WebCore::IDBObjectStoreBackendImpl::openCursor): |
+ * storage/IDBRequest.cpp: |
+ (WebCore::IDBRequest::timerFired): |
+ |
+2010-09-15 Simon Fraser <simon.fraser@apple.com> |
+ |
+ Fix chromium build. |
+ |
+ * platform/graphics/chromium/GraphicsLayerChromium.cpp: |
+ |
+2010-09-15 Simon Fraser <simon.fraser@apple.com> |
+ |
+ Reviewed by Adam Roben. |
+ |
+ https://bugs.webkit.org/show_bug.cgi?id=44715 |
+ maps.google.com flips upside down when zooming map using trackpad in WebKit2 on Mac |
+ |
+ Remove the concept of geometry flipping from GraphicsLayer; geometry flipping will |
+ be taken care of in platform code without the need to complicate the GraphicsLayer API. |
+ |
+ RenderLayerCompositor no longer sets the geometry orientation for the root |
+ platform layer; platform-specific code does this instead. |
+ |
+ This fixes flipped layers in WebKit2, since WebKit2 was already flipping |
+ geometry, and then RenderLayerCompositor was doing an additional flip. |
+ |
+ * platform/graphics/GraphicsLayer.cpp: |
+ (WebCore::GraphicsLayer::GraphicsLayer): |
+ * platform/graphics/GraphicsLayer.h: |
+ * platform/graphics/chromium/GraphicsLayerChromium.cpp: |
+ * platform/graphics/chromium/GraphicsLayerChromium.h: |
+ * platform/graphics/mac/GraphicsLayerCA.h: |
+ * platform/graphics/mac/GraphicsLayerCA.mm: |
+ (WebCore::GraphicsLayerCA::commitLayerChangesBeforeSublayers): |
+ (WebCore::GraphicsLayerCA::swapFromOrToTiledLayer): |
+ (WebCore::GraphicsLayerCA::defaultContentsOrientation): |
+ * platform/graphics/qt/GraphicsLayerQt.cpp: |
+ (WebCore::GraphicsLayerQtImpl::flushChanges): |
+ * platform/graphics/qt/GraphicsLayerQt.h: |
+ * platform/graphics/win/GraphicsLayerCACF.cpp: |
+ (WebCore::GraphicsLayerCACF::swapFromOrToTiledLayer): |
+ * platform/graphics/win/GraphicsLayerCACF.h: |
+ * platform/graphics/win/WKCACFLayerRenderer.cpp: |
+ (WebCore::WKCACFLayerRenderer::setRootChildLayer): |
+ * rendering/RenderLayerCompositor.cpp: |
+ (WebCore::RenderLayerCompositor::ensureRootPlatformLayer): |
+ |
+2010-09-15 Julien Chaffraix <jchaffraix@codeaurora.org> |
+ |
+ Unreviewed. |
+ |
+ Reverting my changes as it is breaking several tests on Gtk and Qt. |
+ |
+ * css/CSSParser.cpp: |
+ (WebCore::CSSParser::parseColor): |
+ * css/CSSParser.h: |
+ * html/canvas/CanvasRenderingContext2D.cpp: |
+ (WebCore::CanvasRenderingContext2D::setStrokeColor): |
+ (WebCore::CanvasRenderingContext2D::setFillColor): |
+ * html/canvas/CanvasStyle.cpp: |
+ (WebCore::CanvasStyle::createFromString): |
+ * html/canvas/CanvasStyle.h: |
+ |
+2010-09-15 Julien Chaffraix <jchaffraix@codeaurora.org> |
+ |
+ Reviewed by Andreas Kling. |
+ |
+ Parse system colors in the HTML5 canvas context. |
+ https://bugs.webkit.org/show_bug.cgi?id=39168 |
+ |
+ Test: fast/css/test-setting-canvas-color.html |
+ |
+ Based on previous work by Jan Erik Hanssen <jhanssen@codeaurora.org> |
+ |
+ * css/CSSParser.cpp: |
+ (WebCore::CSSParser::parseColor): Changed the function to better match our |
+ early return policy. Also we now return false when we don't parse the color. |
+ This is needed for createFromString to fallback to using parseSystemColor. |
+ |
+ (WebCore::CSSParser::parseSystemColor): Made use of the RenderTheme to get |
+ the system colors. |
+ |
+ * css/CSSParser.h: Added the new parseSystemColor method. |
+ |
+ * html/canvas/CanvasRenderingContext2D.cpp: |
+ (WebCore::CanvasRenderingContext2D::setStrokeColor): Pass the document to createFromString. |
+ (WebCore::CanvasRenderingContext2D::setFillColor): Ditto. |
+ * html/canvas/CanvasStyle.cpp: |
+ (WebCore::CanvasStyle::createFromString): Try to parse the color using CSSParser::parseColor |
+ and fall back to parseSystemColor if it did not work. |
+ |
+ * html/canvas/CanvasStyle.h: Added the new Document* parameter to createFromString. |
+ |
+2010-09-14 Erik Arvidsson <arv@chromium.org> |
+ |
+ Reviewed by Darin Adler. |
+ |
+ getComputedStyle() returns different values for different zoom levels |
+ https://bugs.webkit.org/show_bug.cgi?id=32230 |
+ |
+ Test: fast/css/getComputedStyle/computed-style-with-zoom.html |
+ |
+ * css/CSSComputedStyleDeclaration.cpp: |
+ (WebCore::zoomAdjustedPixelValue): |
+ (WebCore::zoomAdjustedNumberValue): |
+ (WebCore::valueForReflection): |
+ (WebCore::getPositionOffsetValue): |
+ (WebCore::getBorderRadiusCornerValue): |
+ (WebCore::computedTransform): |
+ (WebCore::CSSComputedStyleDeclaration::getFontSizeCSSValuePreferringKeyword): |
+ (WebCore::CSSComputedStyleDeclaration::valueForShadow): |
+ (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): |
+ * css/CSSComputedStyleDeclaration.h: |
+ * css/SVGCSSComputedStyleDeclaration.cpp: |
+ (WebCore::CSSComputedStyleDeclaration::getSVGPropertyCSSValue): |
+ * rendering/RenderObject.h: |
+ (WebCore::adjustForAbsoluteZoom): |
+ * rendering/style/RenderStyle.h: |
+ (WebCore::adjustForAbsoluteZoom): |
+ |
+2010-09-14 Martin Robinson <mrobinson@igalia.com> |
+ |
+ Reviewed by Xan Lopez. |
+ |
+ [GTK] Fully separate Pango and FreeType font backends |
+ https://bugs.webkit.org/show_bug.cgi?id=27442 |
+ |
+ Split FontPlatformData.h into separate versions for Pango, FreeType and WinCairo. |
+ Include the correct file via #ifdef'd includes, like the Chromium port. Also split |
+ FontCacheCairo.cpp into Pango and FreeType versions, as they had almost no code in |
+ common. Finally, rename FontPlatformDataCairo to FontPlatformDataFreeType, as this |
+ compilation unit is used only by the FreeType backend. This change is important to |
+ prevent upcoming fixes to the FreeType backend from affecting other backends. |
+ |
+ No new tests as functionality has not changed. |
+ |
+ * CMakeListsEfl.txt: Update source lists. |
+ * GNUmakefile.am: Update source lists. |
+ * platform/graphics/cairo/FontCacheCairo.cpp: Removed. |
+ * platform/graphics/cairo/FontCacheFreeType.cpp: Added. |
+ (WebCore::FontCache::platformInit): |
+ (WebCore::FontCache::getFontDataForCharacters): |
+ (WebCore::FontCache::getSimilarFontPlatformData): |
+ (WebCore::FontCache::getLastResortFallbackFont): |
+ (WebCore::FontCache::getTraitsInFamily): |
+ (WebCore::isWellKnownFontName): |
+ (WebCore::FontCache::createFontPlatformData): |
+ * platform/graphics/cairo/FontPlatformData.h: |
+ * platform/graphics/cairo/FontPlatformDataFreeType.cpp: Renamed from WebCore/platform/graphics/cairo/FontPlatformDataCairo.cpp. |
+ (WebCore::FontPlatformData::FontPlatformData): |
+ (WebCore::FontPlatformData::operator=): |
+ (WebCore::FontPlatformData::init): |
+ (WebCore::FontPlatformData::~FontPlatformData): |
+ (WebCore::FontPlatformData::isFixedPitch): |
+ (WebCore::FontPlatformData::operator==): |
+ (WebCore::FontPlatformData::description): |
+ * platform/graphics/cairo/FontPlatformDataFreeType.h: Added. |
+ (WebCore::FontPlatformData::FontPlatformData): |
+ (WebCore::FontPlatformData::size): |
+ (WebCore::FontPlatformData::setSize): |
+ (WebCore::FontPlatformData::syntheticBold): |
+ (WebCore::FontPlatformData::syntheticOblique): |
+ (WebCore::FontPlatformData::scaledFont): |
+ (WebCore::FontPlatformData::hash): |
+ (WebCore::FontPlatformData::isHashTableDeletedValue): |
+ (WebCore::FontPlatformData::hashTableDeletedFontValue): |
+ * platform/graphics/gtk/FontCachePango.cpp: Added. |
+ (WebCore::FontCache::platformInit): |
+ (WebCore::FontCache::getFontDataForCharacters): |
+ (WebCore::FontCache::getSimilarFontPlatformData): |
+ (WebCore::FontCache::getLastResortFallbackFont): |
+ (WebCore::FontCache::getTraitsInFamily): |
+ (WebCore::FontCache::createFontPlatformData): |
+ * platform/graphics/gtk/FontPlatformDataPango.h: Added. |
+ (WebCore::FontPlatformData::FontPlatformData): |
+ (WebCore::FontPlatformData::size): |
+ (WebCore::FontPlatformData::setSize): |
+ (WebCore::FontPlatformData::syntheticBold): |
+ (WebCore::FontPlatformData::syntheticOblique): |
+ (WebCore::FontPlatformData::scaledFont): |
+ (WebCore::FontPlatformData::hash): |
+ (WebCore::FontPlatformData::isHashTableDeletedValue): |
+ (WebCore::FontPlatformData::hashTableDeletedFontValue): |
+ * platform/graphics/win/FontPlatformDataCairoWin.h: Added. |
+ (WebCore::FontPlatformData::FontPlatformData): |
+ (WebCore::FontPlatformData::hfont): |
+ (WebCore::FontPlatformData::useGDI): |
+ (WebCore::FontPlatformData::fontFace): |
+ (WebCore::FontPlatformData::size): |
+ (WebCore::FontPlatformData::setSize): |
+ (WebCore::FontPlatformData::syntheticBold): |
+ (WebCore::FontPlatformData::syntheticOblique): |
+ (WebCore::FontPlatformData::scaledFont): |
+ (WebCore::FontPlatformData::hash): |
+ (WebCore::FontPlatformData::isHashTableDeletedValue): |
+ |
+2010-09-15 Chris Fleizach <cfleizach@apple.com> |
+ |
+ Reviewed by Simon Fraser. |
+ |
+ AX: when text is auto-truncated, accessibility bounds are wrong |
+ https://bugs.webkit.org/show_bug.cgi?id=45793 |
+ |
+ Allow accessibility to retrieve the absoluteQuads of a text node that |
+ clips to the ellipsis. |
+ |
+ Test: accessibility/ellipsis-text.html |
+ |
+ * accessibility/AccessibilityRenderObject.cpp: |
+ (WebCore::AccessibilityRenderObject::boundingBoxRect): |
+ * rendering/RenderText.cpp: |
+ (WebCore::ellipsisRectForBox): |
+ Make a common method to retrieve the ellipsis rect. |
+ (WebCore::RenderText::absoluteQuads): |
+ Default into the absoluteQuads method that allows for ellipsis clipping. |
+ (WebCore::RenderText::selectionRectForRepaint): |
+ Use the common method for retrieving the ellipsis. |
+ * rendering/RenderText.h: |
+ |
+2010-09-15 Ariya Hidayat <ariya@sencha.com> |
+ |
+ [Qt] Improve the speed of blur shadow |
+ https://bugs.webkit.org/show_bug.cgi?id=44222 |
+ |
+ Rewrite the shadow blur function with loop unrolls and sliding step |
+ unification for both horizontal and vertical directions. |
+ This gives significant performance improvement on most cases. |
+ |
+ * platform/graphics/qt/ContextShadow.cpp: |
+ (WebCore::shadowBlur): |
+ |
+2010-09-14 Pavel Feldman <pfeldman@chromium.org> |
+ |
+ Reviewed by Yury Semikhatsky. |
+ |
+ (Take 2). Web Inspector: Provide network-based load timing. |
+ Before this change, inspector used timers taken from |
+ within WebCore notifications (that are by definition |
+ synchronous and serialized). As a result, timing was |
+ affected by the routines running on the main thread |
+ (JavaScript and such). |
+ https://bugs.webkit.org/show_bug.cgi?id=45664 |
+ |
+ * inspector/InspectorController.cpp: |
+ (WebCore::InspectorController::willSendRequest): |
+ (WebCore::InspectorController::didFinishLoading): |
+ (WebCore::InspectorController::didFailLoading): |
+ * inspector/InspectorController.h: |
+ * inspector/InspectorResource.cpp: |
+ (WebCore::InspectorResource::endTiming): |
+ * inspector/InspectorResource.h: |
+ * loader/PingLoader.h: |
+ (WebCore::PingLoader::didFinishLoading): |
+ * loader/ResourceLoadNotifier.cpp: |
+ (WebCore::ResourceLoadNotifier::dispatchDidFinishLoading): |
+ * loader/ResourceLoader.cpp: |
+ (WebCore::ResourceLoader::didFinishLoading): |
+ * loader/ResourceLoader.h: |
+ * loader/appcache/ApplicationCacheGroup.cpp: |
+ (WebCore::ApplicationCacheGroup::didFinishLoading): |
+ * loader/appcache/ApplicationCacheGroup.h: |
+ * loader/icon/IconFetcher.cpp: |
+ (WebCore::IconFetcher::didFinishLoading): |
+ * loader/icon/IconFetcher.h: |
+ * platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp: |
+ (StreamingClient::didFinishLoading): |
+ * platform/network/BlobResourceHandle.cpp: |
+ (WebCore::BlobResourceHandle::notifyFinish): |
+ * platform/network/ResourceHandleClient.h: |
+ (WebCore::ResourceHandleClient::didFinishLoading): |
+ * platform/network/ResourceLoadTiming.h: |
+ (WebCore::ResourceLoadTiming::deepCopy): |
+ (WebCore::ResourceLoadTiming::operator==): |
+ (WebCore::ResourceLoadTiming::ResourceLoadTiming): |
+ * platform/network/cf/ResourceHandleCFNet.cpp: |
+ (WebCore::didFinishLoading): |
+ * platform/network/curl/ResourceHandleCurl.cpp: |
+ (WebCore::WebCoreSynchronousLoader::didFinishLoading): |
+ * platform/network/curl/ResourceHandleManager.cpp: |
+ (WebCore::ResourceHandleManager::downloadTimerCallback): |
+ (WebCore::parseDataUrl): |
+ * platform/network/mac/ResourceHandleMac.mm: |
+ (-[WebCoreResourceHandleAsDelegate connectionDidFinishLoading:]): |
+ (WebCoreSynchronousLoaderClient::didFinishLoading): |
+ * platform/network/qt/QNetworkReplyHandler.cpp: |
+ (WebCore::QNetworkReplyHandler::finish): |
+ * platform/network/qt/ResourceHandleQt.cpp: |
+ (WebCore::WebCoreSynchronousLoader::didFinishLoading): |
+ * platform/network/soup/ResourceHandleSoup.cpp: |
+ (WebCore::WebCoreSynchronousLoader::didFinishLoading): |
+ (WebCore::WebCoreSynchronousLoader::didFail): |
+ * platform/network/win/ResourceHandleWin.cpp: |
+ (WebCore::WebCoreSynchronousLoader::didFinishLoading): |
+ (WebCore::ResourceHandle::onRequestComplete): |
+ (WebCore::ResourceHandle::fileLoadTimer): |
+ (WebCore::ResourceHandle::cancel): |
+ |
+2010-09-15 Sheriff Bot <webkit.review.bot@gmail.com> |
+ |
+ Unreviewed, rolling out r67551. |
+ http://trac.webkit.org/changeset/67551 |
+ https://bugs.webkit.org/show_bug.cgi?id=45816 |
+ |
+ "Plugin tests fail" (Requested by yurys on #webkit). |
+ |
+ * inspector/InspectorController.cpp: |
+ (WebCore::InspectorController::willSendRequest): |
+ (WebCore::InspectorController::didFinishLoading): |
+ (WebCore::InspectorController::didFailLoading): |
+ (WebCore::InspectorController::didCloseWebSocket): |
+ * inspector/InspectorController.h: |
+ * inspector/InspectorResource.cpp: |
+ (WebCore::InspectorResource::endTiming): |
+ * inspector/InspectorResource.h: |
+ * loader/DocumentLoader.cpp: |
+ (WebCore::DocumentLoader::substituteResourceDeliveryTimerFired): |
+ * loader/MainResourceLoader.cpp: |
+ (WebCore::MainResourceLoader::continueAfterContentPolicy): |
+ (WebCore::MainResourceLoader::didFinishLoading): |
+ * loader/MainResourceLoader.h: |
+ * loader/NetscapePlugInStreamLoader.cpp: |
+ (WebCore::NetscapePlugInStreamLoader::didFinishLoading): |
+ * loader/PingLoader.h: |
+ (WebCore::PingLoader::didFinishLoading): |
+ * loader/ResourceLoadNotifier.cpp: |
+ (WebCore::ResourceLoadNotifier::didFinishLoad): |
+ (WebCore::ResourceLoadNotifier::dispatchDidFinishLoading): |
+ (WebCore::ResourceLoadNotifier::sendRemainingDelegateMessages): |
+ * loader/ResourceLoadNotifier.h: |
+ * loader/ResourceLoader.cpp: |
+ (WebCore::ResourceLoader::didFinishLoading): |
+ (WebCore::ResourceLoader::didFinishLoadingOnePart): |
+ * loader/ResourceLoader.h: |
+ * loader/SubresourceLoader.cpp: |
+ (WebCore::SubresourceLoader::didReceiveResponse): |
+ (WebCore::SubresourceLoader::didFinishLoading): |
+ * loader/SubresourceLoader.h: |
+ * loader/appcache/ApplicationCacheGroup.cpp: |
+ (WebCore::ApplicationCacheGroup::didFinishLoading): |
+ * loader/appcache/ApplicationCacheGroup.h: |
+ * loader/icon/IconFetcher.cpp: |
+ (WebCore::IconFetcher::didFinishLoading): |
+ * loader/icon/IconFetcher.h: |
+ * platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp: |
+ (StreamingClient::didFinishLoading): |
+ * platform/network/BlobResourceHandle.cpp: |
+ (WebCore::BlobResourceHandle::notifyFinish): |
+ * platform/network/ResourceHandleClient.h: |
+ (WebCore::ResourceHandleClient::didFinishLoading): |
+ * platform/network/cf/ResourceHandleCFNet.cpp: |
+ (WebCore::didFinishLoading): |
+ (WebCore::WebCoreSynchronousLoaderClient::didFinishLoading): |
+ * platform/network/curl/ResourceHandleCurl.cpp: |
+ (WebCore::WebCoreSynchronousLoader::didFinishLoading): |
+ * platform/network/curl/ResourceHandleManager.cpp: |
+ (WebCore::ResourceHandleManager::downloadTimerCallback): |
+ (WebCore::parseDataUrl): |
+ * platform/network/mac/ResourceHandleMac.mm: |
+ (-[WebCoreResourceHandleAsDelegate connectionDidFinishLoading:]): |
+ (WebCoreSynchronousLoaderClient::didFinishLoading): |
+ * platform/network/qt/QNetworkReplyHandler.cpp: |
+ (WebCore::QNetworkReplyHandler::finish): |
+ * platform/network/qt/ResourceHandleQt.cpp: |
+ (WebCore::WebCoreSynchronousLoader::didFinishLoading): |
+ * platform/network/soup/ResourceHandleSoup.cpp: |
+ (WebCore::WebCoreSynchronousLoader::didFinishLoading): |
+ (WebCore::WebCoreSynchronousLoader::didFail): |
+ (WebCore::finishedCallback): |
+ (WebCore::parseDataUrl): |
+ * platform/network/win/ResourceHandleWin.cpp: |
+ (WebCore::WebCoreSynchronousLoader::didFinishLoading): |
+ (WebCore::ResourceHandle::onRequestComplete): |
+ (WebCore::ResourceHandle::fileLoadTimer): |
+ (WebCore::ResourceHandle::cancel): |
+ |
+2010-09-14 Pavel Feldman <pfeldman@chromium.org> |
+ |
+ Reviewed by Yury Semikhatsky. |
+ |
+ Web Inspector: Provide network-based load timing. |
+ Before this change, inspector used timers taken from |
+ within WebCore notifications (that are by definition |
+ synchronous and serialized). As a result, timing was |
+ affected by the routines running on the main thread |
+ (JavaScript and such). |
+ https://bugs.webkit.org/show_bug.cgi?id=45664 |
+ |
+ * inspector/InspectorController.cpp: |
+ (WebCore::InspectorController::willSendRequest): |
+ (WebCore::InspectorController::didFinishLoading): |
+ (WebCore::InspectorController::didFailLoading): |
+ * inspector/InspectorController.h: |
+ * inspector/InspectorResource.cpp: |
+ (WebCore::InspectorResource::endTiming): |
+ * inspector/InspectorResource.h: |
+ * loader/PingLoader.h: |
+ (WebCore::PingLoader::didFinishLoading): |
+ * loader/ResourceLoadNotifier.cpp: |
+ (WebCore::ResourceLoadNotifier::dispatchDidFinishLoading): |
+ * loader/ResourceLoader.cpp: |
+ (WebCore::ResourceLoader::didFinishLoading): |
+ * loader/ResourceLoader.h: |
+ * loader/appcache/ApplicationCacheGroup.cpp: |
+ (WebCore::ApplicationCacheGroup::didFinishLoading): |
+ * loader/appcache/ApplicationCacheGroup.h: |
+ * loader/icon/IconFetcher.cpp: |
+ (WebCore::IconFetcher::didFinishLoading): |
+ * loader/icon/IconFetcher.h: |
+ * platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp: |
+ (StreamingClient::didFinishLoading): |
+ * platform/network/BlobResourceHandle.cpp: |
+ (WebCore::BlobResourceHandle::notifyFinish): |
+ * platform/network/ResourceHandleClient.h: |
+ (WebCore::ResourceHandleClient::didFinishLoading): |
+ * platform/network/ResourceLoadTiming.h: |
+ (WebCore::ResourceLoadTiming::deepCopy): |
+ (WebCore::ResourceLoadTiming::operator==): |
+ (WebCore::ResourceLoadTiming::ResourceLoadTiming): |
+ * platform/network/cf/ResourceHandleCFNet.cpp: |
+ (WebCore::didFinishLoading): |
+ * platform/network/curl/ResourceHandleCurl.cpp: |
+ (WebCore::WebCoreSynchronousLoader::didFinishLoading): |
+ * platform/network/curl/ResourceHandleManager.cpp: |
+ (WebCore::ResourceHandleManager::downloadTimerCallback): |
+ (WebCore::parseDataUrl): |
+ * platform/network/mac/ResourceHandleMac.mm: |
+ (-[WebCoreResourceHandleAsDelegate connectionDidFinishLoading:]): |
+ (WebCoreSynchronousLoaderClient::didFinishLoading): |
+ * platform/network/qt/QNetworkReplyHandler.cpp: |
+ (WebCore::QNetworkReplyHandler::finish): |
+ * platform/network/qt/ResourceHandleQt.cpp: |
+ (WebCore::WebCoreSynchronousLoader::didFinishLoading): |
+ * platform/network/soup/ResourceHandleSoup.cpp: |
+ (WebCore::WebCoreSynchronousLoader::didFinishLoading): |
+ (WebCore::WebCoreSynchronousLoader::didFail): |
+ * platform/network/win/ResourceHandleWin.cpp: |
+ (WebCore::WebCoreSynchronousLoader::didFinishLoading): |
+ (WebCore::ResourceHandle::onRequestComplete): |
+ (WebCore::ResourceHandle::fileLoadTimer): |
+ (WebCore::ResourceHandle::cancel): |
+ |
+2010-09-14 Ilya Tikhonovsky <loislo@chromium.org> |
+ |
+ Reviewed by Yury Semikhatsky. |
+ |
+ WebInspector: small refactoring for monitorXHR backend property. |
+ |
+ Our Inspector API is quite big and can be simplified a bit. |
+ As example for single backend property like monitoringXHR we |
+ have 4 functions in the API. Two functions for frontend |
+ enableMonitoringXHR/disableMonitoringXHR and |
+ two functions for backend monitoringXHRWasEnabled and |
+ monitoringXHRWasDisabled. These functions can be replaced by |
+ one setMonitoringXHR with one 'in' and one 'out' argument. |
+ The initial state of the flag can be gathered from backend |
+ with help of getSettings call where additional section was |
+ added for backend state information. |
+ |
+ https://bugs.webkit.org/show_bug.cgi?id=45759 |
+ |
+ * inspector/Inspector.idl: |
+ * inspector/InspectorController.cpp: |
+ * inspector/InspectorController.h: |
+ * inspector/front-end/ConsoleView.js: |
+ * inspector/front-end/Settings.js: |
+ * inspector/front-end/inspector.js: |
+ |
+2010-09-15 Pavel Feldman <pfeldman@chromium.org> |
+ |
+ Reviewed by Yury Semikhatsky. |
+ |
+ Web Inspector: Multiline console does not work on Windows / Linux. |
+ https://bugs.webkit.org/show_bug.cgi?id=45807 |
+ |
+ * inspector/front-end/ConsoleView.js: |
+ |
+2010-09-15 Renata Hodovan <reni@inf.u-szeged.hu> |
+ |
+ Reviewed by Dirk Schulze. |
+ |
+ SVGFETurbulenceElement doesn't support dynamic invalidation, when attributes change. |
+ A typo (noStich instead of nostitch) is also fixed in this patch. |
+ https://bugs.webkit.org/show_bug.cgi?id=45809 |
+ |
+ Tests: svg/dynamic-updates/SVGFETurbulenceElement-dom-baseFrequency-attr.html |
+ svg/dynamic-updates/SVGFETurbulenceElement-dom-numOctaves-attr.html |
+ svg/dynamic-updates/SVGFETurbulenceElement-dom-seed-attr.html |
+ svg/dynamic-updates/SVGFETurbulenceElement-dom-stitchTiles-attr.html |
+ svg/dynamic-updates/SVGFETurbulenceElement-dom-type-attr.html |
+ svg/dynamic-updates/SVGFETurbulenceElement-svgdom-baseFrequency-prop.html |
+ svg/dynamic-updates/SVGFETurbulenceElement-svgdom-numOctaves-prop.html |
+ svg/dynamic-updates/SVGFETurbulenceElement-svgdom-seed-prop.html |
+ svg/dynamic-updates/SVGFETurbulenceElement-svgdom-stitchTiles-prop.html |
+ svg/dynamic-updates/SVGFETurbulenceElement-svgdom-type-prop.html |
+ |
+ * svg/SVGFETurbulenceElement.cpp: |
+ (WebCore::SVGFETurbulenceElement::parseMappedAttribute): |
+ (WebCore::SVGFETurbulenceElement::svgAttributeChanged): |
+ * svg/SVGFETurbulenceElement.h: |
+ |
+2010-09-15 Patrick Gansterer <paroga@paroga.com> |
+ |
+ Reviewed by Kenneth Rohde Christiansen. |
+ |
+ [WINCE] Avoid memcpy in TextCodecWinCE::encode |
+ https://bugs.webkit.org/show_bug.cgi?id=45468 |
+ |
+ * platform/text/wince/TextCodecWinCE.cpp: |
+ (WebCore::TextCodecWinCE::encode): |
+ |
+2010-09-14 Kinuko Yasuda <kinuko@chromium.org> |
+ |
+ Reviewed by Dumitru Daniliuc. |
+ |
+ Add custom binding code for DirectoryEntry to allow JSON parameters for Flags |
+ https://bugs.webkit.org/show_bug.cgi?id=45724 |
+ |
+ No new tests; tests will be added later. |
+ |
+ * CMakeLists.txt: |
+ * GNUmakefile.am: |
+ * WebCore.gypi: |
+ * WebCore.pro: |
+ * WebCore.vcproj/WebCore.vcproj: |
+ * WebCore.xcodeproj/project.pbxproj: |
+ * bindings/js/JSDirectoryEntryCustom.cpp: Added. |
+ (WebCore::JSDirectoryEntry::getFile): |
+ (WebCore::JSDirectoryEntry::getDirectory): |
+ * bindings/v8/custom/V8DirectoryEntryCustom.cpp: Added. |
+ (WebCore::V8DirectoryEntry::getDirectoryCallback): |
+ (WebCore::V8DirectoryEntry::getFileCallback): |
+ * fileapi/DirectoryEntry.h: |
+ * fileapi/DirectoryEntry.idl: |
+ |
+2010-09-14 Jia Pu <jpu@apple.com> |
+ |
+ Reviewed by Dan Bernstein. |
+ |
+ Only intercept ESC key press when autocorrection UI is visible. |
+ https://bugs.webkit.org/show_bug.cgi?id=45071 |
+ |
+ Only intercept ESC key when autocorrection panel is shown. Otherwise pressing |
+ ESC will cancel current loading like usual. |
+ |
+ * editing/Editor.cpp: |
+ (WebCore::Editor::isShowingCorrectionPanel): Query editor client whether autocorrection |
+ panel is shown. |
+ |
+ * editing/Editor.h: Added declaration of isShowingCorrectionPanel(). |
+ |
+ * editing/EditorCommand.cpp: |
+ (WebCore::supportedDismissCorrectionPanel): Only support executeCancelOperation() |
+ when autocorrection panel is shown. |
+ (WebCore::createCommandMap): Replaced isSupported function pointer for |
+ executeCancelOperation() command with supportedDismissCorrectionPanel(). |
+ |
+ * loader/EmptyClients.h: |
+ (WebCore::EmptyEditorClient::isShowingCorrectionPanel): Dummy implementation of |
+ new member method declared in base class. |
+ |
+ * page/EditorClient.h: Declared new member method isShowingCorrectionPanel(). |
+ |
+2010-09-14 Sheriff Bot <webkit.review.bot@gmail.com> |
+ |
+ Unreviewed, rolling out r67503. |
+ http://trac.webkit.org/changeset/67503 |
+ https://bugs.webkit.org/show_bug.cgi?id=45802 |
+ |
+ This patch broke GTK builds (Requested by jianli_ on #webkit). |
+ |
+ * fileapi/ThreadableBlobRegistry.cpp: |
+ (WebCore::BlobRegistryContext::BlobRegistryContext): |
+ * loader/ResourceLoader.cpp: |
+ (WebCore::ResourceLoader::resourceData): |
+ (WebCore::ResourceLoader::addData): |
+ * platform/network/BlobResourceHandle.cpp: |
+ * platform/network/BlobResourceHandle.h: |
+ * platform/network/ResourceHandle.h: |
+ * platform/network/mac/ResourceHandleMac.mm: |
+ (WebCore::ResourceHandle::bufferedData): |
+ |
+2010-09-14 Luiz Agostini <luiz.agostini@openbossa.org> |
+ |
+ Reviewed by Kenneth Rohde Christiansen. |
+ |
+ [Qt] Zoom factor for checkboxes and radios. |
+ https://bugs.webkit.org/show_bug.cgi?id=45776 |
+ |
+ RenderThemeQt does not consider RenderStyle::effectiveZoom when calculating sizes of |
+ checkboxes and radios. |
+ |
+ Even with this change the used QStyle must support different sizes for radios and checkboxes. |
+ QWindowStyle and QMacStyle, for example, do not. |
+ |
+ * platform/qt/RenderThemeQt.cpp: |
+ (WebCore::RenderThemeQt::computeSizeBasedOnStyle): |
+ |
+2010-09-14 Chris Rogers <crogers@google.com> |
+ |
+ Reviewed by Kenneth Russell. |
+ |
+ audio engine: add AudioFileReader files (Mac implementation) |
+ https://bugs.webkit.org/show_bug.cgi?id=36475 |
+ |
+ No new tests since audio API is not yet implemented. |
+ |
+ * platform/audio/AudioFileReader.h: Added. |
+ * platform/audio/mac/AudioFileReaderMac.cpp: Added. |
+ (WebCore::createAudioBufferList): |
+ (WebCore::destroyAudioBufferList): |
+ (WebCore::AudioFileReader::AudioFileReader): |
+ (WebCore::AudioFileReader::~AudioFileReader): |
+ (WebCore::AudioFileReader::readProc): |
+ (WebCore::AudioFileReader::getSizeProc): |
+ (WebCore::AudioFileReader::createBus): |
+ (WebCore::createBusFromAudioFile): |
+ (WebCore::createBusFromInMemoryAudioFile): |
+ * platform/audio/mac/AudioFileReaderMac.h: Added. |
+ (WebCore::AudioFileReader::data): |
+ (WebCore::AudioFileReader::dataSize): |
+ |
+2010-09-14 Simon Fraser <simon.fraser@apple.com> |
+ |
+ Reviewed by Oliver Hunt. |
+ |
+ Drawing an image outside the bounds of a canvas still causes repaints |
+ https://bugs.webkit.org/show_bug.cgi?id=45792 |
+ |
+ Some canvas examples, such as http://www.phoboslab.org/biolab/, draw |
+ images outide the bounds of the canvas. If the canvas already had a |
+ non-empty m_dirtyRect, such draws would cause us to do a repaint of |
+ m_dirtyRect again (which goes through the platform-specific invalidation |
+ machinery, which can be slow). |
+ |
+ Optimize this by avoiding extra invalidation when the dirty rect |
+ does not intersect the canvas bounds. |
+ |
+ Not testable because this avoids additional repaints of m_dirtyRect, but |
+ m_dirtyRect has to be non-empty for this to benefit. |
+ |
+ * html/HTMLCanvasElement.cpp: |
+ (WebCore::HTMLCanvasElement::didDraw): |
+ |
+2010-09-14 Yury Semikhatsky <yurys@chromium.org> |
+ |
+ Reviewed by Pavel Feldman. |
+ |
+ Web Inspector: Links from "Profiles" don't lead to "Scripts" |
+ https://bugs.webkit.org/show_bug.cgi?id=45756 |
+ |
+ * inspector/front-end/ProfileDataGridTree.js: |
+ (WebInspector.ProfileDataGridNode.prototype.createCell): use standard routine to create resource link |
+ * inspector/front-end/inspector.js: code cleanup: removed no-op method |
+ (WebInspector.addMainEventListeners): |
+ |
+2010-09-14 Patrick Gansterer <paroga@paroga.com> |
+ |
+ Reviewed by Adam Roben. |
+ |
+ [WINCE] Use codePage instead of TextEncoding |
+ https://bugs.webkit.org/show_bug.cgi?id=45466 |
+ |
+ Use codePage as member variable to avoid repeated lookup. |
+ |
+ * platform/text/wince/TextCodecWinCE.cpp: |
+ (WebCore::newTextCodecWinCE): |
+ (WebCore::TextCodecWinCE::TextCodecWinCE): |
+ (WebCore::decode): |
+ (WebCore::TextCodecWinCE::decode): |
+ (WebCore::TextCodecWinCE::encode): |
+ * platform/text/wince/TextCodecWinCE.h: |
+ |
+2010-09-14 Adam Barth <abarth@webkit.org> |
+ |
+ Attempted Chromium build fix. The compiler can't tell that |
+ ASSERT_NOT_REACHED is not reached and so it demands an initialization |
+ of this variable. |
+ |
+ * html/HTMLFontElement.cpp: |
+ (WebCore::HTMLFontElement::parseMappedAttribute): |
+ |
+2010-09-14 Andreas Kling <andreas.kling@nokia.com> |
+ |
+ Reviewed by Ariya Hidayat. |
+ |
+ [Qt] Wheeling over windowed plugins sometimes cause them to disappear |
+ |
+ * plugins/qt/PluginContainerQt.cpp: |
+ (PluginClientWrapper::x11Event): Pass on captured mouse wheel events |
+ to the effective native window rather than the grandparent widget. |
+ We were calling QWidget::winId() which caused a new X11 window to be |
+ created for the grandparent widget and generally mess things up. |
+ |
+2010-09-14 Kevin Ollivier <kevino@theolliviers.com> |
+ |
+ [wx] Build fix after move of selectedText() method. |
+ |
+ * platform/wx/PasteboardWx.cpp: |
+ (WebCore::Pasteboard::writeSelection): |
+ |
+2010-09-14 Adam Barth <abarth@webkit.org> |
+ |
+ Reviewed by Darin Adler. |
+ |
+ Handle <font size=0> as <font size=1> like any other browser |
+ https://bugs.webkit.org/show_bug.cgi?id=39148 |
+ |
+ Update font size parser to match HTML5 spec. The main difference here |
+ is the handling of 0, which now maps to 1 instead of 3. |
+ |
+ * html/HTMLFontElement.cpp: |
+ (WebCore::parseFontSize): |
+ (WebCore::HTMLFontElement::cssValueFromFontSizeNumber): |
+ |
+2010-09-14 Adam Barth <abarth@webkit.org> |
+ |
+ Reviewed by Darin Adler. |
+ |
+ document.lastModified gives no output if the response doesn't have a Last-Modified header |
+ https://bugs.webkit.org/show_bug.cgi?id=8475 |
+ |
+ Implement document.lastModified as per HTML5. |
+ |
+ Tests: http/tests/misc/last-modified-parsing.html |
+ http/tests/misc/no-last-modified.html |
+ |
+ * dom/Document.cpp: |
+ (WebCore::Document::lastModified): |
+ |
+2010-09-14 Adam Barth <abarth@webkit.org> |
+ |
+ Reviewed by Eric Seidel. |
+ |
+ `document.compatMode` is `undefined` when using `application/xhtml+xml` |
+ https://bugs.webkit.org/show_bug.cgi?id=44422 |
+ |
+ Moving the compatMode IDL attribute from HTMLDocument.idl to |
+ Document.idl fixes this bug and improve compliance with HTML5. |
+ |
+ Test: fast/parser/compatMode-in-xhtml.xhtml |
+ |
+ * dom/Document.cpp: |
+ (WebCore::Document::compatMode): |
+ * dom/Document.h: |
+ * dom/Document.idl: |
+ * html/HTMLDocument.cpp: |
+ * html/HTMLDocument.h: |
+ |
+2010-09-14 Adam Barth <abarth@webkit.org> |
+ |
+ Reviewed by Nate Chapin. |
+ |
+ V8 security checks don't account for shadowing named frames |
+ https://bugs.webkit.org/show_bug.cgi?id=45700 |
+ |
+ Test: http/tests/security/xss-DENIED-frame-name.html |
+ |
+ * bindings/v8/custom/V8DOMWindowCustom.cpp: |
+ (WebCore::V8DOMWindow::namedSecurityCheck): |
+ - If the property name exists on the object, it will shadow the |
+ named property lookup on the window object. That means we need |
+ to block access if there's shadowing going on. |
+ (WebCore::V8DOMWindow::indexedSecurityCheck): |
+ - I made the corresponding change to this function too, but I don't |
+ think this one can actually be triggered because JavaScript |
+ variable names need to start with a non-digit. |
+ |
+2010-09-14 Adam Barth <abarth@webkit.org> |
+ |
+ Reviewed by Eric Seidel. |
+ |
+ incorrect tabindex parsing |
+ https://bugs.webkit.org/show_bug.cgi?id=21076 |
+ |
+ Updated our integer parsing for tabindex to use the algorithm from the |
+ HTML5 spec. |
+ |
+ Test: fast/parser/tabindex-parsing-2.html |
+ |
+ * html/HTMLElement.cpp: |
+ (WebCore::HTMLElement::parseMappedAttribute): |
+ * html/parser/HTMLParserIdioms.cpp: |
+ (WebCore::parseHTMLInteger): |
+ * html/parser/HTMLParserIdioms.h: |
+ |
+2010-09-14 Brent Fulgham <bfulgham@webkit.org> |
+ |
+ Build correction, no review. |
+ |
+ * WebCore.vcproj/WebCore.vcproj: Exclude OwnPtrCairo.cpp from |
+ non-Cairo based builds. |
+ |
+2010-09-14 Jian Li <jianli@chromium.org> |
+ |
+ Reviewed by David Levin. |
+ |
+ fast/files/apply-blob-url-to-img.html timeout on Leopard |
+ https://bugs.webkit.org/show_bug.cgi?id=45576 |
+ |
+ The failure on Leopard is caused by the static method |
+ ResourceHandle::supportsBufferedData that returns true to indicate that |
+ the buffered data support is enabled for blob resource. However, |
+ BlobResourceHandle does not support this and we need to override this. |
+ |
+ The fix is to change supportsBufferedData method from static to virtual |
+ so that we can override the default behavior in BlobResourceHandle. |
+ |
+ * fileapi/ThreadableBlobRegistry.cpp: Copy BlobData to make it cross-thread. |
+ (WebCore::BlobRegistryContext::BlobRegistryContext): |
+ * loader/ResourceLoader.cpp: |
+ (WebCore::ResourceLoader::resourceData): |
+ (WebCore::ResourceLoader::addData): |
+ * platform/network/BlobResourceHandle.cpp: |
+ (WebCore::BlobResourceHandle::supportsBufferedData): Override the default |
+ behavior. |
+ * platform/network/BlobResourceHandle.h: |
+ * platform/network/ResourceHandle.h: Made supportsBufferedData virtual. |
+ * platform/network/mac/ResourceHandleMac.mm: |
+ (WebCore::ResourceHandle::bufferedData): |
+ |
+2010-09-14 Brent Fulgham <bfulgham@webkit.org> |
+ |
+ Build correction, no review. |
+ |
+ * WebCore.vcproj/WebCore.vcproj: Add missing OwnPtrCairo.cpp |
+ implementation file. |
+ * platform/graphics/cairo/OwnPtrCairo.cpp: Add missing include |
+ for <cairo.h> |
+ |
+2010-09-14 Chris Guillory <chris.guillory@google.com> |
+ |
+ Reviewed by Chris Fleizach. |
+ |
+ Send all accessibility notifications to Chromium. |
+ https://bugs.webkit.org/show_bug.cgi?id=45156 |
+ |
+ Use postAccessibilityNotification to pass accessibility notifications |
+ to chromium. |
+ |
+ Tests: platform/chromium/accessibility/post-notification-ActiveDescendantChanged.html |
+ platform/chromium/accessibility/post-notification-CheckedStateChanged.html |
+ platform/chromium/accessibility/post-notification-ChildrenChanged.html |
+ platform/chromium/accessibility/post-notification-FocusedUIElementChanged.html |
+ platform/chromium/accessibility/post-notification-LayoutComplete.html |
+ platform/chromium/accessibility/post-notification-LiveRegionChanged.html |
+ platform/chromium/accessibility/post-notification-LoadComplete.html |
+ platform/chromium/accessibility/post-notification-MenuListValueChanged.html |
+ platform/chromium/accessibility/post-notification-RowCollapsed.html |
+ platform/chromium/accessibility/post-notification-RowCountChanged.html |
+ platform/chromium/accessibility/post-notification-RowExpanded.html |
+ platform/chromium/accessibility/post-notification-ScrolledToAnchor.html |
+ platform/chromium/accessibility/post-notification-SelectedChildrenChanged.html |
+ platform/chromium/accessibility/post-notification-SelectedTextChanged.html |
+ platform/chromium/accessibility/post-notification-ValueChanged.html |
+ |
+ * accessibility/chromium/AXObjectCacheChromium.cpp: |
+ (WebCore::AXObjectCache::postPlatformNotification): |
+ * page/chromium/ChromeClientChromium.h: |
+ |
+2010-09-14 Darin Adler <darin@apple.com> |
+ |
+ Reviewed by Geoffrey Garen. |
+ |
+ Hang processing href attribute containing a million slashes |
+ https://bugs.webkit.org/show_bug.cgi?id=45767 |
+ |
+ Test: fast/css/visited-link-hang.html |
+ |
+ * platform/LinkHash.cpp: |
+ (WebCore::findSlashDotDotSlash): Added a start position argument and |
+ changed types to use size_t consistently instead of a mix. |
+ (WebCore::findSlashSlash): Ditto. |
+ (WebCore::findSlashDotSlash): Ditto. |
+ (WebCore::squeezeOutNullCharacters): Added. |
+ (WebCore::cleanSlashDotDotSlashes): Added. Factored out part |
+ of cleanPath (see below). |
+ (WebCore::mergeDoubleSlashes): Ditto. |
+ (WebCore::cleanSlashDotSlashes): Ditto. |
+ (WebCore::cleanPath): Changed algorithm to not remove as we go to |
+ avoid N^2 behavior; instead replace with null characters and then |
+ do a squeeze operation after the fact. Also moved the body of the |
+ function out of line since we normally don't have to do any cleaning. |
+ This whole thing should go at some point -- it's not the right |
+ algorithm -- but this should eliminate the performance problems |
+ without changing behavior. |
+ |
+2010-09-14 Nico Weber <thakis@chromium.org> |
+ |
+ Reviewed by Kenneth Russell. |
+ |
+ [chromium]: On Mac, let image layer data row order match skia. |
+ https://bugs.webkit.org/show_bug.cgi?id=45400 |
+ |
+ Make CoreGraphics texture row order match skia's row order, remove all |
+ code that worked around this difference. This also fixes a problem where |
+ image layers would be drawn upside down. |
+ |
+ Covered by existing layout tests, but we don't run these with |
+ compositing yet. |
+ |
+ * platform/graphics/chromium/ContentLayerChromium.cpp: |
+ (WebCore::ContentLayerChromium::SharedValues::SharedValues): |
+ (WebCore::ContentLayerChromium::updateContents): |
+ (WebCore::ContentLayerChromium::updateTextureRect): |
+ * platform/graphics/chromium/LayerRendererChromium.cpp: |
+ (WebCore::LayerRendererChromium::setRootLayerCanvasSize): |
+ (WebCore::LayerRendererChromium::drawLayers): |
+ |
+2010-09-14 Ryosuke Niwa <rniwa@webkit.org> |
+ |
+ Reviewed by Tony Chang. |
+ |
+ applyInlineStyleToNodeRange does not extend run properly |
+ https://bugs.webkit.org/show_bug.cgi?id=45616 |
+ |
+ The bug was caused by applyInlineStyleToNodeRange's skipping a node whenever it has children. |
+ Fixed the bug by only skipping a node that contains the past end node, contains non-editable region, |
+ or has a non-editable parent node. Also fixed a bug that applyInlineStyleToNodeRange does not remove |
+ styled elements in a run that are identical to the one added. addInlineStyleIfNeeded now removes |
+ all styled elements in a run using removeStyleFromRunBeforeApplyingStyle before calling addInlineStyleIfNeeded. |
+ |
+ Test: editing/style/inline-style-extend-run.html |
+ |
+ * editing/ApplyStyleCommand.cpp: |
+ (WebCore::containsNonEditableRegion): Added. |
+ (WebCore::ApplyStyleCommand::applyInlineStyleToNodeRange): See above. |
+ (WebCore::ApplyStyleCommand::removeStyleFromRunBeforeApplyingStyle): Added, see above. |
+ (WebCore::ApplyStyleCommand::removeInlineStyleFromElement): Added support for RemoveAlways. |
+ (WebCore::ApplyStyleCommand::removeImplicitlyStyledElement): Replaced RemoveAttributesAndElements by RemoveIfNeeded. |
+ (WebCore::ApplyStyleCommand::extractInlineStyleToPushDown): Replaced RemoveAttributesAndElements by RemoveIfNeeded. |
+ * editing/ApplyStyleCommand.h: |
+ |
+2010-09-14 Andreas Kling <andreas.kling@nokia.com> |
+ |
+ Reviewed by Kenneth Rohde Christiansen. |
+ |
+ [Qt] V8 port: Get inspector up and running |
+ https://bugs.webkit.org/show_bug.cgi?id=45771 |
+ |
+ * inspector/front-end/WebKit.qrc: Add DebuggerScript.js |
+ |
+2010-09-14 Oliver Hunt <oliver@apple.com> |
+ |
+ PPC Build fix. |
+ |
+ * bindings/js/SerializedScriptValue.cpp: |
+ (WebCore::CloneDeserializer::readFile): |
+ (WebCore::CloneDeserializer::readTerminal): |
+ |
+2010-09-14 Kwang Yul Seo <skyul@company100.net> |
+ |
+ Reviewed by Andreas Kling. |
+ |
+ [chromium] Remove unused ICU headers |
+ https://bugs.webkit.org/show_bug.cgi?id=45698 |
+ |
+ Remove unused headers. |
+ |
+ * platform/graphics/chromium/FontCacheLinux.cpp: |
+ |
+2010-09-14 Andreas Kling <andreas.kling@nokia.com> |
+ |
+ Reviewed by Antonio Gomes. |
+ |
+ [Qt] Numpad Enter key returns keyCode 0 instead of 13 |
+ https://bugs.webkit.org/show_bug.cgi?id=45014 |
+ |
+ Original patch by Jarred Nicholls <jarred.nicholls@gmail.com> |
+ |
+ There is a missing case statement in the PlatformKeyboardEventQt.cpp |
+ file to handle the Enter button on the number pad. Because it is not |
+ handled, the keyCode returned in a JavaScript event is 0 rather than 13. |
+ |
+ Test: manual-tests/qt/numpad-enter-key.html |
+ |
+ * manual-tests/qt/numpad-enter-key.html: Added. |
+ * platform/qt/PlatformKeyboardEventQt.cpp: |
+ (WebCore::windowsKeyCodeForKeyEvent): |
+ |
+2010-09-14 Evan Martin <evan@chromium.org> |
+ |
+ Reviewed by Darin Fisher. |
+ |
+ [chromium] building without debug syms broke after recent refactoring |
+ https://bugs.webkit.org/show_bug.cgi?id=45720 |
+ |
+ Now that we build WebCore as multiple libraries, we need to adjust the |
+ flags to turn off debug symbols for all of these libraries. |
+ |
+ No new tests; should only affect an uncommon build flag. |
+ |
+ * WebCore.gyp/WebCore.gyp: |
+ |
+2010-09-14 Tony Chang <tony@chromium.org> |
+ |
+ Unreviewed, fix chromium compile. |
+ |
+ * platform/graphics/chromium/ImageLayerChromium.h: |
+ |
+2010-09-14 Nico Weber <thakis@chromium.org> |
+ |
+ Reviewed by Darin Fisher. |
+ |
+ [chromium]: crash less in compositor mode on mac |
+ https://bugs.webkit.org/show_bug.cgi?id=45714 |
+ |
+ The contents image can go away when the dom is updated. Since the |
+ layer tree is updated asynchronously, it needs to ref the native image, |
+ else it will hold on to a stale object. |
+ |
+ This still needs to be done for skia, too. |
+ |
+ * platform/graphics/chromium/ImageLayerChromium.h: |
+ * platform/graphics/chromium/ImageLayerChromium.cpp: |
+ |
+2010-09-14 Andrey Kosyakov <caseq@chromium.org> |
+ |
+ Reviewed by Yury Semikhatsky. |
+ |
+ Web Inspector: [Resources panel] [HAR] Need a way to save timing data. |
+ Added support for resource timings to HAREntry. |
+ https://bugs.webkit.org/show_bug.cgi?id=45663 |
+ |
+ * inspector/front-end/HAREntry.js: |
+ (WebInspector.HAREntry.prototype._buildTimings): |
+ (WebInspector.HAREntry.prototype._toMilliseconds): |
+ (WebInspector.HAREntry.prototype._interval): |
+ |
+2010-09-14 Kwang Yul Seo <skyul@company100.net> |
+ |
+ Reviewed by Kent Tamura. |
+ |
+ [BREWMP] Always set LeftButton in PlatformMouseEvent |
+ https://bugs.webkit.org/show_bug.cgi?id=45705 |
+ |
+ AEE_POINTER_GET_MOUSE_MODIFIERS always returns 0, so it is impossible to know |
+ which button is pressed or released. The current code erroneously sets NoButton. |
+ Set LeftButton unconditionally because Brew MP usually runs on touch device. |
+ |
+ * platform/brew/PlatformMouseEventBrew.cpp: |
+ (WebCore::PlatformMouseEvent::PlatformMouseEvent): |
+ |
+2010-09-14 Yury Semikhatsky <yurys@chromium.org> |
+ |
+ Reviewed by Andreas Kling. |
+ |
+ Move DebuggerScript.js from WebKit/chromium/src/js to WebCore/bindings/v8 |
+ https://bugs.webkit.org/show_bug.cgi?id=45739 |
+ |
+ * bindings/v8/DebuggerScript.js: Added. |
+ |
+2010-09-10 Alexander Pavlov <apavlov@chromium.org> |
+ |
+ Reviewed by Pavel Feldman. |
+ |
+ Web Inspector: Implement on-demand reporting of empty CSS rules matched for a node by WebCore |
+ https://bugs.webkit.org/show_bug.cgi?id=45530 |
+ |
+ * css/CSSStyleSelector.cpp: |
+ (WebCore::CSSStyleSelector::matchRules): |
+ (WebCore::CSSStyleSelector::matchRulesForList): |
+ (WebCore::CSSStyleSelector::matchUARules): |
+ (WebCore::CSSStyleSelector::styleForElement): |
+ (WebCore::CSSStyleSelector::pseudoStyleForElement): |
+ (WebCore::CSSStyleSelector::styleRulesForElement): |
+ (WebCore::CSSStyleSelector::pseudoStyleRulesForElement): |
+ * css/CSSStyleSelector.h: |
+ * inspector/InspectorDOMAgent.cpp: |
+ (WebCore::InspectorDOMAgent::getStyles): |
+ (WebCore::InspectorDOMAgent::buildArrayForPseudoElements): |
+ |
+2010-09-14 Hyung Song <beergun@company100.net> |
+ |
+ Reviewed by Darin Adler. |
+ |
+ [BREWMP] Set m_size in SharedBuffer::createWithContentsOfFile(); |
+ https://bugs.webkit.org/show_bug.cgi?id=45701 |
+ |
+ SharedBuffer::createWithContentsOfFile() reads file content and saves to |
+ result.m_buffer directly, leaving result.m_size unchanged. |
+ |
+ * platform/brew/SharedBufferBrew.cpp: |
+ (WebCore::SharedBuffer::createWithContentsOfFile): |
+ |
+2010-09-14 Adam Barth <abarth@webkit.org> |
+ |
+ Reviewed by Darin Adler. |
+ |
+ Move adjustLexerState to the HTMLTokenizer |
+ https://bugs.webkit.org/show_bug.cgi?id=45649 |
+ |
+ This function used let us share code between the tree builder and the |
+ two other users of the HTMLTokenizer. However, now that the tree |
+ builder is all grown up, it can't use this code anymore. The other |
+ users would much rather this code lived on HTMLTokenizer and understood |
+ <script>. This patch attempts to make them happy. |
+ |
+ * html/parser/HTMLPreloadScanner.cpp: |
+ (WebCore::HTMLPreloadScanner::processToken): |
+ * html/parser/HTMLTokenizer.cpp: |
+ (WebCore::HTMLTokenizer::updateStateFor): |
+ * html/parser/HTMLTokenizer.h: |
+ * html/parser/HTMLTreeBuilder.cpp: |
+ (WebCore::HTMLTreeBuilder::scriptEnabled): |
+ * html/parser/HTMLTreeBuilder.h: |
+ * html/parser/HTMLViewSourceParser.cpp: |
+ (WebCore::HTMLViewSourceParser::updateTokenizerState): |
+ |
+2010-09-14 Pierre-Antoine LaFayette <plafayet@codeaurora.org> |
+ |
+ Reviewed by Darin Adler. |
+ |
+ REGRESSION (r52839): Incomplete repaint of IMG with text-align:center |
+ https://bugs.webkit.org/show_bug.cgi?id=40142 |
+ |
+ http://trac.webkit.org/changeset/52839 didn't really deal with the inline replaced element case. This just generalizes to all inline content. |
+ |
+ Patch by: Dave Hyatt |
+ |
+ Tests: fast/repaint/block-layout-inline-children-float-positioned.html |
+ fast/repaint/block-layout-inline-children-replaced.html |
+ |
+ * rendering/RenderBlockLineLayout.cpp: |
+ (WebCore::RenderBlock::layoutInlineChildren): |
+ |
+2010-09-14 Balazs Kelemen <kb@inf.u-szeged.hu> |
+ |
+ Reviewed by Andreas Kling. |
+ |
+ [Qt] Cookie operations should use NetworkingContext |
+ https://bugs.webkit.org/show_bug.cgi?id=45745 |
+ No new functionality so no new tests. |
+ |
+ * platform/qt/CookieJarQt.cpp: |
+ (WebCore::cookieJar): Use the NetworkingContext for obtaining the QNetworkAccessManager |
+ instead of directly accessing the FrameLoaderClient. |
+ |
+2010-09-14 Sheriff Bot <webkit.review.bot@gmail.com> |
+ |
+ Unreviewed, rolling out r67449. |
+ http://trac.webkit.org/changeset/67449 |
+ https://bugs.webkit.org/show_bug.cgi?id=45746 |
+ |
+ This change makes tree red. (Requested by pfeldman on |
+ #webkit). |
+ |
+ * editing/ApplyStyleCommand.cpp: |
+ (WebCore::ApplyStyleCommand::applyInlineStyleToNodeRange): |
+ (WebCore::ApplyStyleCommand::removeInlineStyleFromElement): |
+ (WebCore::ApplyStyleCommand::removeImplicitlyStyledElement): |
+ (WebCore::ApplyStyleCommand::extractInlineStyleToPushDown): |
+ * editing/ApplyStyleCommand.h: |
+ |
+2010-09-14 Eric Seidel <eric@webkit.org> |
+ |
+ Unreviewed, reverting changes r67451 and r67451. |
+ Broke lots of builders. |
+ |
+ Only intercept ESC key press when autocorrection UI is visible. |
+ https://bugs.webkit.org/show_bug.cgi?id=45071 |
+ |
+ * editing/Editor.cpp: |
+ * editing/Editor.h: |
+ * editing/EditorCommand.cpp: |
+ (WebCore::createCommandMap): |
+ * loader/EmptyClients.h: |
+ * page/EditorClient.h: |
+ |
+2010-09-14 Kinuko Yasuda <kinuko@chromium.org> |
+ |
+ Unreviewed; an attempt to fix Chromium Windows build. |
+ |
+ * fileapi/FileEntry.cpp: |
+ |
+2010-09-13 Andrey Kosyakov <caseq@chromium.org> |
+ |
+ Reviewed by Pavel Feldman. |
+ |
+ Web Inspector: provide support for opening external navigation for links within certain elements |
+ Use default handling for clicks on links that have target="_blank". |
+ Add option for external navigation to URL audit formatter. |
+ https://bugs.webkit.org/show_bug.cgi?id=45671 |
+ |
+ * inspector/front-end/AuditFormatters.js: |
+ (WebInspector.AuditFormatters.url): |
+ * inspector/front-end/inspector.js: |
+ |
+2010-09-14 Dan Bernstein <mitz@apple.com> |
+ |
+ Build fix. |
+ |
+ * editing/EditorCommand.cpp: |
+ |
+2010-09-14 Jia Pu <jpu@apple.com> |
+ |
+ Reviewed by Dan Bernstein. |
+ |
+ Only intercept ESC key press when autocorrection UI is visible. |
+ https://bugs.webkit.org/show_bug.cgi?id=45071 |
+ |
+ Only intercept ESC key when autocorrection panel is shown. Otherwise pressing |
+ ESC will cancel current loading like usual. |
+ |
+ * editing/Editor.cpp: |
+ (WebCore::Editor::isShowingCorrectionPanel): Query editor client whether autocorrection |
+ panel is shown. |
+ |
+ * editing/Editor.h: Added declaration of isShowingCorrectionPanel(). |
+ |
+ * editing/EditorCommand.cpp: |
+ (WebCore::supportedDismissCorrectionPanel): Only support executeCancelOperation() |
+ when autocorrection panel is shown. |
+ (WebCore::createCommandMap): Replaced isSupported function pointer for |
+ executeCancelOperation() command with supportedDismissCorrectionPanel(). |
+ |
+ * loader/EmptyClients.h: |
+ (WebCore::EmptyEditorClient::isShowingCorrectionPanel): Dummy implementation of |
+ new member method declared in base class. |
+ |
+ * page/EditorClient.h: Declared new member method isShowingCorrectionPanel(). |
+ |
+2010-09-14 Kwang Yul Seo <skyul@company100.net> |
+ |
+ Reviewed by Kent Tamura. |
+ |
+ [BREWMP] Remove TextBreakIteratorInternalICUBrew.cpp |
+ https://bugs.webkit.org/show_bug.cgi?id=45691 |
+ |
+ Brew MP no longer depends on ICU for internationalization. |
+ Remove TextBreakIteratorInternalICUBrew.cpp. |
+ |
+ * platform/text/brew/TextBreakIteratorInternalICUBrew.cpp: Removed. |
+ |
+2010-09-14 Ryosuke Niwa <rniwa@webkit.org> |
+ |
+ Reviewed by Tony Chang. |
+ |
+ applyInlineStyleToNodeRange does not extend run properly |
+ https://bugs.webkit.org/show_bug.cgi?id=45616 |
+ |
+ The bug was caused by applyInlineStyleToNodeRange's skipping a node whenever it has children. |
+ Fixed the bug by only skipping a node that contains the past end node, contains non-editable region, |
+ or has a non-editable parent node. Also fixed a bug that applyInlineStyleToNodeRange does not remove |
+ styled elements in a run that are identical to the one added. addInlineStyleIfNeeded now removes |
+ all styled elements in a run using removeStyleFromRunBeforeApplyingStyle before calling addInlineStyleIfNeeded. |
+ |
+ Test: editing/style/inline-style-extend-run.html |
+ |
+ * editing/ApplyStyleCommand.cpp: |
+ (WebCore::containsNonEditableRegion): Added. |
+ (WebCore::ApplyStyleCommand::applyInlineStyleToNodeRange): See above. |
+ (WebCore::ApplyStyleCommand::removeStyleFromRunBeforeApplyingStyle): Added, see above. |
+ (WebCore::ApplyStyleCommand::removeInlineStyleFromElement): Added support for RemoveAlways. |
+ (WebCore::ApplyStyleCommand::removeImplicitlyStyledElement): Replaced RemoveAttributesAndElements by RemoveIfNeeded. |
+ (WebCore::ApplyStyleCommand::extractInlineStyleToPushDown): Replaced RemoveAttributesAndElements by RemoveIfNeeded. |
+ * editing/ApplyStyleCommand.h: |
+ |
+2010-09-13 Yuta Kitamura <yutak@chromium.org> |
+ |
+ Reviewed by Kent Tamura. |
+ |
+ Add one #if guard block to fix Qt builds. |
+ |
+ Web Inspector: WebSocket in Resources tab |
+ https://bugs.webkit.org/show_bug.cgi?id=40768 |
+ |
+ * inspector/InspectorResource.cpp: |
+ |
+2010-09-13 Yuta Kitamura <yutak@chromium.org> |
+ |
+ Reviewed by Pavel Feldman. |
+ |
+ Add WebSocket resource type to Web Inspector. |
+ |
+ When a new WebSocket connection is established, a line for that connection |
+ will appear in Web Inspector's Resources tab. If the resource name is |
+ clicked, the details of handshake request and response will be shown. |
+ |
+ Web Inspector: WebSocket in Resources tab |
+ https://bugs.webkit.org/show_bug.cgi?id=40768 |
+ |
+ * inspector/InspectorController.cpp: |
+ (WebCore::InspectorController::addResource): WebSocket resource does not |
+ have an associated loader, thus frame might be null. Need to check it. |
+ (WebCore::InspectorController::removeResource): Ditto. |
+ (WebCore::InspectorController::didCreateWebSocket): |
+ (WebCore::InspectorController::willSendWebSocketHandshakeRequest): |
+ (WebCore::InspectorController::didReceiveWebSocketHandshakeResponse): |
+ (WebCore::InspectorController::didCloseWebSocket): |
+ * inspector/InspectorController.h: |
+ * inspector/InspectorResource.cpp: Add null checks of m_loader and m_frame, |
+ because WebSocket does not have a loader and we need to allow null for |
+ these variables. |
+ (WebCore::createReadableStringFromBinary): |
+ (WebCore::InspectorResource::InspectorResource): |
+ (WebCore::InspectorResource::create): Factory function of |
+ regular (non-WebSocket) resources. |
+ (WebCore::InspectorResource::createWebSocket): Factory function of |
+ WebSocket resources. |
+ (WebCore::InspectorResource::updateWebSocketRequest): |
+ (WebCore::InspectorResource::updateWebSocketResponse): |
+ (WebCore::InspectorResource::updateScriptObject): m_frame->document() becomes |
+ available when Frame::setDocument() is called. We cannot obtain documentURL |
+ during the constructor or updateRequest() function, because m_frame->document() |
+ is not available yet at that point and documentURL will contain a wrong URL. |
+ As far as I know, updateScriptObject() is the only place where we can safely |
+ obtain documentURL. |
+ (WebCore::InspectorResource::cachedResource): |
+ (WebCore::InspectorResource::type): |
+ (WebCore::InspectorResource::resourceData): |
+ * inspector/InspectorResource.h: |
+ (WebCore::InspectorResource::): |
+ (WebCore::InspectorResource::markWebSocket): |
+ * inspector/front-end/Resource.js: |
+ (WebInspector.Resource.Type.toString): |
+ (WebInspector.Resource.prototype.set type): |
+ (WebInspector.Resource.prototype._mimeTypeIsConsistentWithType): |
+ * inspector/front-end/ResourceView.js: |
+ (WebInspector.ResourceView.prototype._refreshRequestHeaders): |
+ (WebInspector.ResourceView.prototype._refreshResponseHeaders): |
+ (WebInspector.ResourceView.prototype._refreshHeaders): |
+ * inspector/front-end/inspector.css: |
+ (.resources-category-websockets, .resources-category-other): |
+ (.resources-category-websockets .resources-graph-bar): |
+ (.resources-category-websockets.resource-cached .resources-graph-bar): |
+ * inspector/front-end/inspector.js: |
+ (WebInspector.loaded): |
+ (WebInspector.updateResource): |
+ * websockets/WebSocketChannel.cpp: |
+ (WebCore::WebSocketChannel::WebSocketChannel): |
+ (WebCore::WebSocketChannel::disconnect): |
+ (WebCore::WebSocketChannel::didOpen): |
+ (WebCore::WebSocketChannel::didClose): |
+ (WebCore::WebSocketChannel::processBuffer): |
+ (WebCore::WebSocketChannel::identifier): |
+ * websockets/WebSocketChannel.h: |
+ |
+2010-09-13 W. James MacLean <wjmaclean@google.com> |
+ |
+ Reviewed by Darin Fisher. |
+ |
+ [chromium] Thumbnails not generated for GPU Rendered Pages |
+ https://bugs.webkit.org/show_bug.cgi?id=44127 |
+ |
+ Replicates existing functionality, use existing tests. |
+ Adds pixel-readback for GPU composited pages to allow for thumbnailing, |
+ printing and other services to work with GPU rendered pages. |
+ |
+ * platform/graphics/chromium/LayerRendererChromium.cpp: |
+ (WebCore::LayerRendererChromium::getFramebufferPixels): |
+ * platform/graphics/chromium/LayerRendererChromium.h: |
+ (WebCore::LayerRendererChromium::rootLayerTextureSize): |
+ |
+2010-09-13 Kinuko Yasuda <kinuko@chromium.org> |
+ |
+ Unreviewed, build fix for Gtk. |
+ |
+ * bindings/js/JSEntryCustom.cpp: |
+ |
+2010-09-13 Kinuko Yasuda <kinuko@chromium.org> |
+ |
+ Reviewed by Adam Barth. |
+ |
+ Make FileEntry and DirectoryEntry methods accessible via Entry instance |
+ https://bugs.webkit.org/show_bug.cgi?id=45553 |
+ |
+ FileEntry- and DirectoryEntry- specific methods must be available on Entry object based on its internal type. |
+ |
+ Added custom toJS/toV8 implementation to Entry interface. |
+ |
+ No new tests; test will be added later when we have complete implementation for the API. |
+ |
+ * CMakeLists.txt: |
+ * GNUmakefile.am: |
+ * WebCore.gypi: |
+ * WebCore.pro: |
+ * WebCore.vcproj/WebCore.vcproj: |
+ * WebCore.xcodeproj/project.pbxproj: |
+ * bindings/js/JSEntryCustom.cpp: Added. |
+ (WebCore::toJS): |
+ * bindings/v8/custom/V8EntryCustom.cpp: Added. |
+ (WebCore::toV8): |
+ * fileapi/DirectoryEntry.h: Nits fix. |
+ * fileapi/DirectoryEntry.idl: Added ConvertUndefinedOrNullToString to path parameter. |
+ * fileapi/Entry.idl: Added CustomToJS attribute. |
+ * fileapi/FileEntry.cpp: |
+ (WebCore::FileEntry::createWriter): |
+ (WebCore::FileEntry::file): |
+ * fileapi/FileEntry.h: |
+ * fileapi/FileEntry.idl: |
+ |
+2010-09-13 Ryosuke Niwa <rniwa@webkit.org> |
+ |
+ Reviewed by Darin Adler. |
+ |
+ REGRESSION: In Gmail, a crash occurs at getDoubleValue() when applying a text color to a new line |
+ https://bugs.webkit.org/show_bug.cgi?id=45632 |
+ |
+ Test: editing/execCommand/query-font-size-with-typing-style.html |
+ |
+ The crash was caused by selectionStartCSSPropertyValue's deleting nodeToRemove before |
+ retrieving the font-size property. Fixed the bug by moving the removal code to the end of the function. |
+ |
+ * editing/Editor.cpp: |
+ (WebCore::Editor::selectionStartCSSPropertyValue): |
+ |
+2010-09-13 Kwang Yul Seo <skyul@company100.net> |
+ |
+ Reviewed by Darin Adler. |
+ |
+ [BREWMP] Remove WebCore namespace in SSLKeyGeneratorBrew.cpp |
+ https://bugs.webkit.org/show_bug.cgi?id=45690 |
+ |
+ WebCore namespace is not required because getSupportedKeySizes and signedPublicKeyAndChallengeString are already |
+ in namespace WebCore block. |
+ |
+ * platform/brew/SSLKeyGeneratorBrew.cpp: |
+ (WebCore::getSupportedKeySizes): |
+ (WebCore::signedPublicKeyAndChallengeString): |
+ |
+2010-09-13 Mario Sanchez Prada <msanchez@igalia.com> |
+ |
+ Reviewed by Martin Robinson. |
+ |
+ [GTK] Code simplification needed in Atk Wrapper |
+ https://bugs.webkit.org/show_bug.cgi?id=45687 |
+ |
+ Use TextIterator::rangeLength() to calculate endOffset |
+ |
+ * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: |
+ (getSelectionOffsetsForObject): Don't manually iterate over a |
+ artificial new range but just call TextIterator::rangeLength on |
+ the range created between the start and end positions. |
+ |
+2010-09-13 Sam Weinig <sam@webkit.org> |
+ |
+ Reviewed by Alice Liu. |
+ |
+ Clean up xcode project. |
+ |
+ * WebCore.xcodeproj/project.pbxproj: |
+ |
+2010-09-13 Eric Carlson <eric.carlson@apple.com> |
+ |
+ Reviewed by Geoff Garen. |
+ |
+ JavaScript dialog should not deactivate media element |
+ https://bugs.webkit.org/show_bug.cgi?id=45688 |
+ |
+ Test: http/tests/media/reload-after-dialog.html |
+ |
+ * bindings/generic/ActiveDOMCallback.cpp: |
+ (WebCore::ActiveDOMObjectCallbackImpl::suspend): Add ReasonForSuspension parameter. |
+ |
+ * bindings/js/ScriptDebugServer.cpp: |
+ (WebCore::ScriptDebugServer::setJavaScriptPaused): Pass new parameter to suspendActiveDOMObjects. |
+ |
+ * dom/ActiveDOMObject.cpp: |
+ (WebCore::ActiveDOMObject::suspend): Add ReasonForSuspension parameter. |
+ * dom/ActiveDOMObject.h: |
+ |
+ * dom/ScriptExecutionContext.cpp: |
+ (WebCore::ScriptExecutionContext::suspendActiveDOMObjects): Ditto. |
+ * dom/ScriptExecutionContext.h: |
+ |
+ * history/CachedFrame.cpp: |
+ (WebCore::CachedFrame::CachedFrame): Pass new parameter to suspendActiveDOMObjects. |
+ |
+ * html/HTMLMarqueeElement.cpp: |
+ (WebCore::HTMLMarqueeElement::suspend): Add ReasonForSuspension parameter. |
+ * html/HTMLMarqueeElement.h: |
+ |
+ * html/HTMLMediaElement.cpp: |
+ (WebCore::HTMLMediaElement::stop): Deal with element being suspended. |
+ (WebCore::HTMLMediaElement::suspend): Do nothing unless reason for suspension is document |
+ becoming inactive. |
+ * html/HTMLMediaElement.h: |
+ |
+ * page/PageGroupLoadDeferrer.cpp: |
+ (WebCore::PageGroupLoadDeferrer::PageGroupLoadDeferrer): Pass WillShowDialog to suspendActiveDOMObjects. |
+ |
+ * page/SuspendableTimer.cpp: |
+ (WebCore::SuspendableTimer::suspend): Add ReasonForSuspension parameter. |
+ * page/SuspendableTimer.h: |
+ |
+ * websockets/WebSocket.cpp: |
+ (WebCore::WebSocket::suspend): Ditto. |
+ * websockets/WebSocket.h: |
+ |
+ * xml/XMLHttpRequest.cpp: |
+ (WebCore::XMLHttpRequest::suspend): Ditto. |
+ * xml/XMLHttpRequest.h: |
+ |
+2010-09-13 Sam Weinig <sam@webkit.org> |
+ |
+ Fix the mac build. |
+ |
+ * page/mac/EventHandlerMac.mm: |
+ (WebCore::EventHandler::passMousePressEventToSubframe): |
+ |
+2010-09-13 Sam Weinig <sam@webkit.org> |
+ |
+ Reviewed by Anders Carlsson. |
+ |
+ Can't scroll on Bugzilla patch review pages on Mac with WebKit2 |
+ https://bugs.webkit.org/show_bug.cgi?id=43555 |
+ |
+ <rdar://problem/8421386> WebKit2: gmail.com is completely unresponsive to clicks |
+ <rdar://problem/8276298> Can't scroll on Bugzilla patch review pages on Mac with WebKit2 (43555) |
+ |
+ * page/mac/EventHandlerMac.mm: |
+ (WebCore::EventHandler::passWheelEventToWidget): |
+ (WebCore::frameHasPlatformWidget): |
+ (WebCore::EventHandler::passMousePressEventToSubframe): |
+ (WebCore::EventHandler::passMouseMoveEventToSubframe): |
+ (WebCore::EventHandler::passMouseReleaseEventToSubframe): |
+ Add WebKit2 mode for these functions based on the presence of a platform widget for a |
+ FrameView. |
+ |
+2010-09-13 Patrick Gansterer <paroga@paroga.com> |
+ |
+ Reviewed by Kenneth Rohde Christiansen. |
+ |
+ [WINCE] Buildfix for ViewportArguments.cpp |
+ https://bugs.webkit.org/show_bug.cgi?id=45678 |
+ |
+ Use fabs() instead of abs(). |
+ This patch also fixes the return value, when |
+ the value is between -1 and 1. |
+ |
+ * dom/ViewportArguments.cpp: |
+ (WebCore::findUserScalableValue): |
+ |
+2010-09-13 Darin Adler <darin@apple.com> |
+ |
+ Reviewed by Adam Barth. |
+ |
+ Preparation for eliminating deprecatedParseURL |
+ https://bugs.webkit.org/show_bug.cgi?id=45695 |
+ |
+ Added new HTMLParserIdioms source file, with a name inspired by the HTML |
+ specification, which has a section defining things like "space character" |
+ that talks about common parser idioms. These are idioms for the main HTML |
+ parser and for parsers for various microlanguages as well. |
+ |
+ * Android.mk: |
+ * CMakeLists.txt: |
+ * GNUmakefile.am: |
+ * WebCore.gypi: |
+ * WebCore.pro: |
+ * WebCore.vcproj/WebCore.vcproj: |
+ * WebCore.xcodeproj/project.pbxproj: |
+ Added HTMLParserIdioms. |
+ |
+ * css/CSSHelper.h: Fixed indentation and comments here. Point to the new |
+ stripLeadingAndTrailingHTMLSpaces function. |
+ |
+ * html/parser/HTMLParserIdioms.cpp: Added. |
+ * html/parser/HTMLParserIdioms.h: Added. |
+ |
+ * html/parser/HTMLTreeBuilder.cpp: |
+ (WebCore::HTMLTreeBuilder::ExternalCharacterTokenBuffer::skipLeadingWhitespace): |
+ (WebCore::HTMLTreeBuilder::ExternalCharacterTokenBuffer::takeLeadingWhitespace): |
+ (WebCore::HTMLTreeBuilder::ExternalCharacterTokenBuffer::takeLeadingNonWhitespace): |
+ (WebCore::HTMLTreeBuilder::ExternalCharacterTokenBuffer::takeRemainingWhitespace): |
+ Updated for name changes. |
+ |
+ * html/parser/HTMLTreeBuilder.h: Moved functions to HTMLParserIdioms.h. |
+ |
+ * html/HTMLInputElement.cpp: |
+ * html/HTMLMeterElement.cpp: |
+ * html/HTMLProgressElement.cpp: |
+ * html/StepRange.cpp: |
+ * rendering/RenderSlider.cpp: |
+ Updated includes. |
+ |
+ * svg/SVGImageLoader.cpp: |
+ (WebCore::SVGImageLoader::sourceURI): Fixed incorrect use of deprecatedParseURL. |
+ This is for use on the attribute value before building the URL, not on the URL |
+ after building it. I did not add a test case; this is an obscure corner and soon |
+ we will be moving to stripLeadingAndTrailingHTMLSpaces anyway. |
+ * wml/WMLImageLoader.cpp: |
+ (WebCore::WMLImageLoader::sourceURI): Ditto. |
+ |
+2010-09-13 Chris Fleizach <cfleizach@apple.com> |
+ |
+ Reviewed by Darin Adler. |
+ |
+ AX: REGRESSION: WebKit does not report label of web popup buttons |
+ https://bugs.webkit.org/show_bug.cgi?id=45715 |
+ |
+ Test: platform/mac/accessibility/popup-button-title.html |
+ |
+ * WebCore.xcodeproj/project.pbxproj: |
+ * accessibility/AccessibilityRenderObject.cpp: |
+ (WebCore::AccessibilityRenderObject::title): |
+ |
+2010-09-13 Kinuko Yasuda <kinuko@chromium.org> |
+ |
+ Reviewed by Dumitru Daniliuc. |
+ |
+ Expose Flags constructor if FileSystem API is Enabled |
+ https://bugs.webkit.org/show_bug.cgi?id=45165 |
+ |
+ This change also includes: |
+ - Changed Flags' attribute names from UPPERCASE to camelCase to reflect the recent spec change. |
+ http://dev.w3.org/2009/dap/file-system/file-dir-sys.html#the-flags-interface |
+ - Enhanced EnabledAtRuntime attribute to take parameter that is used to generate a RuntimeEnabledFeatures method name. |
+ |
+ No new tests; tests will be added when we fully expose the interface. |
+ |
+ * bindings/v8/V8DOMWindowCustom.cpp: Added custom getter for FlagsConstructor. |
+ * fileapi/Flags.idl: Changed attribute names to camelCase. |
+ * page/DOMWindow.idl: Exposed Flags constructor. |
+ |
+ * bindings/scripts/CodeGenerator.pm: Updated the WK_lcfirst hack to work around getter method for 'create' (create() should be avoided as it's widely used to instantiate an object). |
+ * bindings/scripts/CodeGeneratorV8.pm: Added EnabledAtRuntime=FeatureName support. |
+ * bindings/scripts/test/CPP/WebDOMTestObj.cpp: |
+ (WebDOMTestObj::create): |
+ (WebDOMTestObj::setCreate): |
+ * bindings/scripts/test/CPP/WebDOMTestObj.h: |
+ * bindings/scripts/test/GObject/WebKitDOMTestObj.cpp: |
+ (webkit_dom_test_obj_set_property): |
+ (webkit_dom_test_obj_get_property): |
+ (webkit_dom_test_obj_class_init): |
+ * bindings/scripts/test/GObject/WebKitDOMTestObj.h: |
+ * bindings/scripts/test/JS/JSTestObj.cpp: |
+ * bindings/scripts/test/ObjC/DOMTestObj.h: |
+ * bindings/scripts/test/ObjC/DOMTestObj.mm: |
+ * bindings/scripts/test/TestObj.idl: |
+ * bindings/scripts/test/V8/V8TestObj.cpp: |
+ (WebCore::TestObjInternal::createAttrGetter): |
+ (WebCore::TestObjInternal::createAttrSetter): |
+ (WebCore::TestObjInternal::enabledAtRuntimeAttr1AttrGetter): |
+ (WebCore::TestObjInternal::enabledAtRuntimeAttr1AttrSetter): |
+ (WebCore::TestObjInternal::enabledAtRuntimeAttr2AttrGetter): |
+ (WebCore::TestObjInternal::enabledAtRuntimeAttr2AttrSetter): |
+ (WebCore::TestObjInternal::enabledAtRuntimeMethod1Callback): |
+ (WebCore::TestObjInternal::enabledAtRuntimeMethod2Callback): |
+ (WebCore::ConfigureV8TestObjTemplate): |
+ |
+2010-09-13 Adam Barth <abarth@webkit.org> |
+ |
+ Reviewed by Darin Adler. |
+ |
+ "Implement" EOF processing in AfterBodyMode and AfterAfterBodyMode |
+ https://bugs.webkit.org/show_bug.cgi?id=45647 |
+ |
+ Implements the notImplemented by doing nothing, which is the proper |
+ behavior according to the spec. |
+ |
+ * html/parser/HTMLTreeBuilder.cpp: |
+ (WebCore::HTMLTreeBuilder::processEndOfFile): |
+ |
+2010-09-13 Adam Barth <abarth@webkit.org> |
+ |
+ Reviewed by Darin Adler. |
+ |
+ More trivial EOF handling in tree builder |
+ https://bugs.webkit.org/show_bug.cgi?id=45648 |
+ |
+ The spec says to treat these modes like the InBodyMode, which is what |
+ this patch does. Doing so is indistinguishable from our current |
+ behavior, which is why we didn't catch this based on tests. |
+ |
+ * html/parser/HTMLTreeBuilder.cpp: |
+ (WebCore::HTMLTreeBuilder::processEndOfFile): |
+ |
+2010-09-13 James Robinson <jamesr@chromium.org> |
+ |
+ Reviewed by Kenneth Russell. |
+ |
+ SharedGraphicsContext3D's texture cache holds on to images after free |
+ https://bugs.webkit.org/show_bug.cgi?id=45706 |
+ |
+ Each SharedGraphicsContext3D keeps a cache of uploaded textures keyed by NativeImagePtrs. |
+ Whenever the backing native image is deleted it needs to let the SharedGraphicsContext3D know |
+ so that the cache entry and associated texture can also be removed. |
+ |
+ * platform/graphics/gpu/SharedGraphicsContext3D.cpp: |
+ (WebCore::SharedGraphicsContext3D::SharedGraphicsContext3D): |
+ (WebCore::SharedGraphicsContext3D::~SharedGraphicsContext3D): |
+ (WebCore::SharedGraphicsContext3D::removeTextureFor): |
+ (WebCore::SharedGraphicsContext3D::removeTexturesFor): |
+ (WebCore::SharedGraphicsContext3D::allContexts): |
+ * platform/graphics/gpu/SharedGraphicsContext3D.h: |
+ * platform/graphics/skia/NativeImageSkia.cpp: |
+ (WebCore::NativeImageSkia::~NativeImageSkia): |
+ * platform/graphics/skia/NativeImageSkia.h: |
+ |
+2010-09-13 Chris Fleizach <cfleizach@apple.com> |
+ |
+ Reviewed by David Kilzer. |
+ |
+ AX: accessibilityIsIgnored is returning nil when return value expects a BOOL |
+ https://bugs.webkit.org/show_bug.cgi?id=45548 |
+ |
+ Test: platform/mac/accessibility/element-is-ignored.html |
+ |
+ * accessibility/mac/AccessibilityObjectWrapper.mm: |
+ (-[AccessibilityObjectWrapper accessibilityIsIgnored]): |
+ |
+2010-09-13 Chris Fleizach <cfleizach@apple.com> |
+ |
+ Reviewed by Darin Adler. |
+ |
+ CrashTracer: 874 crashes in Safari at com.apple.WebCore: WebCore::AccessibilityTable::isTableExposableThroughAccessibility + 663 |
+ https://bugs.webkit.org/show_bug.cgi?id=45697 |
+ |
+ Inside of AccessibilityTableRow, parentTable() should not use getOrCreate() on the parent table, because the render table may |
+ be in a bad state and accessing internal variables can lead to a crash. |
+ |
+ Test: platform/mac/accessibility/updating-attribute-in-table-row-crash.html |
+ |
+ * accessibility/AccessibilityTableRow.cpp: |
+ (WebCore::AccessibilityTableRow::parentTable): |
+ |
+2010-09-13 Adam Barth <abarth@webkit.org> |
+ |
+ Reviewed by Eric Seidel. |
+ |
+ Implement EOF handling in TextMode |
+ https://bugs.webkit.org/show_bug.cgi?id=45644 |
+ |
+ This patch is actually covered by a bunch of tests. We were just |
+ magically passing the tests before because of some nutty code in |
+ Document.cpp. |
+ |
+ * dom/Document.cpp: |
+ (WebCore::Document::implicitClose): |
+ - This code was masking the notImplemented in the tree builder. |
+ I also removed the use of the setting because it wasn't working |
+ properly anyway. I'll implement a working version shortly. |
+ * html/parser/HTMLTreeBuilder.cpp: |
+ (WebCore::HTMLTreeBuilder::processEndOfFile): |
+ - Implement per the spec. |
+ |
+2010-09-13 Enrica Casucci <enrica@apple.com> |
+ |
+ Reviewed by Sam Weining. |
+ |
+ Paste should be implemented in WebCore like Copy and Cut for Mac also. |
+ https://bugs.webkit.org/show_bug.cgi?id=45494 |
+ <rdar://problem/7660537> |
+ |
+ On the Mac platform, the implementation of the paste operation is all done |
+ at the WebKit level. In order to support it on WebKit2 it is necessary to |
+ refactor the code and move this functionality at the level of WebCore like |
+ we already have on Windows. |
+ The original code relies on some in AppKit functions that call back into |
+ WebKit causing problems in WebKit2. All this functionality has been moved |
+ at the level of the editor client where it can be dealt with appropriately. |
+ |
+ * editing/Editor.cpp: |
+ (WebCore::Editor::shouldInsertFragment): |
+ * editing/mac/EditorMac.mm: extended to support Mail specific scenarios. |
+ (WebCore::Editor::pasteWithPasteboard): |
+ * loader/EmptyClients.h: |
+ (WebCore::EmptyFrameLoaderClient::canShowMIMETypeAsHTML): Added. |
+ (WebCore::EmptyEditorClient::documentFragmentFromAttributedString): Added. |
+ (WebCore::EmptyEditorClient::setInsertionPasteboard): Added to support Mail. |
+ * loader/FrameLoaderClient.h: |
+ * page/EditorClient.h: |
+ * platform/Pasteboard.h: |
+ * platform/mac/PasteboardMac.mm: |
+ (WebCore::Pasteboard::writeSelection): replaced call to Appkit with one that |
+ doesn't calll back into WebKit. |
+ (WebCore::Pasteboard::documentFragmentWithImageResource): Re-implemented at the |
+ WebCore level. |
+ (WebCore::Pasteboard::documentFragmentWithRtf): Re-implemented at the |
+ WebCore level. |
+ (WebCore::uniqueURLWithRelativePart): Added. |
+ (WebCore::Pasteboard::documentFragment): Extended to include all the functionality |
+ provided in documentFragmentFromPasteboard in WebHTMLView.mm. |
+ |
+2010-09-13 Alejandro G. Castro <alex@igalia.com> |
+ |
+ Reviewed by Kenneth Rohde Christiansen. |
+ |
+ [Gtk] Reduce the size of the shadow buffer in the paths using the clip region |
+ https://bugs.webkit.org/show_bug.cgi?id=44699 |
+ |
+ Intersect the clip bounding rect with the path that we are going |
+ to use to create the shadow in order to reduce the region we have |
+ to blur. |
+ |
+ * platform/graphics/cairo/GraphicsContextCairo.cpp: |
+ (WebCore::drawPathShadow): |
+ |
+210-09-13 Darin Fisher <darin@chromium.org> |
+ |
+ Reviewed by David Levin. |
+ |
+ Add option to conditionally compile smooth scrolling support. |
+ https://bugs.webkit.org/show_bug.cgi?id=45689 |
+ |
+ The OS(WINDOWS) conditional becomes unnecessary since |
+ ENABLE(SMOOTH_SCROLLING) should only be specified on |
+ platforms that have a smooth scrolling implementation. |
+ |
+ * platform/ScrollAnimator.cpp: |
+ * platform/ScrollAnimatorWin.cpp: |
+ * platform/ScrollAnimatorWin.h: |
+ |
+2010-09-13 Ryosuke Niwa <rniwa@webkit.org> |
+ |
+ Reviewed by Kent Tamura. |
+ |
+ Move functions of StyledMarkupAccumulator below that of MarkupAccumulator |
+ https://bugs.webkit.org/show_bug.cgi?id=45624 |
+ |
+ Moved the declaration of StyledMarkupAccumulator and the definitions of its member functions |
+ to below the definitions of MarkupAccumulator's member functions. |
+ |
+ No new tests are added since this is a cleanup. |
+ |
+ * editing/markup.cpp: |
+ (WebCore::StyledMarkupAccumulator::StyledMarkupAccumulator): |
+ (WebCore::StyledMarkupAccumulator::appendElement): |
+ (WebCore::StyledMarkupAccumulator::shouldAnnotate): |
+ (WebCore::StyledMarkupAccumulator::wrapWithNode): |
+ (WebCore::StyledMarkupAccumulator::wrapWithStyleNode): |
+ (WebCore::StyledMarkupAccumulator::takeResults): |
+ (WebCore::StyledMarkupAccumulator::appendText): |
+ (WebCore::StyledMarkupAccumulator::renderedText): |
+ (WebCore::StyledMarkupAccumulator::stringValueForRange): |
+ (WebCore::styleFromMatchedRulesForElement): |
+ (WebCore::StyledMarkupAccumulator::removeExteriorStyles): |
+ (WebCore::needInterchangeNewlineAfter): |
+ (WebCore::styleFromMatchedRulesAndInlineDecl): |
+ (WebCore::removeEnclosingMailBlockquoteStyle): |
+ (WebCore::removeDefaultStyles): |
+ |
+2010-09-13 Alejandro G. Castro <alex@igalia.com> |
+ |
+ Reviewed by Martin Robinson. |
+ |
+ [GTK] Leak in the GraphicsContextCairo drawPathShadow |
+ https://bugs.webkit.org/show_bug.cgi?id=44959 |
+ |
+ Fix a leak of the cairo_path. |
+ |
+ * platform/graphics/cairo/GraphicsContextCairo.cpp: |
+ (WebCore::drawPathShadow): |
+ * platform/graphics/cairo/OwnPtrCairo.cpp: |
+ (WTF::cairo_path_t): |
+ * platform/graphics/cairo/OwnPtrCairo.h: |
+ |
+2010-09-13 Adam Barth <abarth@webkit.org> |
+ |
+ Reviewed by Darin Adler. |
+ |
+ Fix </sarcasm> |
+ https://bugs.webkit.org/show_bug.cgi?id=45645 |
+ |
+ Umm... Yeah. |
+ |
+ * html/parser/HTMLTreeBuilder.cpp: |
+ (WebCore::HTMLTreeBuilder::processEndTagForInBody): |
+ |
+2010-09-13 Gyuyoung Kim <gyuyoung.kim@samsung.com> |
+ |
+ Reviewed by Darin Adler. |
+ |
+ [WML] Fix build breaks when WML is enabled |
+ https://bugs.webkit.org/show_bug.cgi?id=45628 |
+ |
+ There are build breaks by Bug 22382 when WML is enabled. The handleLinkClick() has an event parameter. |
+ So, we need to set an event when wml invoke the handleLinkClick(). And, doTextFieldCommandFromEvent() |
+ was moved to editor. So, we need to mofidy the invocation in WMLInputElement.cpp |
+ |
+ * wml/WMLAElement.cpp: |
+ (WebCore::WMLAElement::defaultEventHandler): |
+ * wml/WMLInputElement.cpp: |
+ (WebCore::WMLInputElement::defaultEventHandler): |
+ |
+2010-09-13 Martin Robinson <mrobinson@igalia.com> |
+ |
+ Reviewed by Xan Lopez. |
+ |
+ [GTK] When a feature is disabled by default, the source necessary to build it are not included in the distribution |
+ https://bugs.webkit.org/show_bug.cgi?id=45230 |
+ |
+ No new tests as this is just a build change. |
+ |
+ * GNUmakefile.am: Move as many sources as possible to the SOURCES primary. |
+ Others should be moved over time as we solve issues with them. |
+ |
+2010-09-13 Chris Fleizach <cfleizach@apple.com> |
+ |
+ Reviewed by Darin Adler. |
+ |
+ REGRESSION (r64816-r64889): Crash in WebCore::AccessibilityRenderObject |
+ https://bugs.webkit.org/show_bug.cgi?id=43807 |
+ |
+ Ensure that visiblePositionForPoint can handle non RenderBoxModelObject types. |
+ |
+ Test: platform/mac/accessibility/visible-position-crash-for-text-node.html |
+ |
+ * accessibility/AccessibilityRenderObject.cpp: |
+ (WebCore::AccessibilityRenderObject::visiblePositionForPoint): |
+ |
+2010-09-13 Martin Robinson <mrobinson@igalia.com> |
+ |
+ Reviewed by Andreas Kling. |
+ |
+ [Qt] DOM listeners get wrong keycodes for some keys |
+ https://bugs.webkit.org/show_bug.cgi?id=43365 |
+ |
+ Produce the proper keycodes for the print screen key as well as the |
+ keypad insert and delete keys. |
+ |
+ * platform/qt/PlatformKeyboardEventQt.cpp: |
+ (WebCore::windowsKeyCodeForKeyEvent): Fix keycode translation for the mentioned keys. |
+ |
+2010-09-13 Jonathan Dixon <joth@chromium.org> |
+ |
+ Reviewed by Steve Block. |
+ |
+ [chromium] Port test shell geolocation fixes to DRT |
+ https://bugs.webkit.org/show_bug.cgi?id=45313 |
+ |
+ Also re-apply rolled out patch http://trac.webkit.org/changeset/66886 :- |
+ Add missing virtual destructor to the abstract base class. |
+ |
+ * platform/chromium/GeolocationServiceChromium.cpp: |
+ (WebCore::GeolocationServiceBridge::~GeolocationServiceBridge): |
+ * platform/chromium/GeolocationServiceChromium.h: |
+ |
+2010-09-13 Yury Semikhatsky <yurys@chromium.org> |
+ |
+ Reviewed by Pavel Feldman. |
+ |
+ Web Inspector: upstream testExpandScope debugger test |
+ https://bugs.webkit.org/show_bug.cgi?id=45260 |
+ |
+ Test: inspector/debugger-expand-scope.html |
+ |
+ * inspector/front-end/InjectedScript.js: return "Arguments" as class name for arguments variable in v8. |
+ (injectedScriptConstructor.): |
+ |
+2010-09-13 Mario Sanchez Prada <msanchez@igalia.com> |
+ |
+ Reviewed by Martin Robinson. |
+ |
+ [GTK] ATs should be able to select/unselect text |
+ https://bugs.webkit.org/show_bug.cgi?id=25673 |
+ |
+ Implement AtkText's setSelection and removeSelection functions |
+ |
+ * accessibility/AccessibilityObject.cpp: |
+ (WebCore::AccessibilityObject::visiblePositionRangeForRange): |
+ Moved some GTK specific code from a ifdef-endif region to |
+ AccessibilityObjectAtk.cpp |
+ * accessibility/AccessibilityObject.h: |
+ * accessibility/gtk/AccessibilityObjectAtk.cpp: |
+ (WebCore::AccessibilityObject::getLengthForTextRange): New. |
+ * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: |
+ (webkit_accessible_text_remove_selection): Implemented following |
+ the lead of GAIL's implementation of the AtkText interface. |
+ (webkit_accessible_text_set_selection): Implemented following |
+ the lead of GAIL's implementation of the AtkText interface. |
+ (webkit_accessible_text_set_caret_offset): Changed to directly use |
+ visiblePositionRangeForRange now that there's no longer a problem |
+ with that, as it was in the past (only worked for text controls). |
+ |
+2010-08-27 Kenneth Rohde Christiansen <kenneth@webkit.org> |
+ |
+ Reviewed by Antti Koivisto. |
+ |
+ Update support for the viewport meta tag algorithm, to |
+ match the following draft spec: |
+ |
+ http://people.opera.com/rune/TR/ED-css-viewport-20100806/ |
+ |
+ Add common handling of viewport meta tag based on new Opera spec |
+ https://bugs.webkit.org/show_bug.cgi?id=44201 |
+ |
+ Tests: fast/viewport/viewport-1.html |
+ fast/viewport/viewport-10.html |
+ fast/viewport/viewport-100.html |
+ fast/viewport/viewport-101.html |
+ fast/viewport/viewport-102.html |
+ fast/viewport/viewport-103.html |
+ fast/viewport/viewport-104.html |
+ fast/viewport/viewport-105.html |
+ fast/viewport/viewport-106.html |
+ fast/viewport/viewport-107.html |
+ fast/viewport/viewport-108.html |
+ fast/viewport/viewport-109.html |
+ fast/viewport/viewport-11.html |
+ fast/viewport/viewport-110.html |
+ fast/viewport/viewport-111.html |
+ fast/viewport/viewport-112.html |
+ fast/viewport/viewport-113.html |
+ fast/viewport/viewport-114.html |
+ fast/viewport/viewport-115.html |
+ fast/viewport/viewport-116.html |
+ fast/viewport/viewport-117.html |
+ fast/viewport/viewport-118.html |
+ fast/viewport/viewport-119.html |
+ fast/viewport/viewport-12.html |
+ fast/viewport/viewport-120.html |
+ fast/viewport/viewport-121.html |
+ fast/viewport/viewport-122.html |
+ fast/viewport/viewport-123.html |
+ fast/viewport/viewport-124.html |
+ fast/viewport/viewport-125.html |
+ fast/viewport/viewport-126.html |
+ fast/viewport/viewport-127.html |
+ fast/viewport/viewport-13.html |
+ fast/viewport/viewport-14.html |
+ fast/viewport/viewport-15.html |
+ fast/viewport/viewport-16.html |
+ fast/viewport/viewport-17.html |
+ fast/viewport/viewport-18.html |
+ fast/viewport/viewport-19.html |
+ fast/viewport/viewport-2.html |
+ fast/viewport/viewport-20.html |
+ fast/viewport/viewport-21.html |
+ fast/viewport/viewport-22.html |
+ fast/viewport/viewport-23.html |
+ fast/viewport/viewport-24.html |
+ fast/viewport/viewport-25.html |
+ fast/viewport/viewport-26.html |
+ fast/viewport/viewport-27.html |
+ fast/viewport/viewport-28.html |
+ fast/viewport/viewport-29.html |
+ fast/viewport/viewport-3.html |
+ fast/viewport/viewport-30.html |
+ fast/viewport/viewport-31.html |
+ fast/viewport/viewport-32.html |
+ fast/viewport/viewport-33.html |
+ fast/viewport/viewport-34.html |
+ fast/viewport/viewport-35.html |
+ fast/viewport/viewport-36.html |
+ fast/viewport/viewport-37.html |
+ fast/viewport/viewport-38.html |
+ fast/viewport/viewport-39.html |
+ fast/viewport/viewport-4.html |
+ fast/viewport/viewport-40.html |
+ fast/viewport/viewport-41.html |
+ fast/viewport/viewport-42.html |
+ fast/viewport/viewport-43.html |
+ fast/viewport/viewport-44.html |
+ fast/viewport/viewport-45.html |
+ fast/viewport/viewport-46.html |
+ fast/viewport/viewport-47.html |
+ fast/viewport/viewport-48.html |
+ fast/viewport/viewport-49.html |
+ fast/viewport/viewport-5.html |
+ fast/viewport/viewport-50.html |
+ fast/viewport/viewport-51.html |
+ fast/viewport/viewport-52.html |
+ fast/viewport/viewport-53.html |
+ fast/viewport/viewport-54.html |
+ fast/viewport/viewport-55.html |
+ fast/viewport/viewport-56.html |
+ fast/viewport/viewport-57.html |
+ fast/viewport/viewport-58.html |
+ fast/viewport/viewport-59.html |
+ fast/viewport/viewport-6.html |
+ fast/viewport/viewport-60.html |
+ fast/viewport/viewport-61.html |
+ fast/viewport/viewport-62.html |
+ fast/viewport/viewport-63.html |
+ fast/viewport/viewport-64.html |
+ fast/viewport/viewport-65.html |
+ fast/viewport/viewport-66.html |
+ fast/viewport/viewport-67.html |
+ fast/viewport/viewport-68.html |
+ fast/viewport/viewport-69.html |
+ fast/viewport/viewport-7.html |
+ fast/viewport/viewport-70.html |
+ fast/viewport/viewport-71.html |
+ fast/viewport/viewport-72.html |
+ fast/viewport/viewport-73.html |
+ fast/viewport/viewport-74.html |
+ fast/viewport/viewport-75.html |
+ fast/viewport/viewport-76.html |
+ fast/viewport/viewport-77.html |
+ fast/viewport/viewport-78.html |
+ fast/viewport/viewport-79.html |
+ fast/viewport/viewport-8.html |
+ fast/viewport/viewport-80.html |
+ fast/viewport/viewport-81.html |
+ fast/viewport/viewport-82.html |
+ fast/viewport/viewport-83.html |
+ fast/viewport/viewport-84.html |
+ fast/viewport/viewport-85.html |
+ fast/viewport/viewport-86.html |
+ fast/viewport/viewport-87.html |
+ fast/viewport/viewport-88.html |
+ fast/viewport/viewport-9.html |
+ fast/viewport/viewport-90.html |
+ |
+ * dom/ViewportArguments.cpp: |
+ (WebCore::findConfigurationForViewportData): |
+ (WebCore::findSizeValue): |
+ (WebCore::findScaleValue): |
+ (WebCore::findUserScalableValue): |
+ (WebCore::findTargetDensityDPIValue): |
+ (WebCore::setViewportFeature): |
+ * dom/ViewportArguments.h: |
+ (WebCore::ViewportArguments::): |
+ (WebCore::ViewportArguments::ViewportArguments): |
+ (WebCore::ViewportArguments::hasCustomArgument): |
+ |
+2010-09-13 Andreas Kling <andreas.kling@nokia.com> |
+ |
+ Reviewed by Kenneth Rohde Christiansen. |
+ |
+ [Qt] Don't add empty strings to list of supported image MIME types |
+ https://bugs.webkit.org/show_bug.cgi?id=45643 |
+ |
+ After <http://trac.webkit.org/changeset/67355> getMIMETypeForExtension() |
+ returns an empty string instead of "application/octet-stream" for unsupported |
+ extensions. Don't add these to the list of supported types, and clean out |
+ the logic that removed "application/octet-stream" from supported types. |
+ |
+ Fixes crash in initializeMIMETypeRegistry() due to inserting String() into |
+ a HashSet<String>. |
+ |
+ * platform/MIMETypeRegistry.cpp: |
+ (WebCore::initializeSupportedImageMIMETypes): |
+ (WebCore::initializeSupportedImageMIMETypesForEncoding): |
+ |
+2010-09-13 Adam Barth <abarth@webkit.org> |
+ |
+ Attempted Qt build fix. |
+ |
+ * html/parser/HTMLElementStack.cpp: |
+ |
+2010-09-13 Adam Barth <abarth@webkit.org> |
+ |
+ Reviewed by Eric Seidel. |
+ |
+ Apply spec changes to InForeignContentMode |
+ https://bugs.webkit.org/show_bug.cgi?id=45636 |
+ |
+ Now breaking out of foreign content doesn't always bring you back to |
+ HTML. If you have a foreign content element that can contain HTML, you |
+ just get brought back to that element. |
+ |
+ * html/parser/HTMLElementStack.cpp: |
+ (WebCore::HTMLNames::isForeignContentScopeMarker): |
+ (WebCore::HTMLElementStack::popUntilForeignContentScopeMarker): |
+ * html/parser/HTMLElementStack.h: |
+ * html/parser/HTMLTreeBuilder.cpp: |
+ (WebCore::HTMLTreeBuilder::processStartTag): |
+ (WebCore::HTMLTreeBuilder::processEndOfFile): |
+ |
+2010-09-13 Adam Barth <abarth@webkit.org> |
+ |
+ Reviewed by Eric Seidel. |
+ |
+ Convert notImplemented() to ASSERT_NOT_REACHED |
+ https://bugs.webkit.org/show_bug.cgi?id=45639 |
+ |
+ The reason we never implemented this state is because it's not actually |
+ reachable. |
+ |
+ * html/parser/HTMLTreeBuilder.cpp: |
+ (WebCore::HTMLTreeBuilder::processStartTag): |
+ |
+2010-09-13 Patrick Gansterer <paroga@paroga.com> |
+ |
+ Reviewed by Kenneth Rohde Christiansen. |
+ |
+ [WINCE] Buildfix for ScrollAnimatorWin |
+ https://bugs.webkit.org/show_bug.cgi?id=45595 |
+ |
+ Use fabs() instead of abs(). |
+ |
+ * platform/ScrollAnimatorWin.cpp: |
+ (WebCore::ScrollAnimatorWin::scroll): |
+ (WebCore::ScrollAnimatorWin::animateScroll): |
+ |
+2010-09-13 Adam Barth <abarth@webkit.org> |
+ |
+ Reviewed by Eric Seidel. |
+ |
+ Remove fixed FIXME |
+ https://bugs.webkit.org/show_bug.cgi?id=45637 |
+ |
+ The spec made assertions that were false. Hixie fixed the spec by |
+ removing the assertions. There's no need to keep these FIXMEs in the |
+ code. |
+ |
+ * html/parser/HTMLTreeBuilder.cpp: |
+ (WebCore::HTMLTreeBuilder::processEndTagForInCell): |
+ |
+2010-09-12 Adam Barth <abarth@webkit.org> |
+ |
+ Reviewed by Eric Seidel. |
+ |
+ Remove FIXME now that the HTML5 spec has been updated |
+ https://bugs.webkit.org/show_bug.cgi?id=45634 |
+ |
+ The spec changed to say what we do here so this FIXME isn't needed |
+ anymore. |
+ |
+ Tests: fast/parser/form-pointer-1.html |
+ fast/parser/form-pointer-2.html |
+ fast/parser/form-pointer-3.html |
+ fast/parser/form-pointer-4.html |
+ |
+ * html/parser/HTMLTreeBuilder.cpp: |
+ (WebCore::HTMLTreeBuilder::processStartTagForInTable): |
+ |
+2010-09-12 Robin Qiu <robin.qiu@torchmobile.com.cn> |
+ |
+ Reviewed by Antonio Gomes. |
+ |
+ https://bugs.webkit.org/show_bug.cgi?id=18768 |
+ Fixed a bug in scroll flow. When we don't have scrollbars, we need to |
+ repaintFixedElementsAfterScrolling(), sendScrollEvent() ... as well as |
+ scrollContents(); |
+ |
+ Tests: scrollbars/scrollevent-iframe-no-scrolling-wheel.html |
+ scrollbars/scrollevent-iframe-no-scrolling.html |
+ |
+ * page/FrameView.cpp: |
+ (WebCore::FrameView::valueChanged): Added. |
+ * page/FrameView.h: Added a new method. |
+ * platform/ScrollView.cpp: |
+ (WebCore::ScrollView::valueChanged): Added. |
+ (WebCore::ScrollView::updateScrollbars): |
+ * platform/ScrollView.h: Added a new method. |
+ |
+2010-09-10 MORITA Hajime <morrita@google.com> |
+ |
+ Reviewed by Tony Chang. |
+ |
+ [Chromium] Implement textInputController.hasSpellingMarker() for Chromium |
+ https://bugs.webkit.org/show_bug.cgi?id=45441 |
+ |
+ Added an API for testing marker state. |
+ We locate this here instead of DRT for sharing the logic between |
+ multiple ports. |
+ |
+ * WebCore.exp.in: |
+ * editing/Editor.cpp: |
+ (WebCore::Editor::selectionStartHasSpellingMarkerFor): |
+ * editing/Editor.h: |
+ |
+2010-09-12 Adam Barth <abarth@webkit.org> |
+ |
+ Reviewed by Eric Seidel. |
+ |
+ Adoption agency should use takeAllChildrenFrom |
+ https://bugs.webkit.org/show_bug.cgi?id=45570 |
+ |
+ Before this patch, we were using an unsafe pattern of walking the |
+ sibling list without grabbing references. Instead, we should use the |
+ shiny new takeAllChildrenFrom method that shoves the children into a |
+ vector first. Also, update takeAllChildrenFrom to handle the case |
+ where the old parent is attached. |
+ |
+ * dom/ContainerNode.cpp: |
+ (WebCore::ContainerNode::takeAllChildrenFrom): |
+ * html/parser/HTMLTreeBuilder.cpp: |
+ (WebCore::HTMLTreeBuilder::callTheAdoptionAgency): |
+ * html/parser/HTMLTreeBuilder.h: |
+ |
+2010-09-12 Adam Barth <abarth@webkit.org> |
+ |
+ Reviewed by Eric Seidel. |
+ |
+ isParsingFragment assert hit in new treebuilder |
+ https://bugs.webkit.org/show_bug.cgi?id=45621 |
+ |
+ Update our list of special tags to match the spec. |
+ |
+ * html/parser/HTMLTreeBuilder.cpp: |
+ |
+2010-09-12 Robert Hogan <robert@webkit.org> |
+ |
+ Reviewed by Andreas Kling. |
+ |
+ [Qt] Fix http/tests/navigation/reload-subframe-object.html |
+ |
+ We need to bring our use of getMimeTypeForPath() and |
+ getMimeTypeForExtension() into line with WebCore expectations. |
+ |
+ We should use MIMETypeRegistry::getMIMETypeForExtension() for cases |
+ where an empty mimetype should be returned if no match is found, and |
+ MIMETypeRegistry::getMIMETypeForPath() for cases where |
+ 'application/octet-stream' should be returned if no match is found. |
+ |
+ Fixes http/tests/navigation/reload-subframe-object.html |
+ |
+ Based on findings in webkit.org/b/31398 and webkit.org/b/15554. |
+ |
+ https://bugs.webkit.org/show_bug.cgi?id=45613 |
+ |
+ * platform/network/qt/QNetworkReplyHandler.cpp: |
+ (WebCore::QNetworkReplyHandler::sendResponseIfNeeded): |
+ * platform/qt/MIMETypeRegistryQt.cpp: |
+ (WebCore::MIMETypeRegistry::getMIMETypeForExtension): |
+ |
+2010-09-12 Dan Bernstein <mitz@apple.com> |
+ |
+ Reviewed by Adele Peterson. |
+ |
+ Neglect unlikely hyphenation opportunities |
+ https://bugs.webkit.org/show_bug.cgi?id=45606 |
+ |
+ Avoid looking for hyphenation points in about 40% of the cases at the cost of missing about |
+ 3% of the hyphenation opportunities. |
+ |
+ * rendering/RenderBlockLineLayout.cpp: |
+ (WebCore::tryHyphenating): Bail out if the widest the prefix before the hyphen can be is no more |
+ than 5/4 the font size. |
+ |
+2010-09-12 Oswald Buddenhagen <oswald.buddenhagen@nokia.com> |
+ |
+ Reviewed by Simon Hausmann. |
+ |
+ [Qt] fix qt_webkit_version.pri install for in-Qt builds |
+ |
+ Always add the target, even if building inside Qt - as opposed to the |
+ headers and libraries, there are no rules for that coming from |
+ qbase.pri. |
+ |
+ Task-number: QTBUG-13306 |
+ |
+ * WebCore.pro: |
+ |
+2010-09-12 Oswald Buddenhagen <oswald.buddenhagen@nokia.com> |
+ |
+ Reviewed by Simon Hausmann. |
+ |
+ [Qt] Let QtWebKit inject itself into the qt configuration |
+ |
+ i.e., don't explicitly deal with qt_webkit_version.pri outside of the |
+ webkit source directory. |
+ |
+ Task-number: QTBUG-12379 |
+ |
+ * WebCore.pro: |
+ |
+2010-09-12 Simon Hausmann <simon.hausmann@nokia.com> |
+ |
+ [Qt] Build fix. |
+ |
+ * WebCore.pro: Re-add erroneously removed sources. |
+ |
+2010-09-12 Andreas Kling <andreas.kling@nokia.com> |
+ |
+ Reviewed by Kenneth Rohde Christiansen. |
+ |
+ [Qt] Remove Path::closeSubpath() workaround for broken miter joins |
+ https://bugs.webkit.org/show_bug.cgi?id=45618 |
+ |
+ Removed Path::closeCanvasSubpath() and share the logic between Canvas and SVG |
+ paths. The problem was actually in Qt's path stroker and has been fixed for Qt 4.7.1. |
+ |
+ * html/canvas/CanvasRenderingContext2D.cpp: |
+ (WebCore::CanvasRenderingContext2D::closePath): |
+ * platform/graphics/Path.h: |
+ * platform/graphics/qt/PathQt.cpp: |
+ |
+2010-09-12 Simon Hausmann <simon.hausmann@nokia.com> |
+ |
+ Fix the Gtk and minimal builds. |
+ |
+ * plugins/PluginView.cpp: |
+ (WebCore::PluginView::npObject): Correct the #ifdefs. |
+ (WebCore::PluginView::bindingInstance): Moved npErr variable |
+ into npObject() function where it is used. |
+ |
+2010-09-12 Simon Hausmann <simon.hausmann@nokia.com> |
+ |
+ [Qt] Prospective build fix for minimal build. |
+ |
+ * plugins/PluginView.cpp: Guard newly added function |
+ by ENABLE_NETSCAPE_PLUGIN feature. |
+ (WebCore::PluginView::npObject): |
+ * plugins/PluginView.h: |
+ |
+2010-09-12 Simon Hausmann <simon.hausmann@nokia.com> |
+ |
+ Reviewed by Andreas Kling. |
+ |
+ [Qt] Add support for binding QtWebKit to a QScriptEngine. |
+ |
+ The ScriptController owns the V8 context, and this patch |
+ for the Qt build also gives it a QScriptEngine, that has |
+ been instructed to adopt the V8 context. |
+ |
+ This is the enabler for the QObject bindings, used in |
+ the API and DRT. |
+ |
+ * WebCore.pro: |
+ * bindings/v8/ScriptController.cpp: Include QScriptEngine |
+ for the Qt build, to let the ~ScriptController destructor |
+ find the QScriptEngine destructor (via OwnPtr). |
+ * bindings/v8/ScriptController.h: Declare getters. |
+ * bindings/v8/ScriptControllerQt.cpp: Added. |
+ (WebCore::ScriptController::qtScriptEngine): Implement |
+ engine adoption. |
+ |
+2010-09-12 Simon Hausmann <simon.hausmann@nokia.com> |
+ |
+ Reviewed by Andreas Kling. |
+ |
+ [Qt] Last bits and pieces for a V8 build. |
+ |
+ When building with V8, get it from QtScript. |
+ |
+ * WebCore.pro: Use QtScript, removed non-existant |
+ bridge files from the build. |
+ |
+2010-09-12 Simon Hausmann <simon.hausmann@nokia.com> |
+ |
+ Reviewed by Andreas Kling. |
+ |
+ [Qt] Add PlatformBridge for V8 build. |
+ |
+ Add the minimalisting platform bridge with the two |
+ methods needed by NPV8Object.cpp. |
+ |
+ * WebCore.pro: |
+ * platform/qt/PlatformBridge.h: Added. |
+ * platform/qt/PlatformBridgeQt.cpp: Added. |
+ (WebCore::PlatformBridge::popupsAllowed): |
+ (WebCore::PlatformBridge::pluginScriptableObject): |
+ * plugins/PluginView.cpp: Refactor the plugin object |
+ retrieval code into a separate function, called by |
+ bindingInstance() and PlatformBridge. |
+ (WebCore::PluginView::npObject): |
+ (WebCore::PluginView::bindingInstance): |
+ * plugins/PluginView.h: |
+ |
+2010-09-11 Jer Noble <jer.noble@apple.com> |
+ |
+ Reviewed by Eric Carlson. |
+ |
+ http/tests/media/text-served-as-text.html failing on Windows (Debug+Release) |
+ https://bugs.webkit.org/show_bug.cgi?id=45603 |
+ |
+ Disable the eat/text components under Windows the same way as we do on the Mac. |
+ |
+ * platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp: |
+ * platform/graphics/win/QTMovie.cpp: |
+ * platform/graphics/win/QTMovie.h: |
+ |
+2010-09-12 Simon Hausmann <simon.hausmann@nokia.com> |
+ |
+ Reviewed by Andreas Kling. |
+ |
+ Fix compilation of the V8 bindings on X11 with Qt. |
+ |
+ This changes brings the file in sync with its copy in bridge/, |
+ adding additional conflicting X11 keywords to undef. This is |
+ a temporary fix until the file is removed altogether, which is |
+ tracked in https://bugs.webkit.org/show_bug.cgi?id=45617 |
+ |
+ * bindings/v8/npruntime_internal.h: |
+ |
+2010-09-12 Simon Hausmann <simon.hausmann@nokia.com> |
+ |
+ Reviewed by Andreas Kling. |
+ |
+ Fix compilation of the V8 bindings on X11 with Qt. |
+ |
+ These headers include npruntime, which drag on X11Resources.h, which |
+ among other things #define's None and Boolean. Later on v8.h is included, |
+ which declares these in enums and therefore conflicts. npruntime_internal.h |
+ was introduced exactly to address this problem by including npruntime.h |
+ and undeff'ing the offending constants. |
+ |
+ * bindings/v8/V8Helpers.h: |
+ * bindings/v8/V8NPObject.h: |
+ * bindings/v8/V8NPUtils.h: |
+ |
+2010-09-12 Simon Hausmann <simon.hausmann@nokia.com> |
+ |
+ Gtk build fix. |
+ |
+ Use false instead of False after |
+ http://trac.webkit.org/changeset/67323 |
+ |
+ * plugins/gtk/PluginViewGtk.cpp: |
+ (WebCore::PluginView::updatePluginWidget): |
+ (WebCore::PluginView::paint): |
+ |
+2010-09-12 Simon Hausmann <simon.hausmann@nokia.com> |
+ |
+ Reviewed by Andreas Kling. |
+ |
+ [Qt] Fix the compilation of V8Binding.cpp when compiling with Qt. |
+ |
+ * bindings/v8/V8Binding.cpp: |
+ (WebCore::WebCoreStringResource::WebCoreStringResource): In this |
+ line an AtomicString should be converted to a WTF::String. The former |
+ has a conversion operator to the latter, to be able to call the |
+ WTF::String copy constructor. When compiling with Qt, then AtomicString |
+ also has a conversion operator to QString _and_ WTF::String has an |
+ implicit constructor that takes a QString. Therefore the compiler is |
+ confused and not sure which conversion to prefer, the one that isn't |
+ actually a conversion - going to WTF::String - or the conversion from |
+ AtomicString to QString and then constructing the WTF::String from |
+ a QString. To resolve this ambiguity we explicitly call the string() |
+ helper function on the AtomicString, which is equivalent to the |
+ operator WTF::String(). |
+ |
+2010-09-12 Simon Hausmann <simon.hausmann@nokia.com> |
+ |
+ Reviewed by Andreas Kling. |
+ |
+ Fix the build without JSC. |
+ |
+ Complement http://trac.webkit.org/changeset/59826 and |
+ add missing JSC guards. |
+ |
+ * plugins/PluginView.cpp: |
+ (WebCore::PluginView::bindingInstance): |
+ (WebCore::PluginView::privateBrowsingStateChanged): |
+ * plugins/qt/PluginViewQt.cpp: |
+ (WebCore::PluginView::dispatchNPEvent): |
+ (WebCore::PluginView::setNPWindowIfNeeded): |
+ (WebCore::PluginView::platformStart): |
+ |
+2010-09-12 Simon Hausmann <simon.hausmann@nokia.com> |
+ |
+ Reviewed by Andreas Kling. |
+ |
+ Fix compilation with V8 and XPath enabled. |
+ |
+ V8XPathNSResolver.cpp includes V8XPathNSResolver.h, |
+ which includes V8DOMWrapper.h as its first header. |
+ V8DOMWrapper.h then uses V8XPathNSResolver in an inline |
+ function, and gcc doesn't seem to like this, because |
+ at this point the type isn't known ("V8XPathNSResolver |
+ has not been declared"). Forward declaring the type |
+ doesn't help unfortunately: "incomplete type |
+ 'WebCore::V8XPathNSResolver' used in nested name |
+ specifier". |
+ |
+ To resolve this circular dependency, this patch moves |
+ the inline function into the .cpp file. |
+ |
+ * bindings/v8/V8DOMWrapper.cpp: |
+ (WebCore::V8DOMWrapper::getXPathNSResolver): |
+ * bindings/v8/V8DOMWrapper.h: |
+ |
+2010-09-12 Simon Hausmann <simon.hausmann@nokia.com> |
+ |
+ Reviewed by Andreas Kling. |
+ |
+ [Qt][X11] Fix build with V8 against X11 headers. |
+ |
+ Added "True" and "False" to the list of words |
+ we free from the X11 macro jail. |
+ |
+ * bridge/npruntime_internal.h: |
+ * config.h: The V8 bindings end up indirectly pulling |
+ in X11 headers and they use True/False. There's no |
+ central header apart from this one, so include the |
+ x11 fixing header here for Qt/X11/V8. |
+ * plugins/qt/PluginViewQt.cpp: |
+ (WebCore::PluginView::paint): Use false instead of False |
+ since False isn't available anymore. |
+ |
+2010-09-12 Simon Hausmann <simon.hausmann@nokia.com> |
+ |
+ Reviewed by Andreas Kling. |
+ |
+ [Qt] Fix compilation with V8 and Qt. |
+ |
+ Use WebKit's page cache for ScriptCachedFrameData. |
+ |
+ * bindings/v8/ScriptCachedFrameData.h: |
+ |
+2010-09-12 Simon Hausmann <simon.hausmann@nokia.com> |
+ |
+ Reviewed by Andreas Kling. |
+ |
+ Fix compiler warning. |
+ |
+ NPClass has 13 members, the last one (NPConstructFunctionPtr construct) wasn't |
+ initialized explicitly. |
+ |
+ * bindings/v8/NPV8Object.cpp: |
+ |
+2010-09-12 Mario Sanchez Prada <msanchez@igalia.com> |
+ |
+ Reviewed by Martin Robinson. |
+ |
+ [Gtk] get_n_selections and get_selection fail when selecting text across object boundaries |
+ https://bugs.webkit.org/show_bug.cgi?id=26991 |
+ |
+ Fix AtkText getNSelections() and getSelection() to work properly |
+ |
+ * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: |
+ (selectionBelongsToObject): Check that both the selection intersects |
+ the node AND that the selection is not just "touching" one of the |
+ boundaries for the selected node. We want to check whether the |
+ node is actually inside the region, at least partially |
+ (getSelectionOffsetsForObject): New function to get the start and |
+ end offsets of a selection for a given accessible object. |
+ (webkit_accessible_text_get_selection): Return zero when both |
+ start and end offsets are equal, following the lead of GAIL. |
+ |
+2010-09-11 Adam Barth <abarth@webkit.org> |
+ |
+ Reviewed by Sam Weinig. |
+ |
+ Make SecurityOrigin::canDisplay an instance function |
+ https://bugs.webkit.org/show_bug.cgi?id=45219 |
+ |
+ This function was secretly an instance function because callers needed |
+ to pass in a document (which owns a SecurityOrigin). Only the |
+ FrameLoader actually needs the method to be static. |
+ |
+ * WebCore.exp.in: |
+ * html/HTMLMediaElement.cpp: |
+ (WebCore::HTMLMediaElement::isSafeToLoadURL): |
+ * loader/Cache.cpp: |
+ (WebCore::Cache::requestResource): |
+ - Notice that DocLoader::doc() can never be 0. |
+ * loader/FrameLoader.cpp: |
+ (WebCore::FrameLoader::loadFrameRequest): |
+ * loader/PingLoader.cpp: |
+ (WebCore::PingLoader::loadImage): |
+ * loader/SubframeLoader.cpp: |
+ (WebCore::SubframeLoader::loadMediaPlayerProxyPlugin): |
+ (WebCore::SubframeLoader::createJavaAppletWidget): |
+ (WebCore::SubframeLoader::loadSubframe): |
+ (WebCore::SubframeLoader::loadPlugin): |
+ * loader/SubresourceLoader.cpp: |
+ (WebCore::SubresourceLoader::create): |
+ * page/SecurityOrigin.cpp: |
+ (WebCore::SecurityOrigin::canDisplay): |
+ (WebCore::SecurityOrigin::deprecatedCanDisplay): |
+ * page/SecurityOrigin.h: |
+ * plugins/PluginView.cpp: |
+ (WebCore::PluginView::load): |
+ |
+2010-09-11 Adam Barth <abarth@webkit.org> |
+ |
+ Reviewed by Sam Weinig. |
+ |
+ Make SecurityOrigin::canDisplay an instance function |
+ https://bugs.webkit.org/show_bug.cgi?id=45219 |
+ |
+ This function was secretly an instance function because callers needed |
+ to pass in a document (which owns a SecurityOrigin). Only the |
+ FrameLoader actually needs the method to be static. |
+ |
+ * WebCore.exp.in: |
+ * html/HTMLMediaElement.cpp: |
+ (WebCore::HTMLMediaElement::isSafeToLoadURL): |
+ * loader/Cache.cpp: |
+ (WebCore::Cache::requestResource): |
+ - Notice that DocLoader::doc() can never be 0. |
+ * loader/FrameLoader.cpp: |
+ (WebCore::FrameLoader::loadFrameRequest): |
+ * loader/PingLoader.cpp: |
+ (WebCore::PingLoader::loadImage): |
+ * loader/SubframeLoader.cpp: |
+ (WebCore::SubframeLoader::loadMediaPlayerProxyPlugin): |
+ (WebCore::SubframeLoader::createJavaAppletWidget): |
+ (WebCore::SubframeLoader::loadSubframe): |
+ (WebCore::SubframeLoader::loadPlugin): |
+ * loader/SubresourceLoader.cpp: |
+ (WebCore::SubresourceLoader::create): |
+ * page/SecurityOrigin.cpp: |
+ (WebCore::SecurityOrigin::canDisplay): |
+ (WebCore::SecurityOrigin::deprecatedCanDisplay): |
+ * page/SecurityOrigin.h: |
+ * plugins/PluginView.cpp: |
+ (WebCore::PluginView::load): |
+ |
+2010-09-11 Simon Hausmann <simon.hausmann@nokia.com> |
+ |
+ Unreviewed. |
+ |
+ [Qt] Trivial V8 build fix. |
+ |
+ * WebCore.pri: Add storage, workers and css to the include paths for the |
+ JS code generator. |
+ |
+2010-09-11 Andreas Kling <andreas.kling@nokia.com> |
+ |
+ Reviewed by Simon Hausmann. |
+ |
+ [Qt] V8 port: Fix "WTF::String::utf8" returns incomplete type WTF::CString |
+ https://bugs.webkit.org/show_bug.cgi?id=45157 |
+ |
+ Include CString.h where necessary. Chromium builds would get it from |
+ KURLGooglePrivate.h so this is only an issue for Qt + V8. |
+ |
+ * bindings/v8/V8Proxy.cpp: |
+ * inspector/InspectorDebuggerAgent.cpp: |
+ * inspector/InspectorProfilerAgent.cpp: |
+ * plugins/PluginDatabase.cpp: |
+ |
+2010-09-11 Simon Hausmann <simon.hausmann@nokia.com> |
+ |
+ Reviewed by Andreas Kling. |
+ |
+ [Qt] V8 port: webkit project files changes |
+ https://bugs.webkit.org/show_bug.cgi?id=45140 |
+ |
+ * WebCore.pro: Removed unecessary common.pri inclusion from earlier patch. |
+ |
+2010-09-03 Vlad Burlik <volodimir.burlik@nokia.com>, Simon Hausmann <simon.hausmann@nokia.com> |
+ |
+ Reviewed by Andreas Kling. |
+ |
+ [Qt] V8 port: webcore project files changes |
+ https://bugs.webkit.org/show_bug.cgi?id=45141 |
+ |
+ Modify webcore project files to include V8 javascript engine. By default disabled. |
+ |
+ * WebCore.pri: |
+ * WebCore.pro: |
+ * features.pri: |
+ |
+2010-09-11 Andreas Kling <andreas.kling@nokia.com> |
+ |
+ Reviewed by Simon Hausmann. |
+ |
+ Web Inspector: Include CString.h in generated files |
+ |
+ This is necessary for generated code that uses the CString |
+ returned by String::utf8() (from generateBackendDispatcher) |
+ |
+ Chromium builds already get CString.h from KURLGooglePrivate.h |
+ so this issue only occurs when building Qt against V8. |
+ |
+ * inspector/CodeGeneratorInspector.pm: |
+ |
+2010-09-11 Adele Peterson <adele@apple.com> |
+ |
+ Reviewed by Sam Weinig. |
+ |
+ Fix for https://bugs.webkit.org/show_bug.cgi?id=45587 |
+ Move line clamp code to its own function. |
+ |
+ * rendering/RenderFlexibleBox.cpp: |
+ (WebCore::RenderFlexibleBox::layoutVerticalBox): |
+ (WebCore::RenderFlexibleBox::applyLineClamp): |
+ * rendering/RenderFlexibleBox.h: |
+ |
2010-09-11 Mihai Parparita <mihaip@chromium.org> |
Reviewed by Adam Barth. |