Issue 339094: Set active_dialog_ before showing it, since showing a dialog can sometimes...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 339094: Set active_dialog_ before showing it, since showing a dialog can sometimes... (Closed)

Created:
11 years, 1 month ago by Pam (message me for reviews)

Modified:
9 years, 5 months ago

Reviewers:
jcampan

CC:
chromium-reviews_googlegroups.com, ben+cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Set active_dialog_ before showing it, since showing a dialog can sometimes actually move to the next one in the queue instead. BUG=26398 TEST=Make sure alert/confirm boxes work properly. Make sure a background tab that shows a (delayed) alert box works. Same with a background browser. Especially make sure http://crbug.com/10699 doesn't recur.

Patch Set 1 #

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -1 line)			Patch
	M	chrome/browser/app_modal_dialog_queue.cc	View		1 chunk	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Pam (message me for reviews)

I wasn't able to tell from the history of this file whether moving active_dialog_ after ...

11 years, 1 month ago (2009-10-31 02:48:19 UTC) #1

jcampan

11 years, 1 month ago (2009-11-02 19:51:15 UTC) #2

I sadly don't recall why I moved the setting of active_dialog_ after the
ShowModalDialog() call.
I guess my assumption was that the case mentioned in the old comment (one modal
dialog showing on top of another one) could not happen, but I can definitely see
that happening with delayed tasks.
Anyway, LGTM.

Expand Messages | Collapse Messages