Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Unified Diff: chrome/browser/app_modal_dialog_queue.cc

Issue 339094: Set active_dialog_ before showing it, since showing a dialog can sometimes... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 11 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/app_modal_dialog_queue.cc
===================================================================
--- chrome/browser/app_modal_dialog_queue.cc (revision 30367)
+++ chrome/browser/app_modal_dialog_queue.cc (working copy)
@@ -30,6 +30,8 @@
}
void AppModalDialogQueue::ShowModalDialog(AppModalDialog* dialog) {
+ // Set active_dialog_ before showing it, because ShowModalDialog can wind up
+ // calling ShowNextDialog in some cases, which will change active_dialog_.
+ active_dialog_ = dialog;
dialog->ShowModalDialog();
- active_dialog_ = dialog;
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698