Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(501)

Issue 339071: If we remove a search engine from our prepopulate data, remove it from the us... (Closed)

Created:
11 years, 1 month ago by Peter Kasting
Modified:
9 years, 7 months ago
Reviewers:
sky
CC:
chromium-reviews_googlegroups.com, ben+cc_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

If we remove a search engine from our prepopulate data, remove it from the user's list too if they haven't edited it or made it default. BUG=none TEST=Covered by unittest Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30508

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -10 lines) Patch
M chrome/browser/search_engines/template_url_model.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/search_engines/template_url_model.cc View 3 chunks +28 lines, -10 lines 0 comments Download
M chrome/browser/search_engines/template_url_model_unittest.cc View 1 1 chunk +48 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Peter Kasting
11 years, 1 month ago (2009-10-29 19:23:27 UTC) #1
sky
http://codereview.chromium.org/339071/diff/1/3 File chrome/browser/search_engines/template_url_model.cc (right): http://codereview.chromium.org/339071/diff/1/3#newcode770 Line 770: Remove(template_url); I believe this is going to remove ...
11 years, 1 month ago (2009-10-29 19:46:36 UTC) #2
Peter Kasting
http://codereview.chromium.org/339071/diff/1/3 File chrome/browser/search_engines/template_url_model.cc (right): http://codereview.chromium.org/339071/diff/1/3#newcode770 Line 770: Remove(template_url); On 2009/10/29 19:46:36, sky wrote: > I ...
11 years, 1 month ago (2009-10-29 20:30:30 UTC) #3
sky
11 years, 1 month ago (2009-10-29 20:33:49 UTC) #4
My mistake. LGTM

Powered by Google App Engine
This is Rietveld 408576698