If we remove a search engine from our prepopulate data, remove it from the us...

chrome/browser/search_engines/template_url_model.cc

 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/search_engines/template_url_model.h"
 
 
 #include "app/l10n_util.h"
 #include "base/stl_util-inl.h"
 #include "base/utf_string_conversions.h"
@@ skipping 692 matching lines @@
 
 void TemplateURLModel::NotifyLoaded() {
   NotificationService::current()->Notify(
       NotificationType::TEMPLATE_URL_MODEL_LOADED,
       Source<TemplateURLModel>(this),
       NotificationService::NoDetails());
 }
 
 void TemplateURLModel::MergeEnginesFromPrepopulateData() {
   // Build a map from prepopulate id to TemplateURL of existing urls.
-  std::map<int, const TemplateURL*> id_to_turl;
-  for (size_t i = 0; i < template_urls_.size(); ++i) {
-    if (template_urls_[i]->prepopulate_id() > 0)
-      id_to_turl[template_urls_[i]->prepopulate_id()] = template_urls_[i];
+  typedef std::map<int, const TemplateURL*> IDMap;
+  IDMap id_to_turl;
+  for (TemplateURLVector::const_iterator i(template_urls_.begin());
+       i != template_urls_.end(); ++i) {
+    int prepopulate_id = (*i)->prepopulate_id();
+    if (prepopulate_id > 0)
+      id_to_turl[prepopulate_id] = *i;
   }
 
   std::vector<TemplateURL*> loaded_urls;
   size_t default_search_index;
   TemplateURLPrepopulateData::GetPrepopulatedEngines(GetPrefs(),
                                                      &loaded_urls,
                                                      &default_search_index);
 
+  std::set<int> updated_ids;
   for (size_t i = 0; i < loaded_urls.size(); ++i) {
     scoped_ptr<TemplateURL> t_url(loaded_urls[i]);
-
-    if (!t_url->prepopulate_id()) {
-      // Prepopulate engines need an id.
+    int t_url_id = t_url->prepopulate_id();
+    if (!t_url_id || updated_ids.count(t_url_id)) {
+      // Prepopulate engines need a unique id.
       NOTREACHED();
       continue;
     }
 
-    const TemplateURL* existing_url = id_to_turl[t_url->prepopulate_id()];
-    if (existing_url) {
+    IDMap::iterator existing_url_iter(id_to_turl.find(t_url_id));
+    if (existing_url_iter != id_to_turl.end()) {
+      const TemplateURL* existing_url = existing_url_iter->second;
       if (!existing_url->safe_for_autoreplace()) {
         // User edited the entry, preserve the keyword and description.
         loaded_urls[i]->set_safe_for_autoreplace(false);
         loaded_urls[i]->set_keyword(existing_url->keyword());
         loaded_urls[i]->set_autogenerate_keyword(
             existing_url->autogenerate_keyword());
         loaded_urls[i]->set_short_name(existing_url->short_name());
       }
       Replace(existing_url, loaded_urls[i]);
-      id_to_turl[t_url->prepopulate_id()] = loaded_urls[i];
+      id_to_turl.erase(existing_url_iter);
     } else {
       Add(loaded_urls[i]);
     }
     if (i == default_search_index && !default_search_provider_)
       SetDefaultSearchProvider(loaded_urls[i]);
 
+    updated_ids.insert(t_url_id);
     t_url.release();
   }
+
+  // Remove any prepopulated engines which are no longer in the master list, as
+  // long as the user hasn't modified them or made them the default engine.
+  for (IDMap::iterator i(id_to_turl.begin()); i != id_to_turl.end(); ++i) {
+    const TemplateURL* template_url = i->second;
+    // We use default_search_provider_ instead of GetDefaultSearchProvider()
+    // because we're running before |loaded_| is set, and calling
+    // GetDefaultSearchProvider() will erroneously try to read the prefs.
+    if ((template_url->safe_for_autoreplace()) &&
+        (template_url != default_search_provider_))
+      Remove(template_url);
+  }
 }
 
 void TemplateURLModel::SaveDefaultSearchProviderToPrefs(
     const TemplateURL* t_url) {
   PrefService* prefs = GetPrefs();
   if (!prefs)
     return;
 
   RegisterPrefs(prefs);
 
@@ skipping 230 matching lines @@
       AddToMaps(t_url);
       something_changed = true;
     }
   }
 
   if (something_changed && loaded_) {
     FOR_EACH_OBSERVER(TemplateURLModelObserver, model_observers_,
                       OnTemplateURLModelChanged());
   }
 }