Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(743)

Unified Diff: chrome/browser/safe_browsing/safe_browsing_database_unittest.cc

Issue 339059: Add compiler-specific "examine printf format" attributes to printfs. (Closed)
Patch Set: cleanups Created 11 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/safe_browsing/safe_browsing_database_unittest.cc
diff --git a/chrome/browser/safe_browsing/safe_browsing_database_unittest.cc b/chrome/browser/safe_browsing/safe_browsing_database_unittest.cc
index 0e411338f14ad51105cfed71116ab3b5f973ee3f..e73eb4c061fba03bed4f0b065c65649bd08d3ea4 100644
--- a/chrome/browser/safe_browsing/safe_browsing_database_unittest.cc
+++ b/chrome/browser/safe_browsing/safe_browsing_database_unittest.cc
@@ -5,6 +5,7 @@
// Unit tests for the SafeBrowsing storage system.
#include "base/file_util.h"
+#include "base/format_macros.h"
#include "base/logging.h"
#include "base/path_service.h"
#include "base/process_util.h"
@@ -1058,8 +1059,6 @@ struct ChunksInfo {
void PeformUpdate(const std::wstring& initial_db,
const std::vector<ChunksInfo>& chunks,
std::vector<SBChunkDelete>* deletes) {
-// TODO(pinkerton): I don't think posix has any concept of IO counters, but
-// we can uncomment this when we implement ProcessMetrics::GetIOCounters
IoCounters before, after;
FilePath path;
@@ -1096,15 +1095,15 @@ void PeformUpdate(const std::wstring& initial_db,
CHECK(metric->GetIOCounters(&after));
- LOG(INFO) << StringPrintf("I/O Read Bytes: %d",
+ LOG(INFO) << StringPrintf("I/O Read Bytes: %"PRIu64,
Mark Mentovai 2009/11/18 20:55:27 "I/O Read Bytes: %" PRIu64, (with the space)
after.ReadTransferCount - before.ReadTransferCount);
- LOG(INFO) << StringPrintf("I/O Write Bytes: %d",
+ LOG(INFO) << StringPrintf("I/O Write Bytes: %"PRIu64,
after.WriteTransferCount - before.WriteTransferCount);
- LOG(INFO) << StringPrintf("I/O Reads: %d",
+ LOG(INFO) << StringPrintf("I/O Reads: %"PRIu64,
after.ReadOperationCount - before.ReadOperationCount);
- LOG(INFO) << StringPrintf("I/O Writes: %d",
+ LOG(INFO) << StringPrintf("I/O Writes: %"PRIu64,
after.WriteOperationCount - before.WriteOperationCount);
- LOG(INFO) << StringPrintf("Finished in %d ms",
+ LOG(INFO) << StringPrintf("Finished in %"PRId64" ms",
(Time::Now() - before_time).InMilliseconds());
PrintStat("c:SB.HostSelect");

Powered by Google App Engine
This is Rietveld 408576698