Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1114)

Unified Diff: chrome/app/chrome_dll_main.cc

Issue 339059: Add compiler-specific "examine printf format" attributes to printfs. (Closed)
Patch Set: cleanups Created 11 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/app/chrome_dll_main.cc
diff --git a/chrome/app/chrome_dll_main.cc b/chrome/app/chrome_dll_main.cc
index c075d88eff1165890a92766b1299e6037039b404..124ff9356d9b279f3ae7dbdd1789d15c41435b4c 100644
--- a/chrome/app/chrome_dll_main.cc
+++ b/chrome/app/chrome_dll_main.cc
@@ -460,8 +460,8 @@ int ChromeMain(int argc, char** argv) {
// leaking shared memory regions on posix platforms.
if (parsed_command_line.HasSwitch(switches::kEnableStatsTable) ||
parsed_command_line.HasSwitch(switches::kEnableBenchmarking)) {
- std::string statsfile = StringPrintf("%s-%lld", chrome::kStatsFilename,
- static_cast<int64>(browser_pid));
+ std::string statsfile = StringPrintf("%s-%ul", chrome::kStatsFilename,
Mark Mentovai 2009/11/18 20:55:27 The cast is to unsigned int but you've got %ul. E
+ static_cast<unsigned int>(browser_pid));
StatsTable *stats_table = new StatsTable(statsfile,
chrome::kStatsMaxThreads, chrome::kStatsMaxCounters);
StatsTable::set_current(stats_table);

Powered by Google App Engine
This is Rietveld 408576698