Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Unified Diff: src/compiler.cc

Issue 339045: Rename the kinds of locations to be consistent with the (codegen)... (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: Created 11 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/ast.h ('k') | src/fast-codegen.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler.cc
===================================================================
--- src/compiler.cc (revision 3167)
+++ src/compiler.cc (working copy)
@@ -48,7 +48,7 @@
CodeGenSelector()
: has_supported_syntax_(true),
- location_(Location::Nowhere()) {
+ location_(Location::Uninitialized()) {
}
CodeGenTag Select(FunctionLiteral* fun);
@@ -514,11 +514,11 @@
void CodeGenSelector::VisitAsEffect(Expression* expr) {
- if (location_.is_nowhere()) {
+ if (location_.is_effect()) {
Visit(expr);
} else {
Location saved = location_;
- location_ = Location::Nowhere();
+ location_ = Location::Effect();
Visit(expr);
location_ = saved;
}
@@ -526,11 +526,11 @@
void CodeGenSelector::VisitAsValue(Expression* expr) {
- if (location_.is_temporary()) {
+ if (location_.is_value()) {
Visit(expr);
} else {
Location saved = location_;
- location_ = Location::Temporary();
+ location_ = Location::Value();
Visit(expr);
location_ = saved;
}
« no previous file with comments | « src/ast.h ('k') | src/fast-codegen.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698