Issue 339040: pull newer gyp for make fixes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 339040: pull newer gyp for make fixes (Closed)

Created:
11 years, 1 month ago by piman

Modified:
9 years, 7 months ago

Reviewers:
Mark Mentovai, Michael Moss

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

pull newer gyp for make fixes Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30376

Patch Set 1 #

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	DEPS	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Mark Mentovai

11 years, 1 month ago (2009-10-28 18:08:50 UTC) #2

LGTM.  =E7=8E=8B=E9=87=8D=E5=82=91 has a change in there too.  Make sure th=
at the GYP canaries
are green before committing.

Mark

piman@chromium.org wrote:
> Reviewers: Mark Mentovai, Michael Moss,
>
> Description:
> pull newer gyp for make fixes
>
> Please review this at http://codereview.chromium.org/339040
>
> Affected files:
> =C2=A0M DEPS
>
>
> Index: DEPS
> diff --git a/DEPS b/DEPS
> index
> 04f07c2ccf09b26ce5e9a12a79c547d398f23765..78333553631a915b0e17ed0a3c86659=
8e23d8070
> 100644
> --- a/DEPS
> +++ b/DEPS
> @@ -37,7 +37,7 @@ deps =3D {
> =C2=A0 =C2=A0 "http://pywebsocket.googlecode.com/svn/trunk/src@86",
>
> =C2=A0 "src/tools/gyp":
> - =C2=A0 =C2=A0"http://gyp.googlecode.com/svn/trunk@724",
> + =C2=A0 =C2=A0"http://gyp.googlecode.com/svn/trunk@730",
>
> =C2=A0 "src/v8":
> =C2=A0 =C2=A0 "http://v8.googlecode.com/svn/trunk@3121",
>
>
>

Expand Messages | Collapse Messages