Chromium Code Reviews

Issue 339030: Add initial implementation of AutoFill++. This implementation is hidden behi... (Closed)

Created:
11 years, 1 month ago by James Hawkins
Modified:
9 years, 7 months ago
Reviewers:
Ben Goodger (Google)
CC:
chromium-reviews_googlegroups.com, brettw+cc_chromium.org, darin (slow to review), jam, ben+cc_chromium.org
Visibility:
Public.

Description

Add initial implementation of AutoFill++. This implementation is hidden behind a switch, --enable-new-autofill. So far, we only pop up an infobar asking the user if he'd like to save the form information. I've added a rudimentary icon for the infobar, pulled from the mocks, so we'll probably want a blessed version of this icon at some point. BUG=18201 TEST=none

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Stats (+265 lines, -2 lines)
M chrome/app/chromium_strings.grd View 1 chunk +3 lines, -0 lines 0 comments
M chrome/app/generated_resources.grd View 1 chunk +6 lines, -0 lines 0 comments
M chrome/app/google_chrome_strings.grd View 1 chunk +3 lines, -0 lines 0 comments
A chrome/app/theme/infobar_autofill.png View Binary file 0 comments
M chrome/app/theme/theme_resources.grd View 1 chunk +1 line, -0 lines 0 comments
A chrome/browser/autofill/autofill_infobar_delegate.h View 1 chunk +42 lines, -0 lines 0 comments
A chrome/browser/autofill/autofill_infobar_delegate.cc View 1 1 chunk +76 lines, -0 lines 0 comments
A chrome/browser/autofill/autofill_manager.h View 1 chunk +48 lines, -0 lines 0 comments
A chrome/browser/autofill/autofill_manager.cc View 1 chunk +41 lines, -0 lines 0 comments
M chrome/browser/renderer_host/render_view_host.cc View 1 chunk +5 lines, -0 lines 0 comments
M chrome/browser/renderer_host/render_view_host_delegate.h View 2 chunks +11 lines, -0 lines 0 comments
M chrome/browser/renderer_host/render_view_host_delegate.cc View 1 chunk +5 lines, -0 lines 0 comments
M chrome/browser/tab_contents/tab_contents.h View 4 chunks +7 lines, -2 lines 0 comments
M chrome/browser/tab_contents/tab_contents.cc View 3 chunks +8 lines, -0 lines 0 comments
M chrome/chrome.gyp View 1 chunk +4 lines, -0 lines 0 comments
M chrome/common/chrome_switches.h View 1 chunk +2 lines, -0 lines 0 comments
M chrome/common/chrome_switches.cc View 1 chunk +3 lines, -0 lines 0 comments

Messages

Total messages: 6 (0 generated)
James Hawkins
11 years, 1 month ago (2009-10-27 21:50:29 UTC) #1
James Hawkins
ping
11 years, 1 month ago (2009-10-28 18:30:22 UTC) #2
Ben Goodger (Google)
Yes looking. On Wed, Oct 28, 2009 at 11:30 AM, <jhawkins@chromium.org> wrote: > ping > ...
11 years, 1 month ago (2009-10-28 18:52:05 UTC) #3
Ben Goodger (Google)
LGTM
11 years, 1 month ago (2009-10-28 18:52:11 UTC) #4
James Hawkins
On 2009/10/28 18:52:11, Ben Goodger wrote: > LGTM Thanks! I'm going to upload the patch ...
11 years, 1 month ago (2009-10-28 18:53:09 UTC) #5
Ben Goodger (Google)
11 years, 1 month ago (2009-10-28 18:56:49 UTC) #6
SGTM

On Wed, Oct 28, 2009 at 11:53 AM, <jhawkins@chromium.org> wrote:

> On 2009/10/28 18:52:11, Ben Goodger wrote:
>
>> LGTM
>>
>
> Thanks!  I'm going to upload the patch set again with an already-existing
> .png
> for the infobar icon to make sure everything passes.  Then I'll commit.
>
>
> http://codereview.chromium.org/339030
>

Powered by Google App Engine