Issue 339017: Loosen RFC 1738 compliance check to allow underscores where we already allowe...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 339017: Loosen RFC 1738 compliance check to allow underscores where we already allowe... (Closed)

Created:
11 years, 1 month ago by Peter Kasting

Modified:
9 years, 7 months ago

Reviewers:
brettw

CC:
chromium-reviews_googlegroups.com, darin (slow to review), ben+cc_chromium.org, Paweł Hajdan Jr.

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Loosen RFC 1738 compliance check to allow underscores where we already allowed hyphens, to match real-world needs. I don't believe further loosening will be required but that data will hopefully be coming soon. In the meantime people are asking for this fix. BUG=25714 TEST=Entring "a_b.com" in the omnibox should default to navigate, not search Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30245

Patch Set 1 #

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+26 lines, -22 lines)			Patch
M	chrome/browser/autocomplete/autocomplete.cc	View	1 chunk	+5 lines, -5 lines	0 comments	Download
M	chrome/browser/autocomplete/autocomplete_unittest.cc	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	net/base/net_util.h	View	1 chunk	+5 lines, -4 lines	0 comments	Download
M	net/base/net_util.cc	View	3 chunks	+6 lines, -6 lines	0 comments	Download
M	net/base/net_util_unittest.cc	View	3 chunks	+8 lines, -7 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages