Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(319)

Unified Diff: chrome/browser/autocomplete/autocomplete.cc

Issue 339017: Loosen RFC 1738 compliance check to allow underscores where we already allowe... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 11 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/autocomplete/autocomplete_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/autocomplete/autocomplete.cc
===================================================================
--- chrome/browser/autocomplete/autocomplete.cc (revision 29940)
+++ chrome/browser/autocomplete/autocomplete.cc (working copy)
@@ -175,14 +175,14 @@
if (registry_length == std::wstring::npos)
return QUERY; // Could be a broken IP address, etc.
- // See if the hostname is valid per RFC 1738. While IE and GURL allow
- // hostnames to contain many other characters (perhaps for weird intranet
- // machines), it's extremely unlikely that a user would be trying to type
- // those in for anything other than a search query.
+ // See if the hostname is valid. While IE and GURL allow hostnames to contain
+ // many other characters (perhaps for weird intranet machines), it's extremely
+ // unlikely that a user would be trying to type those in for anything other
+ // than a search query.
url_canon::CanonHostInfo host_info;
const std::string canonicalized_host(net::CanonicalizeHost(host, &host_info));
if ((host_info.family == url_canon::CanonHostInfo::NEUTRAL) &&
- !net::IsCanonicalizedHostRFC1738Compliant(canonicalized_host))
+ !net::IsCanonicalizedHostCompliant(canonicalized_host))
return QUERY;
// Presence of a port means this is likely a URL, if the port is really a port
« no previous file with comments | « no previous file | chrome/browser/autocomplete/autocomplete_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698