Issue 339012: Report "N/A" for memory columns in Linux Task Manager.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 339012: Report "N/A" for memory columns in Linux Task Manager. (Closed)

Created:
11 years, 1 month ago by vandebo (ex-Chrome)

Modified:
9 years, 7 months ago

Reviewers:
James Hawkins

CC:
chromium-reviews_googlegroups.com, ben+cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Make the memory resource functions return bools so that we know when the information is not available. Refactor TaskManager slightly. BUG=23366 TEST=See "N/A" for memory usage in Linux task manager Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30148

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : Also fix minor bug in linux PorcessMetrics #

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+83 lines, -76 lines)			Patch
M	base/process_util_linux.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/task_manager.h	View		1 chunk	+13 lines, -15 lines	0 comments	Download
M	chrome/browser/task_manager.cc	View	1	4 chunks	+69 lines, -60 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages