base/process_util_linux.cc - Issue 339012: Report "N/A" for memory columns in Linux Task Manager.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/process_util_linux.cc

Issue 339012: Report "N/A" for memory columns in Linux Task Manager. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: Also fix minor bug in linux PorcessMetrics Created 11 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/process_util_linux.cc

===================================================================

--- base/process_util_linux.cc (revision 30080)

+++ base/process_util_linux.cc (working copy)

@@ -262,7 +262,7 @@

int private_kb = 0;

int pss_kb = 0;

bool have_pss = false;

- if (!file_util::ReadFileToString(stat_file, &smaps))

+ if (!file_util::ReadFileToString(stat_file, &smaps) || smaps.length() == 0)

return false;

StringTokenizer tokenizer(smaps, ":\n");

« no previous file with comments | « no previous file | chrome/browser/task_manager.h » ('j') | no next file with comments »