Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(239)

Issue 339010: Make the About box display existing pending operations instead of firing off a new update check (Closed)

Created:
11 years, 1 month ago by Mark Mentovai
Modified:
9 years, 7 months ago
Reviewers:
TVL
CC:
chromium-reviews_googlegroups.com, John Grabowski, pam+watch_chromium.org, ben+cc_chromium.org
Visibility:
Public.

Description

Make the About box display existing pending operations instead of firing off a new update check even when an existing update check or installation attempt is in progress. Remove the check that validates that the Update button is disabled after being clicked. This test has become very fragile now that the Update button reliably enables itself as soon as an update installation attempt fails. BUG=13165 TEST=Get the About box to offer you the opportunity to install an update. Click "Install Now". Close the About box and quickly reopen it. The update status should be "Installing new version..." and not "Checking for updates..." Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30100

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Total comments: 1

Patch Set 5 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+89 lines, -35 lines) Patch
M chrome/app/keystone_glue.h View 1 2 3 3 chunks +15 lines, -3 lines 0 comments Download
M chrome/app/keystone_glue.mm View 1 2 3 chunks +19 lines, -0 lines 0 comments Download
M chrome/browser/cocoa/about_window_controller.mm View 1 2 3 4 7 chunks +55 lines, -28 lines 0 comments Download
M chrome/browser/cocoa/about_window_controller_unittest.mm View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Mark Mentovai
11 years, 1 month ago (2009-10-26 21:11:50 UTC) #1
TVL
11 years, 1 month ago (2009-10-26 21:23:55 UTC) #2
lgtm

http://codereview.chromium.org/339010/diff/6002/6005
File chrome/browser/cocoa/about_window_controller.mm (right):

http://codereview.chromium.org/339010/diff/6002/6005#newcode334
Line 334: [self setUpdateImage:imageID message:message];
dcheck imageID != 0?

Powered by Google App Engine
This is Rietveld 408576698