Make the About box display existing pending operations instead of firing off a new update check

chrome/app/keystone_glue.mm

 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "chrome/app/keystone_glue.h"
 
 #include "base/logging.h"
 #include "base/mac_util.h"
 #import "base/worker_pool_mac.h"
 #include "chrome/common/chrome_constants.h"
@@ skipping 223 matching lines @@
 - (void)stopTimer {
   [timer_ invalidate];
 }
 
 - (void)markActive:(NSTimer*)timer {
   KSRegistration* ksr = [timer userInfo];
   [ksr setActive];
 }
 
 - (void)checkForUpdate {
+  DCHECK(![self asyncOperationPending]);
+
   if (!registration_) {
     [self updateStatus:kAutoupdateCheckFailed version:nil];
     return;
   }
 
+  [self updateStatus:kAutoupdateChecking version:nil];
+
   [registration_ checkForUpdate];
 
   // Upon completion, KSRegistrationCheckForUpdateNotification will be posted,
   // and -checkForUpdateComplete: will be called.
 }
 
 - (void)checkForUpdateComplete:(NSNotification*)notification {
   NSDictionary* userInfo = [notification userInfo];
   BOOL updatesAvailable =
       [[userInfo objectForKey:KSRegistrationStatusKey] boolValue];
 
   if (updatesAvailable) {
     // If an update is known to be available, go straight to
     // -updateStatus:version:.  It doesn't matter what's currently on disk.
     NSString* version = [userInfo objectForKey:KSRegistrationVersionKey];
     [self updateStatus:kAutoupdateAvailable version:version];
   } else {
     // If no updates are available, check what's on disk, because an update
     // may have already been installed.  This check happens on another thread,
     // and -updateStatus:version: will be called on the main thread when done.
     [self determineUpdateStatusAsync];
   }
 }
 
 - (void)installUpdate {
+  DCHECK(![self asyncOperationPending]);
+
   if (!registration_) {
     [self updateStatus:kAutoupdateInstallFailed version:nil];
     return;
   }
 
+  [self updateStatus:kAutoupdateInstalling version:nil];
+
   [registration_ startUpdate];
 
   // Upon completion, KSRegistrationStartUpdateNotification will be posted,
   // and -installUpdateComplete: will be called.
 }
 
 - (void)installUpdateComplete:(NSNotification*)notification {
   NSDictionary* userInfo = [notification userInfo];
   BOOL checkSuccessful =
       [[userInfo objectForKey:KSUpdateCheckSuccessfulKey] boolValue];
@@ skipping 95 matching lines @@
 }
 
 - (NSNotification*)recentNotification {
   return [[recentNotification_ retain] autorelease];
 }
 
 - (void)clearRecentNotification {
   recentNotification_.reset(nil);
 }
 
+- (AutoupdateStatus)recentStatus {
+  NSDictionary* dictionary = [recentNotification_ userInfo];
+  return static_cast<AutoupdateStatus>(
+      [[dictionary objectForKey:kAutoupdateStatusStatus] intValue]);
+}
+
+- (BOOL)asyncOperationPending {
+  AutoupdateStatus status = [self recentStatus];
+  return status == kAutoupdateChecking || status == kAutoupdateInstalling;
+}
+
 @end  // @implementation KeystoneGlue