Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(393)

Issue 339008: Suppress a data race on vfptr in ipc/ipc_sync_channel_unittest.cc... (Closed)

Created:
11 years, 1 month ago by Timur Iskhodzhanov
Modified:
9 years, 6 months ago
CC:
chromium-reviews_googlegroups.com, not_the_right_glider, Nirnimesh, jam, stuartmorgan, pam+watch_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

Suppress a data race on vfptr in ipc/ipc_sync_channel_unittest.cc This race was already suppressed, but the existing suppression doesn't work if the order of accesses is different. We can prepare a suppression to make TSAN bots silent but it will be way too wide. I think adding one line of annotation with comment (twice) is better in terms of precision. BUG=25841 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30181

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -12 lines) Patch
M ipc/ipc_sync_channel_unittest.cc View 1 2 3 chunks +15 lines, -2 lines 0 comments Download
M tools/valgrind/tsan/suppressions.txt View 1 2 3 1 chunk +0 lines, -10 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Timur Iskhodzhanov
11 years, 1 month ago (2009-10-26 19:53:36 UTC) #1
dank
LGTM. (Do you really need both kinds of suppression for this?)
11 years, 1 month ago (2009-10-26 20:06:47 UTC) #2
Timur Iskhodzhanov
On 2009/10/26 20:06:47, dank wrote: > LGTM. (Do you really need both kinds of suppression ...
11 years, 1 month ago (2009-10-26 20:13:12 UTC) #3
Timur Iskhodzhanov
11 years, 1 month ago (2009-10-27 11:28:30 UTC) #4
Looks like you're right, the suppression is not needed if the annotation is
present. I'll remove it.
Thanks!

Powered by Google App Engine
This is Rietveld 408576698