Suppress a data race on vfptr in ipc/ipc_sync_channel_unittest.cc...

ipc/ipc_sync_channel_unittest.cc

 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
 // Unit test for SyncChannel.
 
 #include <string>
 #include <vector>
 
 #include "base/basictypes.h"
+#include "base/dynamic_annotations.h"
 #include "base/logging.h"
 #include "base/message_loop.h"
 #include "base/platform_thread.h"
 #include "base/stl_util-inl.h"
 #include "base/string_util.h"
 #include "base/thread.h"
 #include "base/waitable_event.h"
 #include "ipc/ipc_message.h"
 #include "ipc/ipc_sync_channel.h"
 #include "testing/gtest/include/gtest/gtest.h"
@@ skipping 11 matching lines @@
 class Worker : public Channel::Listener, public Message::Sender {
  public:
   // Will create a channel without a name.
   Worker(Channel::Mode mode, const std::string& thread_name)
       : done_(new WaitableEvent(false, false)),
         channel_created_(new WaitableEvent(false, false)),
         mode_(mode),
         ipc_thread_((thread_name + "_ipc").c_str()),
         listener_thread_((thread_name + "_listener").c_str()),
         overrided_thread_(NULL),
-        shutdown_event_(true, false) { }
+        shutdown_event_(true, false) {
+    // The data race on vfptr is real but is very hard
+    // to suppress using standard Valgrind mechanism (suppressions).
+    // We have to use ANNOTATE_BENIGN_RACE to hide the reports and
+    // make ThreadSanitizer bots green.
+    ANNOTATE_BENIGN_RACE(this, "Race on vfptr, http://crbug.com/25841");
+  }
 
   // Will create a named channel and use this name for the threads' name.
   Worker(const std::string& channel_name, Channel::Mode mode)
       : done_(new WaitableEvent(false, false)),
         channel_created_(new WaitableEvent(false, false)),
         channel_name_(channel_name),
         mode_(mode),
         ipc_thread_((channel_name + "_ipc").c_str()),
         listener_thread_((channel_name + "_listener").c_str()),
         overrided_thread_(NULL),
-        shutdown_event_(true, false) { }
+        shutdown_event_(true, false) {
+    // The data race on vfptr is real but is very hard
+    // to suppress using standard Valgrind mechanism (suppressions).
+    // We have to use ANNOTATE_BENIGN_RACE to hide the reports and
+    // make ThreadSanitizer bots green.
+    ANNOTATE_BENIGN_RACE(this, "Race on vfptr, http://crbug.com/25841");
+  }
 
   // The IPC thread needs to outlive SyncChannel, so force the correct order of
   // destruction.
   virtual ~Worker() {
     WaitableEvent listener_done(false, false), ipc_done(false, false);
     ListenerThread()->message_loop()->PostTask(FROM_HERE, NewRunnableMethod(
         this, &Worker::OnListenerThreadShutdown1, &listener_done,
         &ipc_done));
     listener_done.Wait();
     ipc_done.Wait();
@@ skipping 944 matching lines @@
 
 // Tests http://b/1474092 - that if after the done_event is set but before
 // OnObjectSignaled is called another message is sent out, then after its
 // reply comes back OnObjectSignaled will be called for the first message.
 TEST_F(IPCSyncChannelTest, DoneEventRace) {
   std::vector<Worker*> workers;
   workers.push_back(new DoneEventRaceServer());
   workers.push_back(new SimpleClient());
   RunTest(workers);
 }