Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issue 3389023: Fix lost suppressions with --tool=tsan_rv and refactor chrome_tests/valgrind_... (Closed)

Created:
10 years, 3 months ago by Timur Iskhodzhanov
Modified:
9 years, 6 months ago
CC:
chromium-reviews, Timur Iskhodzhanov, Alexander Potapenko, pam+watch_chromium.org, stuartmorgan+watch_chromium.org
Visibility:
Public.

Description

Fix lost suppressions with --tool=tsan_rv and refactor chrome_tests/valgrind_test.py a bit The patch was prepared by Eugeniy Stepanov (eugenis@) and orignally reviewed as http://codereview.chromium.org/3436022 TBR=glider TEST=./tools/valgrind/chrome_tests.sh -t <test> [--tool={tsan,tsan_rv,memcheck}] ... Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=60163

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -43 lines) Patch
M tools/valgrind/chrome_tests.py View 10 chunks +15 lines, -15 lines 0 comments Download
M tools/valgrind/valgrind_test.py View 4 chunks +21 lines, -28 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Timur Iskhodzhanov
10 years, 3 months ago (2010-09-22 09:52:33 UTC) #1
Timur Iskhodzhanov
10 years, 3 months ago (2010-09-22 09:53:29 UTC) #2
Evgeniy Stepanov
10 years, 3 months ago (2010-09-22 09:55:04 UTC) #3
LGTM

Powered by Google App Engine
This is Rietveld 408576698