Issue 3436022: Fix lost suppressions with --tool=tsan_rv.

Created:
10 years, 3 months ago by Evgeniy Stepanov

Modified:
10 years, 3 months ago

Reviewers:
Timur Iskhodzhanov

CC:
chromium-reviews, Timur Iskhodzhanov, Alexander Potapenko, pam+watch_chromium.org, stuartmorgan+watch_chromium.org

Base URL:
http://src.chromium.org/svn/trunk/src/

Visibility:
Public.

Description

Fix lost suppressions with --tool=tsan_rv.

Patch Set 6 : '' #

Created: 10 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+36 lines, -43 lines)			Patch
	M	tools/valgrind/chrome_tests.py	View	1 2 3 4	10 chunks	+15 lines, -15 lines	0 comments	Download
	M	tools/valgrind/valgrind_test.py	View	3 4 5	4 chunks	+21 lines, -28 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Timur Iskhodzhanov

http://codereview.chromium.org/3436022/diff/5001/6001 File tools/valgrind/chrome_tests.py (right): http://codereview.chromium.org/3436022/diff/5001/6001#newcode206 tools/valgrind/chrome_tests.py:206: tool = valgrind_test.ToolFactory().Create(self._options.valgrind_tool) valgrind_test.CreateTool(...) ? http://codereview.chromium.org/3436022/diff/5001/6001#newcode220 tools/valgrind/chrome_tests.py:220: return valgrind_test.RunTool(tool, ...

10 years, 3 months ago (2010-09-21 14:44:30 UTC) #2

Evgeniy Stepanov

http://codereview.chromium.org/3436022/diff/5001/6001 File tools/valgrind/chrome_tests.py (right): http://codereview.chromium.org/3436022/diff/5001/6001#newcode206 tools/valgrind/chrome_tests.py:206: tool = valgrind_test.ToolFactory().Create(self._options.valgrind_tool) On 2010/09/21 14:44:30, Timur Iskhodzhanov wrote: ...

10 years, 3 months ago (2010-09-21 15:02:52 UTC) #3

Timur Iskhodzhanov

http://codereview.chromium.org/3436022/diff/13001/14002 File tools/valgrind/valgrind_test.py (right): http://codereview.chromium.org/3436022/diff/13001/14002#newcode905 tools/valgrind/valgrind_test.py:905: def Run(self, args, module): remove Run(), rename "Main" to ...

10 years, 3 months ago (2010-09-22 09:42:47 UTC) #4

LGTM

Expand Messages | Collapse Messages