Issue 3389014: Merge 67017 - Fix a problem in createCanonicalUUIDString that causes the last...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3389014: Merge 67017 - Fix a problem in createCanonicalUUIDString that causes the last... (Closed)

Created:
10 years, 3 months ago by jianli

Modified:
9 years, 6 months ago

Reviewers:
jianli

CC:
chromium-reviews

Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/517/

Visibility:
Public.

Description

Merge 67017 - Fix a problem in createCanonicalUUIDString that causes the last digit missing on Linux. https://bugs.webkit.org/show_bug.cgi?id=45412 BUG=56287 TEST=none Reviewed by Darin Adler. WebCore: This is caused by not including the final null character into the count that is provided to fgets. This is covered by the existing test: send-form-data-with-sliced-file.html. * platform/UUID.cpp: (WebCore::createCanonicalUUIDString): LayoutTests: Remove the test that is now passing on Linux for chromium. * platform/chromium/test_expectations.txt: TBR=jianli@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=67663

Patch Set 1 #

Created: 10 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -6 lines)			Patch
	M	LayoutTests/platform/chromium/test_expectations.txt	View		1 chunk	+0 lines, -3 lines	0 comments	Download
	M	WebCore/platform/UUID.cpp	View		1 chunk	+4 lines, -3 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages