Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(325)

Side by Side Diff: WebCore/platform/UUID.cpp

Issue 3389014: Merge 67017 - Fix a problem in createCanonicalUUIDString that causes the last... (Closed) Base URL: http://svn.webkit.org/repository/webkit/branches/chromium/517/
Patch Set: Created 10 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « LayoutTests/platform/chromium/test_expectations.txt ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010 Google Inc. All rights reserved. 2 * Copyright (C) 2010 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 66 matching lines...) Expand 10 before | Expand all | Expand 10 after
77 String uuidStr(uuidStrRef); 77 String uuidStr(uuidStrRef);
78 CFRelease(uuidStrRef); 78 CFRelease(uuidStrRef);
79 CFRelease(uuid); 79 CFRelease(uuid);
80 String canonicalUuidStr = uuidStr.lower(); // make it lower. 80 String canonicalUuidStr = uuidStr.lower(); // make it lower.
81 ASSERT(canonicalUuidStr[uuidVersionIdentifierIndex] == uuidVersionRequired); 81 ASSERT(canonicalUuidStr[uuidVersionIdentifierIndex] == uuidVersionRequired);
82 return canonicalUuidStr; 82 return canonicalUuidStr;
83 #elif OS(LINUX) 83 #elif OS(LINUX)
84 FILE* fptr = fopen("/proc/sys/kernel/random/uuid", "r"); 84 FILE* fptr = fopen("/proc/sys/kernel/random/uuid", "r");
85 if (!fptr) 85 if (!fptr)
86 return String(); 86 return String();
87 char uuidStr[37] = {0}; 87 char uuidStr[37];
88 if (!fgets(uuidStr, sizeof(uuidStr) - 1, fptr)) 88 char* result = fgets(uuidStr, sizeof(uuidStr), fptr);
89 fclose(fptr);
90 if (!result)
89 return String(); 91 return String();
90 fclose(fptr);
91 String canonicalUuidStr = String(uuidStr).lower(); // make it lower. 92 String canonicalUuidStr = String(uuidStr).lower(); // make it lower.
92 ASSERT(canonicalUuidStr[uuidVersionIdentifierIndex] == uuidVersionRequired); 93 ASSERT(canonicalUuidStr[uuidVersionIdentifierIndex] == uuidVersionRequired);
93 return canonicalUuidStr; 94 return canonicalUuidStr;
94 #else 95 #else
95 notImplemented(); 96 notImplemented();
96 return String(); 97 return String();
97 #endif 98 #endif
98 } 99 }
99 100
100 } 101 }
OLDNEW
« no previous file with comments | « LayoutTests/platform/chromium/test_expectations.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698