Issue 3388021: Change the meaning of the command-line flag --proxy-server="socks://foo" to i...

Issue 3388021: Change the meaning of the command-line flag --proxy-server="socks://foo" to i... (Closed)

Created:
10 years, 3 months ago by eroman

Modified:
9 years, 6 months ago

Reviewers:
wtc

CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org, Paweł Hajdan Jr.

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Change the meaning of the command-line flag --proxy-server="socks://foo" to imply a SOCKS v5 proxy server rather than a SOCKS v4 proxy server. BUG=56831 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=60691

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 4

Patch Set 3 : '' #

Created: 10 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+21 lines, -13 lines)			Patch
M	chrome/app/resources/manpage.1.in	View	1 2	1 chunk	+7 lines, -4 lines	0 comments	Download
M	net/proxy/proxy_config_service_win_unittest.cc	View		2 chunks	+5 lines, -1 line	0 comments	Download
M	net/proxy/proxy_server.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	net/proxy/proxy_server.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	net/proxy/proxy_server_unittest.cc	View		1 chunk	+7 lines, -7 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

wtc

LGTM. http://codereview.chromium.org/3388021/diff/5001/6001 File chrome/app/resources/manpage.1.in (right): http://codereview.chromium.org/3388021/diff/5001/6001#newcode51 chrome/app/resources/manpage.1.in:51: "socks" is equivlent to "socks5". Isn't this platform ...

10 years, 3 months ago (2010-09-24 21:56:31 UTC) #2

eroman

10 years, 3 months ago (2010-09-24 22:03:42 UTC) #3

http://codereview.chromium.org/3388021/diff/5001/6001
File chrome/app/resources/manpage.1.in (right):

http://codereview.chromium.org/3388021/diff/5001/6001#newcode51
chrome/app/resources/manpage.1.in:51: "socks" is equivlent to "socks5".
On 2010/09/24 21:56:31, wtc wrote:
> Isn't this platform dependent?  Are you assuming the man page
> is only used on Unix-like systems such as Linux and Mac OS X?

This is true on all the platforms: this is specifically talking about the
command line arguments, and those will be interpreted the same on all platforms.

In other words:

 --proxy-server="socks://supdawg:99"

Will mean a SOCKS v5 proxy server on windows, linux, mac.

(And in fact this is the ONLY way short of PAC to configured SOCKS v5 on windows
chrome).

http://codereview.chromium.org/3388021/diff/5001/6001#newcode58
chrome/app/resources/manpage.1.in:58: --proxy-server="socks5://foobar:66"
On 2010/09/24 21:56:31, wtc wrote:
> This example should use socks4 now.

Good point, I have added a SOCKS v4 example.

Expand Messages | Collapse Messages