Change the meaning of the command-line flag --proxy-server="socks://foo" to i...

net/proxy/proxy_config_service_win_unittest.cc

 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/proxy/proxy_config_service_win.h"
 
 #include "net/base/net_errors.h"
 #include "net/proxy/proxy_config.h"
 #include "net/proxy/proxy_config_service_common_unittest.h"
 #include "testing/gtest/include/gtest/gtest.h"
@@ skipping 85 matching lines @@
       // Expected result.
       false,                                   // auto_detect
       GURL(),                                  // pac_url
       ProxyRulesExpectation::PerScheme(
           "www.google.com:80",  // http
           "www.foo.com:110",   // https
           "",                  // ftp
           ""),                 // bypass rules
     },
 
-    // SOCKS proxy configuration
+    // SOCKS proxy configuration.
     {
       { // Input.
         FALSE,                                            // fAutoDetect
         NULL,                                             // lpszAutoConfigUrl
         L"http=www.google.com:80;https=www.foo.com:110;"
         L"ftp=ftpproxy:20;socks=foopy:130",               // lpszProxy
         NULL,                                             // lpszProxy_bypass
       },
 
       // Expected result.
+      // Note that "socks" is interprted as meaning "socks4", since that is how
+      // Internet Explorer applies the settings. For more details on this
+      // policy, see:
+      // http://code.google.com/p/chromium/issues/detail?id=55912#c2
       false,                                   // auto_detect
       GURL(),                                  // pac_url
       ProxyRulesExpectation::PerSchemeWithSocks(
           "www.google.com:80",   // http
           "www.foo.com:110",     // https
           "ftpproxy:20",         // ftp
           "socks4://foopy:130",  // socks
           ""),                   // bypass rules
     },
 
@@ skipping 47 matching lines @@
     ProxyConfig config;
     ProxyConfigServiceWin::SetFromIEConfig(&config, tests[i].ie_config);
 
     EXPECT_EQ(tests[i].auto_detect, config.auto_detect());
     EXPECT_EQ(tests[i].pac_url, config.pac_url());
     EXPECT_TRUE(tests[i].proxy_rules.Matches(config.proxy_rules()));
   }
 }
 
 }  // namespace net