chrome/browser/metrics/metrics_service.cc - Issue 3386014: This adds some plumbing for propagating the status and error code of a

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/metrics/metrics_service.cc

Issue 3386014: This adds some plumbing for propagating the status and error code of a (Closed)

Patch Set: Fixed Mac code to handle both SEGV and BUS Created 10 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/metrics/metrics_service.cc

diff --git a/chrome/browser/metrics/metrics_service.cc b/chrome/browser/metrics/metrics_service.cc

index b6d4c3f6d755597045c227ebe926df84278a433a..d7503a69cc1313a392532ac88b048586714e77b7 100644

--- a/chrome/browser/metrics/metrics_service.cc

+++ b/chrome/browser/metrics/metrics_service.cc

@@ -618,7 +618,8 @@ void MetricsService::Observe(NotificationType type,

{

RenderProcessHost::RendererClosedDetails* process_details =

Details<RenderProcessHost::RendererClosedDetails>(details).ptr();

- if (process_details->did_crash) {

+ if (process_details->status ==

+ base::TERMINATION_STATUS_PROCESS_CRASHED) {

if (process_details->was_extension_renderer) {

LogExtensionRendererCrash();

} else {