Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Side by Side Diff: chrome/browser/metrics/metrics_service.cc

Issue 3386014: This adds some plumbing for propagating the status and error code of a (Closed)
Patch Set: Fixed Mac code to handle both SEGV and BUS Created 10 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 5
6 6
7 //------------------------------------------------------------------------------ 7 //------------------------------------------------------------------------------
8 // Description of the life cycle of a instance of MetricsService. 8 // Description of the life cycle of a instance of MetricsService.
9 // 9 //
10 // OVERVIEW 10 // OVERVIEW
(...skipping 600 matching lines...) Expand 10 before | Expand all | Expand 10 after
611 break; 611 break;
612 612
613 case NotificationType::LOAD_START: 613 case NotificationType::LOAD_START:
614 LogLoadStarted(); 614 LogLoadStarted();
615 break; 615 break;
616 616
617 case NotificationType::RENDERER_PROCESS_CLOSED: 617 case NotificationType::RENDERER_PROCESS_CLOSED:
618 { 618 {
619 RenderProcessHost::RendererClosedDetails* process_details = 619 RenderProcessHost::RendererClosedDetails* process_details =
620 Details<RenderProcessHost::RendererClosedDetails>(details).ptr(); 620 Details<RenderProcessHost::RendererClosedDetails>(details).ptr();
621 if (process_details->did_crash) { 621 if (process_details->status ==
622 base::TERMINATION_STATUS_PROCESS_CRASHED) {
622 if (process_details->was_extension_renderer) { 623 if (process_details->was_extension_renderer) {
623 LogExtensionRendererCrash(); 624 LogExtensionRendererCrash();
624 } else { 625 } else {
625 LogRendererCrash(); 626 LogRendererCrash();
626 } 627 }
627 } 628 }
628 } 629 }
629 break; 630 break;
630 631
631 case NotificationType::RENDERER_PROCESS_HANG: 632 case NotificationType::RENDERER_PROCESS_HANG:
(...skipping 1311 matching lines...) Expand 10 before | Expand all | Expand 10 after
1943 thread_id = PlatformThread::CurrentId(); 1944 thread_id = PlatformThread::CurrentId();
1944 return PlatformThread::CurrentId() == thread_id; 1945 return PlatformThread::CurrentId() == thread_id;
1945 } 1946 }
1946 1947
1947 #if defined(OS_CHROMEOS) 1948 #if defined(OS_CHROMEOS)
1948 void MetricsService::StartExternalMetrics() { 1949 void MetricsService::StartExternalMetrics() {
1949 external_metrics_ = new chromeos::ExternalMetrics; 1950 external_metrics_ = new chromeos::ExternalMetrics;
1950 external_metrics_->Start(); 1951 external_metrics_->Start();
1951 } 1952 }
1952 #endif 1953 #endif
OLDNEW
« no previous file with comments | « chrome/browser/in_process_webkit/indexed_db_key_utility_client.cc ('k') | chrome/browser/nacl_host/nacl_process_host.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698