Issue 338060: Disable a test that frequently crashes on Mac 10.5 Tests (dbg) bot (and I've ...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 338060: Disable a test that frequently crashes on Mac 10.5 Tests (dbg) bot (and I've ... (Closed)

Created:
11 years, 1 month ago by Finnur

Modified:
9 years, 6 months ago

Reviewers:
Aaron Boodman, lzheng, Paweł Hajdan Jr.

CC:
chromium-reviews_googlegroups.com, Erik does not do reviews, ben+cc_chromium.org, pam+watch_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Disable a test that frequently crashes on Mac 10.5 Tests (dbg) bot (and I've seen it crash on the try servers as well). TBR=lzheng BUG=26035 TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30325

Patch Set 1 #

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	chrome/browser/extensions/extension_updater_unittest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Aaron Boodman

Can we just disable it on mac then? And create a bug for it assigned ...

11 years, 1 month ago (2009-10-28 07:09:48 UTC) #2

Paweł Hajdan Jr.

Drive-by. Please always put a link to a bug in the source code when you're ...

11 years, 1 month ago (2009-10-28 07:17:20 UTC) #3

Finnur

11 years, 1 month ago (2009-10-28 15:55:22 UTC) #4

I usually put the bug in, but forgot this time. It was late in the night. :)

I have done what you two have suggested. See:
http://codereview.chromium.org/343019  (TBR'ed and checked in).

I didn't do the same for the test Nicolas added since I haven't seen that
test fail so I don't know what platform it is failing on...

On Wed, Oct 28, 2009 at 00:17, <phajdan.jr@chromium.org> wrote:

> Drive-by. Please always put a link to a bug in the source code when you're
> disabling a test.
>
>
> http://codereview.chromium.org/338060
>

Expand Messages | Collapse Messages