Issue 338041: Move a bunch of files into webkit/api/src...

Issue 338041: Move a bunch of files into webkit/api/src... (Closed)

Created:
11 years, 1 month ago by darin (slow to review)

Modified:
9 years, 7 months ago

Reviewers:
yaar

CC:
chromium-reviews_googlegroups.com, darin (slow to review)

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Move a bunch of files into webkit/api/src R=yaar BUG=25898, 25899, 25900, 25901 , TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30232

Patch Set 3 : '' #

Total comments: 1

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1463 lines, -2990 lines)			Patch
A +	webkit/api/src/BackForwardListClientImpl.h	View		1 chunk	+55 lines, -29 lines	0 comments	Download
A +	webkit/api/src/BackForwardListClientImpl.cpp	View		1 chunk	+98 lines, -61 lines	0 comments	Download
A +	webkit/api/src/ChromeClientImpl.h	View	1 2	2 chunks	+125 lines, -134 lines	0 comments	Download
A +	webkit/api/src/ChromeClientImpl.cpp	View	1 2	2 chunks	+474 lines, -444 lines	1 comment	Download
A +	webkit/api/src/DragClientImpl.h	View		2 chunks	+57 lines, -30 lines	0 comments	Download
A +	webkit/api/src/DragClientImpl.cpp	View		1 chunk	+77 lines, -57 lines	0 comments	Download
A +	webkit/api/src/InspectorClientImpl.h	View	1 2	1 chunk	+68 lines, -47 lines	0 comments	Download
A +	webkit/api/src/InspectorClientImpl.cpp	View		1 chunk	+197 lines, -166 lines	0 comments	Download
A +	webkit/api/src/WebPopupMenuImpl.h	View		2 chunks	+92 lines, -72 lines	0 comments	Download
A +	webkit/api/src/WebPopupMenuImpl.cpp	View	1	3 chunks	+193 lines, -166 lines	0 comments	Download
D	webkit/glue/back_forward_list_client_impl.h	View		1 chunk	+0 lines, -46 lines	0 comments	Download
D	webkit/glue/back_forward_list_client_impl.cc	View		1 chunk	+0 lines, -101 lines	0 comments	Download
D	webkit/glue/chrome_client_impl.h	View		1 chunk	+0 lines, -164 lines	0 comments	Download
D	webkit/glue/chrome_client_impl.cc	View		1 chunk	+0 lines, -632 lines	0 comments	Download
D	webkit/glue/dragclient_impl.h	View		1 chunk	+0 lines, -49 lines	0 comments	Download
D	webkit/glue/dragclient_impl.cc	View		1 chunk	+0 lines, -83 lines	0 comments	Download
D	webkit/glue/inspector_client_impl.h	View		1 chunk	+0 lines, -62 lines	0 comments	Download
D	webkit/glue/inspector_client_impl.cc	View		1 chunk	+0 lines, -231 lines	0 comments	Download
M	webkit/glue/webframeloaderclient_impl.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	webkit/glue/webkitclient_impl.cc	View		4 chunks	+4 lines, -3 lines	0 comments	Download
D	webkit/glue/webpopupmenu_impl.h	View		1 chunk	+0 lines, -108 lines	0 comments	Download
D	webkit/glue/webpopupmenu_impl.cc	View		1 chunk	+0 lines, -284 lines	0 comments	Download
M	webkit/glue/webview_impl.h	View		2 chunks	+8 lines, -8 lines	0 comments	Download
M	webkit/glue/webview_impl.cc	View		3 chunks	+3 lines, -1 line	0 comments	Download
M	webkit/webkit.gyp	View		6 chunks	+10 lines, -10 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

yaar

LGTM after a single nit. http://codereview.chromium.org/338041/diff/5001/5006 File webkit/api/src/ChromeClientImpl.cpp (right): http://codereview.chromium.org/338041/diff/5001/5006#newcode568 Line 568: chooserCompletion->didChooseFile(WebVector<WebString>()); nit: 4 ...

11 years, 1 month ago (2009-10-27 18:48:34 UTC) #2

darin (slow to review)

11 years, 1 month ago (2009-10-27 19:18:46 UTC) #3

Thanks!
-Darin

On Tue, Oct 27, 2009 at 11:48 AM, <yaar@chromium.org> wrote:

> LGTM after a single nit.
>
>
> http://codereview.chromium.org/338041/diff/5001/5006
> File webkit/api/src/ChromeClientImpl.cpp (right):
>
> http://codereview.chromium.org/338041/diff/5001/5006#newcode568
> Line 568: chooserCompletion->didChooseFile(WebVector<WebString>());
> nit: 4 space indent
>
>
> http://codereview.chromium.org/338041
>

Expand Messages | Collapse Messages