Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 338037: linux: fix gcc 4.3 issues (for arm) (Closed)

Created:
11 years, 1 month ago by piman
Modified:
9 years, 7 months ago
Reviewers:
ncarter (slow)
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

linux: fix gcc 4.3 issues (for arm) These are mostly minor syntax / missing header fixes. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30277

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -10 lines) Patch
M chrome/browser/sync/engine/conflict_resolver.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/sync/engine/syncer_util.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/notifier/listener/listen_task.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/notifier/listener/mediator_thread_impl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/syncable/syncable.cc View 1 chunk +1 line, -0 lines 1 comment Download
M chrome/browser/sync/util/character_set_converters_posix.cc View 1 chunk +6 lines, -4 lines 0 comments Download
M third_party/libjingle/files/talk/base/cryptstring.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/libjingle/files/talk/base/host.cc View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/libjingle/files/talk/base/natserver.cc View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/libjingle/files/talk/base/natsocketfactory.cc View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/libjingle/files/talk/base/socketadapters.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/libjingle/files/talk/base/stringencode.cc View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/libjingle/files/talk/base/stringutils.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/libjingle/files/talk/base/testclient.cc View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/libjingle/files/talk/base/urlencode.cc View 1 chunk +2 lines, -0 lines 2 comments Download
M third_party/libjingle/files/talk/p2p/base/port.cc View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/libjingle/files/talk/p2p/base/relayport.cc View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/libjingle/files/talk/p2p/base/stun.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
ncarter (slow)
LGTM http://codereview.chromium.org/338037/diff/1/6 File chrome/browser/sync/syncable/syncable.cc (right): http://codereview.chromium.org/338037/diff/1/6#newcode1631 Line 1631: val.is_deleted = false; Ouch. Thanks. http://codereview.chromium.org/338037/diff/1/16 File ...
11 years, 1 month ago (2009-10-27 20:13:51 UTC) #1
ncarter (slow)
11 years, 1 month ago (2009-10-27 20:17:49 UTC) #2
http://codereview.chromium.org/338037/diff/1/16
File third_party/libjingle/files/talk/base/urlencode.cc (right):

http://codereview.chromium.org/338037/diff/1/16#newcode3
Line 3: #include "talk/base/urlencode.h"
On 2009/10/27 20:13:51, nick wrote:
> Somehow this file got to be without a copyright notice.  I'll track down the
> history and fix that.

Oh, actually, this is the way it is in the libjingle release.

Powered by Google App Engine
This is Rietveld 408576698