third_party/libjingle/files/talk/base/urlencode.cc - Issue 338037: linux: fix gcc 4.3 issues (for arm)

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/libjingle/files/talk/base/urlencode.cc

Issue 338037: linux: fix gcc 4.3 issues (for arm) (Closed)

Patch Set: Created 11 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
	1 #include <stdlib.h>

	2 #include <string.h>

1 #include "talk/base/urlencode.h"	3 #include "talk/base/urlencode.h"
	ncarter (slow) 2009/10/27 20:13:51 Somehow this file got to be without a copyright no Somehow this file got to be without a copyright notice. I'll track down the history and fix that. ncarter (slow) 2009/10/27 20:17:49 Oh, actually, this is the way it is in the libjing Show quoted text On 2009/10/27 20:13:51, nick wrote: > Somehow this file got to be without a copyright notice. I'll track down the > history and fix that. Oh, actually, this is the way it is in the libjingle release.
2	4

3 static int HexPairValue(const char * code) {	5 static int HexPairValue(const char * code) {

4 int value = 0;	6 int value = 0;

5 const char * pch = code;	7 const char * pch = code;

6 for (;;) {	8 for (;;) {

7 int digit = *pch++;	9 int digit = *pch++;

8 if (digit >= '0' && digit <= '9') {	10 if (digit >= '0' && digit <= '9') {

9 value += digit - '0';	11 value += digit - '0';

10 }	12 }

11 else if (digit >= 'A' && digit <= 'F') {	13 else if (digit >= 'A' && digit <= 'F') {

(...skipping 99 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
111 char stackalloc[64];	113 char stackalloc[64];

112 char * buf = needed_length > sizeof(stackalloc)/sizeof(*stackalloc) ?	114 char * buf = needed_length > sizeof(stackalloc)/sizeof(*stackalloc) ?

113 (char *)malloc(needed_length) : stackalloc;	115 (char *)malloc(needed_length) : stackalloc;

114 UrlEncode(decoded.c_str(), buf, needed_length);	116 UrlEncode(decoded.c_str(), buf, needed_length);

115 std::string result(buf);	117 std::string result(buf);

116 if (buf != stackalloc) {	118 if (buf != stackalloc) {

117 free(buf);	119 free(buf);

118 }	120 }

119 return result;	121 return result;

120 }	122 }

OLD	NEW