Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Issue 338026: Webkit merge from 50073:50101. (Closed)

Created:
11 years, 1 month ago by tony
Modified:
9 years, 7 months ago
Reviewers:
jorlow
CC:
chromium-reviews_googlegroups.com, ryosuke.niwa
Visibility:
Public.

Description

Webkit merge from 50073:50101. A couple tests added by chromium folks that need to be rebaselined. TBR=jorlow Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30121

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M webkit/tools/layout_tests/test_expectations.txt View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
tony
11 years, 1 month ago (2009-10-26 22:33:43 UTC) #1
jorlow
LGTM On Mon, Oct 26, 2009 at 3:33 PM, <tony@chromium.org> wrote: > Reviewers: Jeremy Orlow, ...
11 years, 1 month ago (2009-10-26 22:51:27 UTC) #2
ryosuke.niwa
11 years, 1 month ago (2009-10-26 22:52:07 UTC) #3
Mn... weird.  So it's failing on chromium tree?
remove-nested-inline-styles.html
is a new test, and I thought all new test's expected results are
automatically grabbed into the chromimum tree automatically.

Ryosuke

On Mon, Oct 26, 2009 at 3:44 PM, Jeremy Orlow <jorlow@chromium.org> wrote:

> LGTM
>
>
> On Mon, Oct 26, 2009 at 3:33 PM, <tony@chromium.org> wrote:
>
>> Reviewers: Jeremy Orlow,
>>
>> Description:
>> Webkit merge from 50073:50101.
>>
>> A couple tests added by chromium folks that need to be rebaselined.
>>
>> TBR=jorlow
>>
>> Please review this at http://codereview.chromium.org/338026
>>
>> Affected files:
>>  M DEPS
>>  M webkit/tools/layout_tests/test_expectations.txt
>>
>>
>> Index: DEPS
>> diff --git a/DEPS b/DEPS
>> index
>>
bf2313e91231cd58580fe946e98ad7001cdec41e..6e93406233b25dc290cd11a27e4baea0db7ece04
>> 100644
>> --- a/DEPS
>> +++ b/DEPS
>> @@ -1,7 +1,7 @@
>>  vars = {
>>   "webkit_trunk":
>>     "http://svn.webkit.org/repository/webkit/trunk",
>> -  "webkit_revision": "50073",
>> +  "webkit_revision": "50101",
>>   "ffmpeg_revision": "28488",
>>  }
>>
>> Index: webkit/tools/layout_tests/test_expectations.txt
>> diff --git a/webkit/tools/layout_tests/test_expectations.txt
>> b/webkit/tools/layout_tests/test_expectations.txt
>> index
>>
0152b68a8c5bca7f480b11f98b01433a00978997..3c5ebcd0683ff11da8c69e415d41a4eb67530fcf
>> 100644
>> --- a/webkit/tools/layout_tests/test_expectations.txt
>> +++ b/webkit/tools/layout_tests/test_expectations.txt
>> @@ -3255,3 +3255,9 @@ BUG_TONY :
>> LayoutTests/media/video-seek-past-end-paused.html = FAIL
>>  BUG_TONY : LayoutTests/media/video-src-change.html = FAIL
>>  BUG_TONY LINUX : LayoutTests/media/video-seekable.html = FAIL
>>  BUG_TONY MAC : LayoutTests/media/video-error-abort.html = FAIL
>> +
>> +// WebKit roll 50073:50101
>> +// jorlow to add expected results.
>> +BUG_JORLOW : LayoutTests/storage/domstorage/documentURI.html = FAIL
>> +// Test added by Ryosuke: http://trac.webkit.org/changeset/50090
>> +BUG_TONY : LayoutTests/editing/style/remove-nested-inline-styles.html =
>> FAIL
>>
>>
>>
>

Powered by Google App Engine
This is Rietveld 408576698