Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8663)

Unified Diff: chrome_frame/utils.cc

Issue 338025: Remove the Chrome Frame preprocessor define in chrome_constants.cc (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 11 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/common/chrome_paths_mac.mm ('K') | « chrome_frame/utils.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome_frame/utils.cc
===================================================================
--- chrome_frame/utils.cc (revision 30046)
+++ chrome_frame/utils.cc (working copy)
@@ -14,8 +14,6 @@
#include "base/registry.h"
#include "base/scoped_comptr_win.h"
#include "base/string_util.h"
-#include "chrome/common/chrome_constants.h"
-#include "chrome/installer/util/google_update_constants.h"
#include "googleurl/src/gurl.h"
#include "grit/chrome_frame_resources.h"
#include "chrome_frame/resource.h"
@@ -548,28 +546,3 @@
return false;
}
-
-// TODO(robertshield): Register and use Chrome's PathProviders.
-// - Note that this function is used by unit tests as well to override
-// PathService paths, so please test when addressing todo.
-bool GetUserProfileBaseDirectory(std::wstring* path) {
- DCHECK(path);
- wchar_t path_buffer[MAX_PATH * 4];
- path_buffer[0] = 0;
- // TODO(robertshield): Ideally we should use SHGetFolderLocation and then
- // get a path via PIDL.
- HRESULT hr = SHGetFolderPath(NULL, CSIDL_LOCAL_APPDATA, NULL,
- SHGFP_TYPE_CURRENT, path_buffer);
-
- if (SUCCEEDED(hr)) {
- *path = path_buffer;
-#if defined(GOOGLE_CHROME_BUILD)
- file_util::AppendToPath(path, FILE_PATH_LITERAL("Google"));
-#endif
- file_util::AppendToPath(path, chrome::kBrowserAppName);
- file_util::AppendToPath(path, chrome::kUserDataDirname);
- return true;
- }
-
- return false;
-}
« chrome/common/chrome_paths_mac.mm ('K') | « chrome_frame/utils.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698