Remove the Chrome Frame preprocessor define in chrome_constants.cc

chrome/common/chrome_paths_mac.mm

Index: chrome/common/chrome_paths_mac.mm
===================================================================
--- chrome/common/chrome_paths_mac.mm	(revision 30046)
+++ chrome/common/chrome_paths_mac.mm	(working copy)
@@ -27,6 +27,19 @@
   return success;
 }
 
+bool GetChromeFrameUserDataDirectory(FilePath* result) {
+  bool success = false;
+  if (result && PathService::Get(base::DIR_APP_DATA, result)) {
+#if defined(GOOGLE_CHROME_BUILD)
+    *result = result->Append("Google").Append("Chrome Frame");
+#else
+    *result = result->Append("Chrome Frame");
+#endif

[kuchhal, 2009/10/27 18:47:26]

I think you want to check for Chrome Frame Build. And this also brings up my
original concern again. Currently Google Chrome and Chromium are separate
products so have their own installation directory as well as User Data
directory.

Will Google Chrome Frame make a Chromium version available? If yes then it
probably needs to install in its own path and have a different User Data dir.

[robertshield, 2009/10/27 19:55:37]

This method is specific to Chrome Frame and so (as proposed here), is always
present regardless of whether CHROME_FRAME_BUILD is defined. 

The GOOGLE_CHROME_BUILD check here determines whether we put 
things in a "Google" sub-directory or not.

And this also brings up my
There aren't any specific plans along these lines. What I'd like to do is keep
GOOGLE_CHROME_BUILD as the gatekeeper flag that determines whether this is an
official release or not and modify the Chrome Frame bits of code to behave
accordingly as I have done here with the user data dir.

+    success = true;
+  }
+  return success;
+}
+
 bool GetUserDocumentsDirectory(FilePath* result) {
   bool success = false;
   NSArray* docArray =