Issue 3380024: Adding a FileUtilProxy::TouchFile() method that takes a FilePath as an...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3380024: Adding a FileUtilProxy::TouchFile() method that takes a FilePath as an... (Closed)

Created:
10 years, 3 months ago by dumi

Modified:
9 years, 7 months ago

Reviewers:
Kavita Kanetkar, darin (slow to review)

CC:
chromium-reviews, brettw-cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Adding a FileUtilProxy::TouchFile() method that takes a FilePath as an argument (instead of PlatformFile). BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=60397

Patch Set 1 #

Created: 10 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+45 lines, -0 lines)			Patch
	M	base/file_util_proxy.h	View		1 chunk	+8 lines, -0 lines	0 comments	Download
	M	base/file_util_proxy.cc	View		2 chunks	+37 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Kavita Kanetkar

LG. The test case for this is covered in file_util's unittest?

10 years, 3 months ago (2010-09-23 17:33:46 UTC) #2

dumi

10 years, 3 months ago (2010-09-23 18:35:47 UTC) #4

On 2010/09/23 17:33:46, Kavita Kanetkar wrote:
> LG.
> 
> The test case for this is covered in file_util's unittest?

yes, i changed a test case in file_util_unittest.cc to cover this in
http://codereview.chromium.org/3404018.

Expand Messages | Collapse Messages